From 57d68bb541a57e6940d020fdde6c8009c190bd20 Mon Sep 17 00:00:00 2001 From: fearlessTobi Date: Sat, 13 Oct 2018 13:33:04 +0200 Subject: [PATCH] Address review comments --- externals/CMakeLists.txt | 2 +- src/web_service/announce_room_json.cpp | 2 +- src/web_service/web_backend.cpp | 6 +++--- 3 files changed, 5 insertions(+), 5 deletions(-) diff --git a/externals/CMakeLists.txt b/externals/CMakeLists.txt index 641884a3f..13b347d89 100644 --- a/externals/CMakeLists.txt +++ b/externals/CMakeLists.txt @@ -80,7 +80,7 @@ if (ENABLE_WEB_SERVICE) set(LIBRESSL_SKIP_INSTALL ON CACHE BOOL "") add_subdirectory(libressl EXCLUDE_FROM_ALL) target_include_directories(ssl INTERFACE ./libressl/include) - target_compile_definitions(ssl PRIVATE -DHAVE_INET_NTOP) + target_compile_definitions(ssl PRIVATE -DHAVE_INET_NTOP) # lurlparser add_subdirectory(lurlparser EXCLUDE_FROM_ALL) diff --git a/src/web_service/announce_room_json.cpp b/src/web_service/announce_room_json.cpp index 6a6512491..c0d543e73 100644 --- a/src/web_service/announce_room_json.cpp +++ b/src/web_service/announce_room_json.cpp @@ -3,10 +3,10 @@ // Refer to the license.txt file included. #include +#include #include "common/detached_tasks.h" #include "common/logging/log.h" #include "web_service/announce_room_json.h" -#include "web_service/json.h" #include "web_service/web_backend.h" namespace AnnounceMultiplayerRoom { diff --git a/src/web_service/web_backend.cpp b/src/web_service/web_backend.cpp index c1f320738..fc702a378 100644 --- a/src/web_service/web_backend.cpp +++ b/src/web_service/web_backend.cpp @@ -15,10 +15,10 @@ namespace WebService { constexpr std::array API_VERSION{'1'}; -constexpr u32 HTTP_PORT = 80; -constexpr u32 HTTPS_PORT = 443; +constexpr int HTTP_PORT = 80; +constexpr int HTTPS_PORT = 443; -constexpr u32 TIMEOUT_SECONDS = 30; +constexpr std::size_t TIMEOUT_SECONDS = 30; Client::JWTCache Client::jwt_cache{};