From 5840943110037a3b8ec91ebc1eccaa857c894a44 Mon Sep 17 00:00:00 2001 From: Lioncash Date: Sun, 2 Dec 2018 14:14:32 -0500 Subject: [PATCH] yuzu/configuration: Make slots private where applicable These slots are only ever attached to event handling mechanisms within the class itself, they're never used externally. Because of this, we can make the functions private. This also removes redundant usages of the private access specifier. --- src/citra_qt/configuration/configure_audio.h | 3 +-- src/citra_qt/configuration/configure_debug.h | 1 - src/citra_qt/configuration/configure_dialog.h | 1 - src/citra_qt/configuration/configure_graphics.h | 1 - src/citra_qt/configuration/configure_web.h | 3 +-- 5 files changed, 2 insertions(+), 7 deletions(-) diff --git a/src/citra_qt/configuration/configure_audio.h b/src/citra_qt/configuration/configure_audio.h index 144a630b0..b8e347a42 100644 --- a/src/citra_qt/configuration/configure_audio.h +++ b/src/citra_qt/configuration/configure_audio.h @@ -22,10 +22,9 @@ public: void retranslateUi(); void setConfiguration(); -public slots: +private: void updateAudioDevices(int sink_index); -private: void setOutputSinkFromSinkID(); void setAudioDeviceFromDeviceID(); void setVolumeIndicatorText(int percentage); diff --git a/src/citra_qt/configuration/configure_debug.h b/src/citra_qt/configuration/configure_debug.h index 20a35df63..4170c487f 100644 --- a/src/citra_qt/configuration/configure_debug.h +++ b/src/citra_qt/configuration/configure_debug.h @@ -22,6 +22,5 @@ public: void retranslateUi(); void setConfiguration(); -private: std::unique_ptr ui; }; diff --git a/src/citra_qt/configuration/configure_dialog.h b/src/citra_qt/configuration/configure_dialog.h index 4aa5ce0d5..b60b4207b 100644 --- a/src/citra_qt/configuration/configure_dialog.h +++ b/src/citra_qt/configuration/configure_dialog.h @@ -34,6 +34,5 @@ private: void setConfiguration(); void retranslateUi(); -private: std::unique_ptr ui; }; diff --git a/src/citra_qt/configuration/configure_graphics.h b/src/citra_qt/configuration/configure_graphics.h index a872c7717..478bebe2a 100644 --- a/src/citra_qt/configuration/configure_graphics.h +++ b/src/citra_qt/configuration/configure_graphics.h @@ -22,7 +22,6 @@ public: void retranslateUi(); void setConfiguration(); -private: std::unique_ptr ui; QColor bg_color; }; diff --git a/src/citra_qt/configuration/configure_web.h b/src/citra_qt/configuration/configure_web.h index 5fcea0c6f..d52bab7a0 100644 --- a/src/citra_qt/configuration/configure_web.h +++ b/src/citra_qt/configuration/configure_web.h @@ -23,13 +23,12 @@ public: void retranslateUi(); void setConfiguration(); -public slots: +private: void RefreshTelemetryID(); void OnLoginChanged(); void VerifyLogin(); void OnLoginVerified(); -private: bool user_verified = true; QFutureWatcher verify_watcher;