From 1221221595122c212ace8bc50f2904bead8d2655 Mon Sep 17 00:00:00 2001 From: wxiaoguang Date: Thu, 7 Sep 2023 16:00:20 +0800 Subject: [PATCH] Add "dir=auto" for input/textarea elements by default (#26735) Co-authored-by: silverwind Co-authored-by: Giteabot --- web_src/css/base.css | 1 + web_src/js/index.js | 2 ++ web_src/js/modules/dirauto.js | 39 +++++++++++++++++++++++++++++++++++ 3 files changed, 42 insertions(+) create mode 100644 web_src/js/modules/dirauto.js diff --git a/web_src/css/base.css b/web_src/css/base.css index 9f42610641..8542248d90 100644 --- a/web_src/css/base.css +++ b/web_src/css/base.css @@ -478,6 +478,7 @@ a.label, /* fix Fomantic's line-height cutting off "g" on Windows Chrome with Segoe UI */ .ui.input > input { line-height: var(--line-height-default); + text-align: start; /* Override fomantic's `text-align: left` to make RTL work via HTML `dir="auto"` */ } .ui.input.focus > input, diff --git a/web_src/js/index.js b/web_src/js/index.js index 8bd219bbe1..7ae4b0c0c7 100644 --- a/web_src/js/index.js +++ b/web_src/js/index.js @@ -84,9 +84,11 @@ import {onDomReady} from './utils/dom.js'; import {initRepoIssueList} from './features/repo-issue-list.js'; import {initCommonIssueListQuickGoto} from './features/common-issue-list.js'; import {initRepoDiffCommitBranchesAndTags} from './features/repo-diff-commit.js'; +import {initDirAuto} from './modules/dirauto.js'; // Init Gitea's Fomantic settings initGiteaFomantic(); +initDirAuto(); onDomReady(() => { initGlobalCommon(); diff --git a/web_src/js/modules/dirauto.js b/web_src/js/modules/dirauto.js new file mode 100644 index 0000000000..91f71a5b85 --- /dev/null +++ b/web_src/js/modules/dirauto.js @@ -0,0 +1,39 @@ +// for performance considerations, it only uses performant syntax + +function attachDirAuto(el) { + if (el.type !== 'hidden' && + el.type !== 'checkbox' && + el.type !== 'radio' && + el.type !== 'range' && + el.type !== 'color') { + el.dir = 'auto'; + } +} + +export function initDirAuto() { + const observer = new MutationObserver((mutationList) => { + const len = mutationList.length; + for (let i = 0; i < len; i++) { + const mutation = mutationList[i]; + const len = mutation.addedNodes.length; + for (let i = 0; i < len; i++) { + const addedNode = mutation.addedNodes[i]; + if (addedNode.nodeType !== Node.ELEMENT_NODE && addedNode.nodeType !== Node.DOCUMENT_FRAGMENT_NODE) continue; + attachDirAuto(addedNode); + const children = addedNode.querySelectorAll('input, textarea'); + const len = children.length; + for (let childIdx = 0; childIdx < len; childIdx++) { + attachDirAuto(children[childIdx]); + } + } + } + }); + + const docNodes = document.querySelectorAll('input, textarea'); + const len = docNodes.length; + for (let i = 0; i < len; i++) { + attachDirAuto(docNodes[i]); + } + + observer.observe(document, {subtree: true, childList: true}); +}