From 170177c40527716d938b4e7f05a27cfb9a52be86 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Matthias=20Ri=C3=9Fe?= Date: Tue, 10 Oct 2023 14:00:58 +0200 Subject: [PATCH] Do not block the database during archive creation --- services/repository/archiver/archiver.go | 15 +++++++++++++++ 1 file changed, 15 insertions(+) diff --git a/services/repository/archiver/archiver.go b/services/repository/archiver/archiver.go index f6f03e75ae..6aaf83c6c9 100644 --- a/services/repository/archiver/archiver.go +++ b/services/repository/archiver/archiver.go @@ -266,6 +266,13 @@ func doArchive(r *ArchiveRequest) (*repo_model.RepoArchiver, error) { // TODO: add lfs data to zip // TODO: add submodule data to zip + // Commit and close here to avoid blocking the database for the entirety of the archive generation process + err = committer.Commit() + if err != nil { + return nil, err + } + committer.Close() + if _, err := storage.RepoArchives.Save(rPath, rd, -1); err != nil { return nil, fmt.Errorf("unable to write archive: %w", err) } @@ -275,6 +282,14 @@ func doArchive(r *ArchiveRequest) (*repo_model.RepoArchiver, error) { return nil, err } + txCtx, committer, err = db.TxContext(db.DefaultContext) + if err != nil { + return nil, err + } + defer committer.Close() + ctx, _, finished = process.GetManager().AddContext(txCtx, fmt.Sprintf("ArchiveRequest[%d]: %s", r.RepoID, r.GetArchiveName())) + defer finished() + if archiver.Status == repo_model.ArchiverGenerating { archiver.Status = repo_model.ArchiverReady if err = repo_model.UpdateRepoArchiverStatus(ctx, archiver); err != nil {