gitea

Commit Graph

Author	SHA1	Message	Date
Giteabot	026167f854	Remove assertion debug code for show/hide refactoring (#23576 ) (#23868 ) Backport #23576 by @wxiaoguang When doing the refactoring: * #22950 I added some debug mode code (assertShown) to help to catch bugs, it did catch some bugs like: * #23074 If it has been proved that there is no more bugs, this assertion could be removed easily and clearly. Feel free to decide when to remove it (feel free to convert it from Draft to Ready for Review).	2023-04-02 16:20:06 +08:00
wxiaoguang	a7e98d70b6	Fix the show/hide methods for string selector (#23042 ) At that moment I made a mistake (failed to detect a JS variable type correctly) Close #23040	2023-02-21 11:09:03 -06:00
wxiaoguang	d32af84a10	Refactor hiding-methods, remove jQuery show/hide, remove `.hide` class, remove inline style=display:none (#22950 ) Close #22847 This PR: * introduce Gitea's own `showElem` and related functions * remove jQuery show/hide * remove .hide class * remove inline style=display:none From now on: do not use: * "[hidden]" attribute: it's too weak, can not be applied to an element with "display: flex" * ".hidden" class: it has been polluted by Fomantic UI in many cases * inline style="display: none": it's difficult to tweak * jQuery's show/hide/toggle: it can not show/hide elements with "display: xxx !important" only use: * this ".gt-hidden" class * showElem/hideElem/toggleElem functions in "utils/dom.js" cc: @silverwind , this is the all-in-one PR	2023-02-19 12:06:14 +08:00

Author

SHA1

Message

Date

Giteabot

026167f854

Remove assertion debug code for show/hide refactoring (#23576 ) (#23868 )

Backport #23576 by @wxiaoguang

When doing the refactoring:

* #22950

I added some debug mode code (assertShown) to help to catch bugs, it did
catch some bugs like:

* #23074

If it has been proved that there is no more bugs, this assertion could
be removed easily and clearly.

Feel free to decide when to remove it (feel free to convert it from
Draft to Ready for Review).

2023-04-02 16:20:06 +08:00

wxiaoguang

a7e98d70b6

Fix the show/hide methods for string selector (#23042 )

At that moment I made a mistake (failed to detect a JS variable type
correctly)

Close #23040

2023-02-21 11:09:03 -06:00

wxiaoguang

d32af84a10

Refactor hiding-methods, remove jQuery show/hide, remove `.hide` class, remove inline style=display:none (#22950 )

Close #22847

This PR:

* introduce Gitea's own `showElem` and related functions
* remove jQuery show/hide
* remove .hide class
* remove inline style=display:none 

From now on:

do not use:
* "[hidden]" attribute: it's too weak, can not be applied to an element
with "display: flex"
* ".hidden" class: it has been polluted by Fomantic UI in many cases
* inline style="display: none": it's difficult to tweak
* jQuery's show/hide/toggle: it can not show/hide elements with
"display: xxx !important"

only use:
* this ".gt-hidden" class
* showElem/hideElem/toggleElem functions in "utils/dom.js"

cc: @silverwind , this is the all-in-one PR

2023-02-19 12:06:14 +08:00

3 Commits