gitea/services
oliverpool 26653b196b
Store webhook event in database (#29145)
Refactor the webhook logic, to have the type-dependent processing happen
only in one place.

---

## Current webhook flow

1. An event happens
2. It is pre-processed (depending on the webhook type) and its body is
added to a task queue
3. When the task is processed, some more logic (depending on the webhook
type as well) is applied to make an HTTP request

This means that webhook-type dependant logic is needed in step 2 and 3.
This is cumbersome and brittle to maintain.

Updated webhook flow with this PR:
1. An event happens
2. It is stored as-is and added to a task queue
3. When the task is processed, the event is processed (depending on the
webhook type) to make an HTTP request

So the only webhook-type dependent logic happens in one place (step 3)
which should be much more robust.

## Consequences of the refactor

- the raw event must be stored in the hooktask (until now, the
pre-processed body was stored)
- to ensure that previous hooktasks are correctly sent, a
`payload_version` is added (version 1: the body has already been
pre-process / version 2: the body is the raw event)

So future webhook additions will only have to deal with creating an
http.Request based on the raw event (no need to adjust the code in
multiple places, like currently).

Moreover since this processing happens when fetching from the task
queue, it ensures that the queuing of new events (upon a `git push` for
instance) does not get slowed down by a slow webhook.

As a concrete example, the PR #19307 for custom webhooks, should be
substantially smaller:
- no need to change `services/webhook/deliver.go` 
- minimal change in `services/webhook/webhook.go` (add the new webhook
to the map)
- no need to change all the individual webhook files (since with this
refactor the `*webhook_model.Webhook` is provided as argument)
2024-03-07 23:18:38 +01:00
..
actions Add ac claim for old docker/build-push-action@v3 / current buildx gha cache (#29584) 2024-03-05 17:34:42 +00:00
agit A small refactor for agit implementation (#29614) 2024-03-06 05:52:48 +00:00
asymkey Move some asymkey functions to service layer (#28894) 2024-03-04 08:57:39 +00:00
attachment Add support for API blob upload of release attachments (#29507) 2024-03-02 17:02:01 +00:00
auth Move some asymkey functions to service layer (#28894) 2024-03-04 08:57:39 +00:00
automerge Simplify how git repositories are opened (#28937) 2024-01-27 21:09:51 +01:00
context Use strict protocol check when redirect (#29642) 2024-03-07 02:03:41 +00:00
contexttest Make "/user/login" page redirect if the current user has signed in (#29583) 2024-03-05 02:12:03 +00:00
convert Enable/disable owner and repo projects independently (#28805) 2024-03-04 02:56:52 +00:00
cron Move some asymkey functions to service layer (#28894) 2024-03-04 08:57:39 +00:00
doctor Move some asymkey functions to service layer (#28894) 2024-03-04 08:57:39 +00:00
externalaccount Revert "Support SAML authentication (#25165)" (#29358) 2024-02-24 12:18:49 +08:00
feed More db.DefaultContext refactor (#27265) 2023-09-29 12:12:54 +00:00
forms Make wiki default branch name changable (#29603) 2024-03-06 14:26:32 +08:00
gitdiff Fix incorrect diff expander for deletion of last lines in a file (#29501) 2024-03-01 16:12:21 +00:00
indexer Fix missing issue search index update when changing status (#28325) 2023-12-03 12:22:44 +01:00
issue Add missing database transaction for new issue (#29490) 2024-03-04 11:24:02 +00:00
lfs Move context from modules to services (#29440) 2024-02-27 08:12:22 +01:00
mailer Move context from modules to services (#29440) 2024-02-27 08:12:22 +01:00
markup Move context from modules to services (#29440) 2024-02-27 08:12:22 +01:00
migrations remove util.OptionalBool and related functions (#29513) 2024-03-02 16:42:31 +01:00
mirror Simplify how git repositories are opened (#28937) 2024-01-27 21:09:51 +01:00
notify Update status and code index after changing the default branch (#27018) 2023-09-13 04:43:31 +00:00
org Delete repos of org when purge delete user (#27273) 2023-10-19 13:16:11 +00:00
packages remove util.OptionalBool and related functions (#29513) 2024-03-02 16:42:31 +01:00
pull Add user blocking (#29028) 2024-03-04 08:16:03 +00:00
release Use the database object format name but not read from git repoisitory everytime and fix possible migration wrong objectformat when migrating a sha256 repository (#29294) 2024-02-24 06:55:19 +00:00
repository Add download URL for executable files (#28260) 2024-03-06 16:10:06 +00:00
secrets Refactor deletion (#28610) 2023-12-25 21:25:29 +01:00
task Fix incorrect ctx usage in defer function (#27740) 2023-10-22 14:12:27 +00:00
uinotification Penultimate round of db.DefaultContext refactor (#27414) 2023-10-11 04:24:07 +00:00
user Skip email domain check when admins edit user emails (#29609) 2024-03-05 16:51:56 +00:00
webhook Store webhook event in database (#29145) 2024-03-07 23:18:38 +01:00
wiki Make wiki default branch name changable (#29603) 2024-03-06 14:26:32 +08:00