mirror of
https://github.com/go-gitea/gitea.git
synced 2024-09-11 05:43:47 +02:00
## ⚠️ Breaking The `log.<mode>.<logger>` style config has been dropped. If you used it, please check the new config manual & app.example.ini to make your instance output logs as expected. Although many legacy options still work, it's encouraged to upgrade to the new options. The SMTP logger is deleted because SMTP is not suitable to collect logs. If you have manually configured Gitea log options, please confirm the logger system works as expected after upgrading. ## Description Close #12082 and maybe more log-related issues, resolve some related FIXMEs in old code (which seems unfixable before) Just like rewriting queue #24505 : make code maintainable, clear legacy bugs, and add the ability to support more writers (eg: JSON, structured log) There is a new document (with examples): `logging-config.en-us.md` This PR is safer than the queue rewriting, because it's just for logging, it won't break other logic. ## The old problems The logging system is quite old and difficult to maintain: * Unclear concepts: Logger, NamedLogger, MultiChannelledLogger, SubLogger, EventLogger, WriterLogger etc * Some code is diffuclt to konw whether it is right: `log.DelNamedLogger("console")` vs `log.DelNamedLogger(log.DEFAULT)` vs `log.DelLogger("console")` * The old system heavily depends on ini config system, it's difficult to create new logger for different purpose, and it's very fragile. * The "color" trick is difficult to use and read, many colors are unnecessary, and in the future structured log could help * It's difficult to add other log formats, eg: JSON format * The log outputer doesn't have full control of its goroutine, it's difficult to make outputer have advanced behaviors * The logs could be lost in some cases: eg: no Fatal error when using CLI. * Config options are passed by JSON, which is quite fragile. * INI package makes the KEY in `[log]` section visible in `[log.sub1]` and `[log.sub1.subA]`, this behavior is quite fragile and would cause more unclear problems, and there is no strong requirement to support `log.<mode>.<logger>` syntax. ## The new design See `logger.go` for documents. ## Screenshot <details> ![image](https://github.com/go-gitea/gitea/assets/2114189/4462d713-ba39-41f5-bb08-de912e67e1ff) ![image](https://github.com/go-gitea/gitea/assets/2114189/b188035e-f691-428b-8b2d-ff7b2199b2f9) ![image](https://github.com/go-gitea/gitea/assets/2114189/132e9745-1c3b-4e00-9e0d-15eaea495dee) </details> ## TODO * [x] add some new tests * [x] fix some tests * [x] test some sub-commands (manually ....) --------- Co-authored-by: Jason Song <i@wolfogre.com> Co-authored-by: delvh <dev.lh@web.de> Co-authored-by: Giteabot <teabot@gitea.io>
143 lines
3.3 KiB
Go
143 lines
3.3 KiB
Go
// Copyright 2023 The Gitea Authors. All rights reserved.
|
|
// SPDX-License-Identifier: MIT
|
|
|
|
package log
|
|
|
|
import (
|
|
"context"
|
|
"fmt"
|
|
"sync"
|
|
"sync/atomic"
|
|
)
|
|
|
|
const DEFAULT = "default"
|
|
|
|
// LoggerManager manages loggers and shared event writers
|
|
type LoggerManager struct {
|
|
ctx context.Context
|
|
ctxCancel context.CancelFunc
|
|
|
|
mu sync.Mutex
|
|
writers map[string]EventWriter
|
|
loggers map[string]*LoggerImpl
|
|
defaultLogger atomic.Pointer[LoggerImpl]
|
|
|
|
pauseMu sync.RWMutex
|
|
pauseChan chan struct{}
|
|
}
|
|
|
|
// GetLogger returns a logger with the given name. If the logger doesn't exist, a new empty one will be created.
|
|
func (m *LoggerManager) GetLogger(name string) *LoggerImpl {
|
|
if name == DEFAULT {
|
|
if logger := m.defaultLogger.Load(); logger != nil {
|
|
return logger
|
|
}
|
|
}
|
|
|
|
m.mu.Lock()
|
|
defer m.mu.Unlock()
|
|
|
|
logger := m.loggers[name]
|
|
if logger == nil {
|
|
logger = NewLoggerWithWriters(m.ctx)
|
|
m.loggers[name] = logger
|
|
if name == DEFAULT {
|
|
m.defaultLogger.Store(logger)
|
|
}
|
|
}
|
|
|
|
return logger
|
|
}
|
|
|
|
// PauseAll pauses all event writers
|
|
func (m *LoggerManager) PauseAll() {
|
|
m.pauseMu.Lock()
|
|
m.pauseChan = make(chan struct{})
|
|
m.pauseMu.Unlock()
|
|
}
|
|
|
|
// ResumeAll resumes all event writers
|
|
func (m *LoggerManager) ResumeAll() {
|
|
m.pauseMu.Lock()
|
|
close(m.pauseChan)
|
|
m.pauseChan = nil
|
|
m.pauseMu.Unlock()
|
|
}
|
|
|
|
// GetPauseChan returns a channel for writer pausing
|
|
func (m *LoggerManager) GetPauseChan() chan struct{} {
|
|
m.pauseMu.RLock()
|
|
defer m.pauseMu.RUnlock()
|
|
return m.pauseChan
|
|
}
|
|
|
|
// Close closes the logger manager, all loggers and writers will be closed, the messages are flushed.
|
|
func (m *LoggerManager) Close() {
|
|
m.mu.Lock()
|
|
defer m.mu.Unlock()
|
|
|
|
for _, logger := range m.loggers {
|
|
logger.Close()
|
|
}
|
|
m.loggers = map[string]*LoggerImpl{}
|
|
|
|
for _, writer := range m.writers {
|
|
eventWriterStopWait(writer)
|
|
}
|
|
m.writers = map[string]EventWriter{}
|
|
|
|
m.ctxCancel()
|
|
}
|
|
|
|
// DumpLoggers returns a map of all loggers and their event writers, for debugging and display purposes.
|
|
func (m *LoggerManager) DumpLoggers() map[string]any {
|
|
m.mu.Lock()
|
|
defer m.mu.Unlock()
|
|
|
|
dump := map[string]any{}
|
|
for name, logger := range m.loggers {
|
|
loggerDump := map[string]any{
|
|
"IsEnabled": logger.IsEnabled(),
|
|
"EventWriters": logger.DumpWriters(),
|
|
}
|
|
dump[name] = loggerDump
|
|
}
|
|
return dump
|
|
}
|
|
|
|
// NewSharedWriter creates a new shared event writer, it can be used by multiple loggers, and a shared writer won't be closed if a logger is closed.
|
|
func (m *LoggerManager) NewSharedWriter(writerName, writerType string, mode WriterMode) (writer EventWriter, err error) {
|
|
m.mu.Lock()
|
|
defer m.mu.Unlock()
|
|
|
|
if _, ok := m.writers[writerName]; ok {
|
|
return nil, fmt.Errorf("log event writer %q has been added before", writerName)
|
|
}
|
|
|
|
if writer, err = NewEventWriter(writerName, writerType, mode); err != nil {
|
|
return nil, err
|
|
}
|
|
|
|
m.writers[writerName] = writer
|
|
eventWriterStartGo(m.ctx, writer, true)
|
|
return writer, nil
|
|
}
|
|
|
|
func (m *LoggerManager) GetSharedWriter(writerName string) EventWriter {
|
|
m.mu.Lock()
|
|
defer m.mu.Unlock()
|
|
return m.writers[writerName]
|
|
}
|
|
|
|
var loggerManager = NewManager()
|
|
|
|
func GetManager() *LoggerManager {
|
|
return loggerManager
|
|
}
|
|
|
|
func NewManager() *LoggerManager {
|
|
m := &LoggerManager{writers: map[string]EventWriter{}, loggers: map[string]*LoggerImpl{}}
|
|
m.ctx, m.ctxCancel = context.WithCancel(context.Background())
|
|
return m
|
|
}
|