mirror of
https://github.com/go-gitea/gitea.git
synced 2024-08-19 02:53:25 +02:00
* Improve SMTP authentication, Fix user creation bugs and add LDAP cert/key options This PR has two parts: Improvements for SMTP authentication: * Default to use SMTPS if port is 465, and allow setting of force SMTPS. * Always use STARTTLS if available * Provide CRAM-MD5 mechanism * Add options for HELO hostname disabling * Add options for providing certificates and keys * Handle application specific password response as a failed user login instead of as a 500. Close #16104 Fix creation of new users: * A bug was introduced when allowing users to change usernames which prevents the creation of external users. * The LoginSource refactor also broke this page. Close #16104 Signed-off-by: Andrew Thornton <art27@cantab.net>
79 lines
2.1 KiB
Go
79 lines
2.1 KiB
Go
// Copyright 2021 The Gitea Authors. All rights reserved.
|
|
// Use of this source code is governed by a MIT-style
|
|
// license that can be found in the LICENSE file.
|
|
|
|
package smtp
|
|
|
|
import (
|
|
"errors"
|
|
"net/smtp"
|
|
"net/textproto"
|
|
"strings"
|
|
|
|
"code.gitea.io/gitea/models"
|
|
"code.gitea.io/gitea/modules/util"
|
|
)
|
|
|
|
// Authenticate queries if the provided login/password is authenticates against the SMTP server
|
|
// Users will be autoregistered as required
|
|
func (source *Source) Authenticate(user *models.User, login, password string) (*models.User, error) {
|
|
// Verify allowed domains.
|
|
if len(source.AllowedDomains) > 0 {
|
|
idx := strings.Index(login, "@")
|
|
if idx == -1 {
|
|
return nil, models.ErrUserNotExist{Name: login}
|
|
} else if !util.IsStringInSlice(login[idx+1:], strings.Split(source.AllowedDomains, ","), true) {
|
|
return nil, models.ErrUserNotExist{Name: login}
|
|
}
|
|
}
|
|
|
|
var auth smtp.Auth
|
|
switch source.Auth {
|
|
case PlainAuthentication:
|
|
auth = smtp.PlainAuth("", login, password, source.Host)
|
|
case LoginAuthentication:
|
|
auth = &loginAuthenticator{login, password}
|
|
case CRAMMD5Authentication:
|
|
auth = smtp.CRAMMD5Auth(login, password)
|
|
default:
|
|
return nil, errors.New("unsupported SMTP auth type")
|
|
}
|
|
|
|
if err := Authenticate(auth, source); err != nil {
|
|
// Check standard error format first,
|
|
// then fallback to worse case.
|
|
tperr, ok := err.(*textproto.Error)
|
|
if (ok && tperr.Code == 535) ||
|
|
strings.Contains(err.Error(), "Username and Password not accepted") {
|
|
return nil, models.ErrUserNotExist{Name: login}
|
|
}
|
|
if (ok && tperr.Code == 534) ||
|
|
strings.Contains(err.Error(), "Application-specific password required") {
|
|
return nil, models.ErrUserNotExist{Name: login}
|
|
}
|
|
return nil, err
|
|
}
|
|
|
|
if user != nil {
|
|
return user, nil
|
|
}
|
|
|
|
username := login
|
|
idx := strings.Index(login, "@")
|
|
if idx > -1 {
|
|
username = login[:idx]
|
|
}
|
|
|
|
user = &models.User{
|
|
LowerName: strings.ToLower(username),
|
|
Name: strings.ToLower(username),
|
|
Email: login,
|
|
Passwd: password,
|
|
LoginType: models.LoginSMTP,
|
|
LoginSource: source.loginSource.ID,
|
|
LoginName: login,
|
|
IsActive: true,
|
|
}
|
|
return user, models.CreateUser(user)
|
|
}
|