From ea22819c7f1282d0ce382b027e66d9ead2ffc879 Mon Sep 17 00:00:00 2001
From: tobi <31960611+tsmethurst@users.noreply.github.com>
Date: Wed, 14 Jun 2023 15:08:31 +0200
Subject: [PATCH] [chore/bugfix] Demote failed inbox forwarding to warn log
 rather than error return (#1892)

---
 internal/federation/federatingactor.go | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/internal/federation/federatingactor.go b/internal/federation/federatingactor.go
index 708114484..72647040a 100644
--- a/internal/federation/federatingactor.go
+++ b/internal/federation/federatingactor.go
@@ -231,8 +231,9 @@ func (f *federatingActor) PostInboxScheme(ctx context.Context, w http.ResponseWr
 		// is updated, and/or federating callbacks are handled
 		// properly.
 		if !errors.Is(err, db.ErrAlreadyExists) {
-			err = fmt.Errorf("PostInboxScheme: error calling sideEffectActor.InboxForwarding: %w", err)
-			return false, gtserror.NewErrorInternalError(err)
+			// Failed inbox forwarding is not a show-stopper,
+			// and doesn't even necessarily denote a real error.
+			l.Warnf("error calling sideEffectActor.InboxForwarding: %q", err)
 		}
 	}