From 28293b5ccdc4f65e5721ba2fe978f1cff066d0d7 Mon Sep 17 00:00:00 2001 From: Fufu Fang Date: Sun, 5 May 2024 03:13:16 +0100 Subject: [PATCH] fixed erroneous error check --- src/cache.c | 13 +++++-------- 1 file changed, 5 insertions(+), 8 deletions(-) diff --git a/src/cache.c b/src/cache.c index 69d3e39..37e7510 100644 --- a/src/cache.c +++ b/src/cache.c @@ -163,14 +163,11 @@ static int Meta_read(Cache *cf) return EIO; } - /* - * TODO: This appears to be broken - */ - if (sizeof(long) != fread(&cf->time, sizeof(long), 1, fp) || - sizeof(off_t) != fread(&cf->content_length, sizeof(off_t), 1, fp) || - sizeof(int) != fread(&cf->blksz, sizeof(int), 1, fp) || - sizeof(long) != fread(&cf->segbc, sizeof(long), 1, fp) || - ferror(fp)) { + if ( 1 != fread(&cf->time, sizeof(long), 1, fp) || + 1 != fread(&cf->content_length, sizeof(off_t), 1, fp) || + 1 != fread(&cf->blksz, sizeof(int), 1, fp) || + 1 != fread(&cf->segbc, sizeof(long), 1, fp) || + ferror(fp) ) { lprintf(error, "error reading core metadata %s!\n", cf->path); return EIO; }