From ff5f566dd94532bc6847d593593d872f593be423 Mon Sep 17 00:00:00 2001 From: Nathaniel Wesley Filardo Date: Tue, 1 Nov 2022 01:54:35 +0000 Subject: [PATCH] Link_download_full: don't FREE(NULL) It's entirely possible that `ts.data` is `NULL` on an error path, so handing it to `FREE()`, which bails on a `NULL` argument, is not ideal. Just pass it to `free()` instead, which is required to no-op if given `NULL`. --- src/link.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/link.c b/src/link.c index 8cfe410..dc8bb47 100644 --- a/src/link.c +++ b/src/link.c @@ -860,7 +860,7 @@ TransferStruct Link_download_full(Link *link) lprintf(warning, "cannot retrieve URL: %s, HTTP %ld\n", url, http_resp); ts.curr_size = 0; - FREE(ts.data); + free(ts.data); /* not FREE(); can be NULL on error path! */ curl_easy_cleanup(curl); return ts; }