From c3865ca093070625b8e214434f4af2bb5ab9e396 Mon Sep 17 00:00:00 2001 From: "deepsource-autofix[bot]" <62050782+deepsource-autofix[bot]@users.noreply.github.com> Date: Sun, 26 Dec 2021 04:59:47 +0000 Subject: [PATCH] Iterate dictionary directly --- librespot/core.py | 8 ++++---- librespot/crypto.py | 2 +- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/librespot/core.py b/librespot/core.py index 0d27b09..3199a38 100644 --- a/librespot/core.py +++ b/librespot/core.py @@ -237,7 +237,7 @@ class DealerClient(Closeable): def add_message_listener(self, listener: MessageListener, uris: list[str]) -> None: with self.__message_listeners_lock: - if listener in self.__message_listeners.keys(): + if listener in self.__message_listeners: raise TypeError( "A listener for {} has already been added.".format(uris)) self.__message_listeners[listener] = uris @@ -245,7 +245,7 @@ class DealerClient(Closeable): def add_request_listener(self, listener: RequestListener, uri: str): with self.__request_listeners_lock: - if uri in self.__request_listeners.keys(): + if uri in self.__request_listeners: raise TypeError( "A listener for '{}' has already been added.".format(uri)) self.__request_listeners[uri] = listener @@ -289,7 +289,7 @@ class DealerClient(Closeable): decoded_payloads = b"" interesting = False with self.__message_listeners_lock: - for listener in self.__message_listeners.keys(): + for listener in self.__message_listeners: dispatched = False keys = self.__message_listeners.get(listener) for key in keys: @@ -320,7 +320,7 @@ class DealerClient(Closeable): .format(mid, key, pid, sender, command)) interesting = False with self.__request_listeners_lock: - for mid_prefix in self.__request_listeners.keys(): + for mid_prefix in self.__request_listeners: if mid.startswith(mid_prefix): listener = self.__request_listeners.get(mid_prefix) interesting = True diff --git a/librespot/crypto.py b/librespot/crypto.py index bf342c5..a0a2076 100644 --- a/librespot/crypto.py +++ b/librespot/crypto.py @@ -169,7 +169,7 @@ class Packet: def parse(val: typing.Union[bytes, None]) -> typing.Union[bytes, None]: for cmd in [ Packet.Type.__dict__[attr] - for attr in Packet.Type.__dict__.keys() + for attr in Packet.Type.__dict__ if re.search("__.+?__", attr) is None and type(Packet.Type.__dict__[attr]) is bytes ]: