From 012138179c4210313f63ec8a4982d366ccee299c Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Fr=C3=A9d=C3=A9ric=20Guillot?= <fred@miniflux.net>
Date: Sat, 15 Dec 2018 13:04:38 -0800
Subject: [PATCH] Add function storage.UpdateFeedError()

---
 reader/feed/handler.go | 19 +++++++++++++------
 storage/feed.go        | 27 +++++++++++++++++++++++++++
 2 files changed, 40 insertions(+), 6 deletions(-)

diff --git a/reader/feed/handler.go b/reader/feed/handler.go
index 587f76da..3da0d46d 100644
--- a/reader/feed/handler.go
+++ b/reader/feed/handler.go
@@ -99,7 +99,7 @@ func (h *Handler) RefreshFeed(userID, feedID int64) error {
 	response, requestErr := browser.Exec(request)
 	if requestErr != nil {
 		originalFeed.WithError(requestErr.Localize(printer))
-		h.store.UpdateFeed(originalFeed)
+		h.store.UpdateFeedError(originalFeed)
 		return requestErr
 	}
 
@@ -109,7 +109,7 @@ func (h *Handler) RefreshFeed(userID, feedID int64) error {
 		updatedFeed, parseErr := parser.ParseFeed(response.String())
 		if parseErr != nil {
 			originalFeed.WithError(parseErr.Localize(printer))
-			h.store.UpdateFeed(originalFeed)
+			h.store.UpdateFeedError(originalFeed)
 			return parseErr
 		}
 
@@ -119,7 +119,7 @@ func (h *Handler) RefreshFeed(userID, feedID int64) error {
 		// We don't update existing entries when the crawler is enabled (we crawl only inexisting entries).
 		if storeErr := h.store.UpdateEntries(originalFeed.UserID, originalFeed.ID, originalFeed.Entries, !originalFeed.Crawler); storeErr != nil {
 			originalFeed.WithError(storeErr.Error())
-			h.store.UpdateFeed(originalFeed)
+			h.store.UpdateFeedError(originalFeed)
 			return storeErr
 		}
 
@@ -132,7 +132,14 @@ func (h *Handler) RefreshFeed(userID, feedID int64) error {
 	}
 
 	originalFeed.ResetErrorCounter()
-	return h.store.UpdateFeed(originalFeed)
+
+	if storeErr := h.store.UpdateFeed(originalFeed); storeErr != nil {
+		originalFeed.WithError(storeErr.Error())
+		h.store.UpdateFeedError(originalFeed)
+		return storeErr
+	}
+
+	return nil
 }
 
 // NewFeedHandler returns a feed handler.
@@ -144,12 +151,12 @@ func checkFeedIcon(store *storage.Storage, feedID int64, websiteURL string) {
 	if !store.HasIcon(feedID) {
 		icon, err := icon.FindIcon(websiteURL)
 		if err != nil {
-			logger.Error("CheckFeedIcon: %v (feedID=%d websiteURL=%s)", err, feedID, websiteURL)
+			logger.Debug("CheckFeedIcon: %v (feedID=%d websiteURL=%s)", err, feedID, websiteURL)
 		} else if icon == nil {
 			logger.Debug("CheckFeedIcon: No icon found (feedID=%d websiteURL=%s)", feedID, websiteURL)
 		} else {
 			if err := store.CreateFeedIcon(feedID, icon); err != nil {
-				logger.Error("CheckFeedIcon: %v (feedID=%d websiteURL=%s)", err, feedID, websiteURL)
+				logger.Debug("CheckFeedIcon: %v (feedID=%d websiteURL=%s)", err, feedID, websiteURL)
 			}
 		}
 	}
diff --git a/storage/feed.go b/storage/feed.go
index 5250b9a7..844f58e0 100644
--- a/storage/feed.go
+++ b/storage/feed.go
@@ -268,6 +268,33 @@ func (s *Storage) UpdateFeed(feed *model.Feed) (err error) {
 	return nil
 }
 
+// UpdateFeedError updates feed errors.
+func (s *Storage) UpdateFeedError(feed *model.Feed) (err error) {
+	defer timer.ExecutionTime(time.Now(), fmt.Sprintf("[Storage:UpdateFeedError] feedID=%d", feed.ID))
+
+	query := `
+		UPDATE feeds
+		SET
+			parsing_error_msg=$1,
+			parsing_error_count=$2,
+			checked_at=$3
+		WHERE id=$4 AND user_id=$5`
+
+	_, err = s.db.Exec(query,
+		feed.ParsingErrorMsg,
+		feed.ParsingErrorCount,
+		feed.CheckedAt,
+		feed.ID,
+		feed.UserID,
+	)
+
+	if err != nil {
+		return fmt.Errorf("unable to update feed error #%d (%s): %v", feed.ID, feed.FeedURL, err)
+	}
+
+	return nil
+}
+
 // RemoveFeed removes a feed.
 func (s *Storage) RemoveFeed(userID, feedID int64) error {
 	defer timer.ExecutionTime(time.Now(), fmt.Sprintf("[Storage:RemoveFeed] userID=%d, feedID=%d", userID, feedID))