Add CONTENT_SECURITY_POLICY

This commit is contained in:
John 2023-12-15 21:21:58 +02:00 committed by John
parent 2c4c845cd2
commit 19fb9675a4
6 changed files with 46 additions and 3 deletions

View File

@ -2109,3 +2109,21 @@ func TestParseConfigDumpOutput(t *testing.T) {
t.Fatal(err)
}
}
func TestContentSecurityPolicy(t *testing.T) {
os.Clearenv()
os.Setenv("CONTENT_SECURITY_POLICY", "default-src 'self' fonts.googleapis.com fonts.gstatic.com; img-src * data:; media-src *; frame-src *; style-src 'self' fonts.googleapis.com fonts.gstatic.com 'nonce-%s'")
parser := NewParser()
opts, err := parser.ParseEnvironmentVariables()
if err != nil {
t.Fatalf(`Parsing failure: %v`, err)
}
expected := "default-src 'self' fonts.googleapis.com fonts.gstatic.com; img-src * data:; media-src *; frame-src *; style-src 'self' fonts.googleapis.com fonts.gstatic.com 'nonce-%s'"
result := opts.ContentSecurityPolicy()
if result != expected {
t.Fatalf(`Unexpected CONTENT_SECURITY_POLICY value, got %v instead of %v`, result, expected)
}
}

View File

@ -85,6 +85,7 @@ const (
defaultWatchdog = true
defaultInvidiousInstance = "yewtu.be"
defaultWebAuthn = false
defaultContentSecurityPolicy = "default-src 'self'; img-src * data:; media-src *; frame-src *; style-src 'self' 'nonce-%s'; require-trusted-types-for 'script'; trusted-types ttpolicy;"
)
var defaultHTTPClientUserAgent = "Mozilla/5.0 (compatible; Miniflux/" + version.Version + "; +https://miniflux.app)"
@ -169,6 +170,7 @@ type Options struct {
invidiousInstance string
mediaProxyPrivateKey []byte
webAuthn bool
contentSecurityPolicy string
}
// NewOptions returns Options with default values.
@ -244,6 +246,7 @@ func NewOptions() *Options {
invidiousInstance: defaultInvidiousInstance,
mediaProxyPrivateKey: crypto.GenerateRandomBytes(16),
webAuthn: defaultWebAuthn,
contentSecurityPolicy: defaultContentSecurityPolicy,
}
}
@ -620,6 +623,11 @@ func (o *Options) FilterEntryMaxAgeDays() int {
return o.filterEntryMaxAgeDays
}
// ContentSecurityPolicy returns value for Content-Security-Policy meta tag.
func (o *Options) ContentSecurityPolicy() string {
return o.contentSecurityPolicy
}
// SortedOptions returns options as a list of key value pairs, sorted by keys.
func (o *Options) SortedOptions(redactSecret bool) []*Option {
var keyValues = map[string]interface{}{
@ -697,6 +705,7 @@ func (o *Options) SortedOptions(redactSecret bool) []*Option {
"WORKER_POOL_SIZE": o.workerPoolSize,
"YOUTUBE_EMBED_URL_OVERRIDE": o.youTubeEmbedUrlOverride,
"WEBAUTHN": o.webAuthn,
"CONTENT_SECURITY_POLICY": o.contentSecurityPolicy,
}
keys := make([]string, 0, len(keyValues))

View File

@ -271,6 +271,8 @@ func (p *Parser) parseLines(lines []string) (err error) {
p.opts.invidiousInstance = parseString(value, defaultInvidiousInstance)
case "WEBAUTHN":
p.opts.webAuthn = parseBool(value, defaultWebAuthn)
case "CONTENT_SECURITY_POLICY":
p.opts.contentSecurityPolicy = parseString(value, defaultContentSecurityPolicy)
}
}

View File

@ -36,8 +36,13 @@
{{ if and .user .user.Stylesheet }}
{{ $stylesheetNonce := nonce }}
<meta http-equiv="Content-Security-Policy" content="default-src 'self'; img-src * data:; media-src *; frame-src *; style-src 'self' 'nonce-{{ $stylesheetNonce }}'; require-trusted-types-for 'script'; trusted-types ttpolicy;">
<style nonce="{{ $stylesheetNonce }}">{{ .user.Stylesheet | safeCSS }}</style>
{{ $containsNonce := contains .contentSecurityPolicy "nonce-%s" }}
{{ if $containsNonce }}
{{ noescape ( printf "<meta http-equiv=\"Content-Security-Policy\" content=\"%s\">" (printf .contentSecurityPolicy $stylesheetNonce ) ) }}
{{ else }}
{{ noescape ( printf "<meta http-equiv=\"Content-Security-Policy\" content=\"%s\">" .contentSecurityPolicy ) }}
{{ end }}
<style {{ if $containsNonce }}nonce="{{ $stylesheetNonce }}"{{end}}>{{ .user.Stylesheet | safeCSS }}</style>
{{ else }}
<meta http-equiv="Content-Security-Policy" content="default-src 'self'; img-src * data:; media-src *; frame-src *; require-trusted-types-for 'script'; trusted-types ttpolicy;">
{{ end }}
@ -58,7 +63,6 @@
data-webauthn-delete-all-url="{{ route "webauthnDeleteAll" }}"
{{ end }}
{{ if .user }}{{ if not .user.KeyboardShortcuts }}data-disable-keyboard-shortcuts="true"{{ end }}{{ end }}>
{{ if .user }}
<a class="skip-to-content-link" href="#main">{{ t "skip_to_content" }}</a>
<header class="header">

View File

@ -46,5 +46,6 @@ func New(tpl *template.Engine, r *http.Request, sess *session.Session) *View {
"sw_js_checksum": static.JavascriptBundleChecksums["service-worker"],
"webauthn_js_checksum": static.JavascriptBundleChecksums["webauthn"],
"webAuthnEnabled": config.Opts.WebAuthn(),
"contentSecurityPolicy": config.Opts.ContentSecurityPolicy(),
}}
}

View File

@ -534,6 +534,15 @@ Default is 16 workers\&.
YouTube URL which will be used for embeds\&.
.br
Default is https://www.youtube-nocookie.com/embed/\&.
.TP
.B CONTENT_SECURITY_POLICY
Set custom value for Content-Security-Policy meta tag. Used when custom CSS is applied.
.br
It may contain "nonce-%s", where nonce will be placed\&.
.br
Default is "default-src 'self'; img-src * data:; media-src *; frame-src *; style-src 'self' 'nonce-%s'; require-trusted-types-for 'script'; trusted-types ttpolicy;"\&.
.TP
.SH AUTHORS
.P
Miniflux is written and maintained by Fr\['e]d\['e]ric Guillot\&.