From 1e16e19d117a2816bb1ef0597dfe7b3ddd0f67c9 Mon Sep 17 00:00:00 2001 From: George Angelopoulos Date: Thu, 3 Nov 2022 17:07:00 +0200 Subject: [PATCH] use dirs file for debian package Instead of running mkdir from debian/rules, the native way to create the necessary directories is with the dirs file which is read by the dh_installdirs helper script. See: * https://www.debian.org/doc/manuals/maint-guide/dother.en.html#dirs * dh_installdirs(1) manual page I am not aware of any specific problems that could arise from doing it manually instead of using dh_installdirs. But sticking to the native approach might be a good idea. --- packaging/debian/build.sh | 1 + packaging/debian/miniflux.dirs | 2 ++ packaging/debian/rules | 2 -- 3 files changed, 3 insertions(+), 2 deletions(-) create mode 100644 packaging/debian/miniflux.dirs diff --git a/packaging/debian/build.sh b/packaging/debian/build.sh index 19edd82f..2867d469 100755 --- a/packaging/debian/build.sh +++ b/packaging/debian/build.sh @@ -22,6 +22,7 @@ cd /src && \ cp /src/packaging/debian/miniflux.manpages /build/debian/miniflux.manpages && \ cp /src/packaging/debian/miniflux.postinst /build/debian/miniflux.postinst && \ cp /src/packaging/debian/rules /build/debian/rules && \ + cp /src/packaging/debian/miniflux.dirs /build/debian/miniflux.dirs && \ echo "miniflux ($PKG_VERSION) experimental; urgency=low" > /build/debian/changelog && \ echo " * Miniflux version $PKG_VERSION" >> /build/debian/changelog && \ echo " -- Frédéric Guillot $PKG_DATE" >> /build/debian/changelog && \ diff --git a/packaging/debian/miniflux.dirs b/packaging/debian/miniflux.dirs new file mode 100644 index 00000000..18488c76 --- /dev/null +++ b/packaging/debian/miniflux.dirs @@ -0,0 +1,2 @@ +etc +usr/bin diff --git a/packaging/debian/rules b/packaging/debian/rules index f0845039..5e14e824 100755 --- a/packaging/debian/rules +++ b/packaging/debian/rules @@ -9,8 +9,6 @@ override_dh_auto_clean: override_dh_auto_test: override_dh_auto_build: override_dh_auto_install: - mkdir -p $(DESTDIR)/etc - mkdir -p $(DESTDIR)/usr/bin cp miniflux.conf $(DESTDIR)/etc/miniflux.conf cp miniflux $(DESTDIR)/usr/bin/miniflux