Use crypto.GenerateRandomBytes instead of doing it by hand

This makes the code a bit shorter, and properly handle
cryptographic error conditions.
This commit is contained in:
jvoisin 2024-03-11 23:24:46 +01:00 committed by Frédéric Guillot
parent 9c8a7dfffe
commit 5bcb37901c
1 changed files with 2 additions and 5 deletions

View File

@ -4,12 +4,12 @@
package config // import "miniflux.app/v2/internal/config" package config // import "miniflux.app/v2/internal/config"
import ( import (
"crypto/rand"
"fmt" "fmt"
"sort" "sort"
"strings" "strings"
"time" "time"
"miniflux.app/v2/internal/crypto"
"miniflux.app/v2/internal/version" "miniflux.app/v2/internal/version"
) )
@ -171,9 +171,6 @@ type Options struct {
// NewOptions returns Options with default values. // NewOptions returns Options with default values.
func NewOptions() *Options { func NewOptions() *Options {
randomKey := make([]byte, 16)
rand.Read(randomKey)
return &Options{ return &Options{
HTTPS: defaultHTTPS, HTTPS: defaultHTTPS,
logFile: defaultLogFile, logFile: defaultLogFile,
@ -242,7 +239,7 @@ func NewOptions() *Options {
metricsPassword: defaultMetricsPassword, metricsPassword: defaultMetricsPassword,
watchdog: defaultWatchdog, watchdog: defaultWatchdog,
invidiousInstance: defaultInvidiousInstance, invidiousInstance: defaultInvidiousInstance,
proxyPrivateKey: randomKey, proxyPrivateKey: crypto.GenerateRandomBytes(16),
webAuthn: defaultWebAuthn, webAuthn: defaultWebAuthn,
} }
} }