rdelaage
/
postgresql
mirror of https://git.postgresql.org/git/postgresql.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity
postgresql/src/test/isolation/expected/reindex-schema.out

Ignoring revisions in .git-blame-ignore-revs. Click here to bypass and see the normal blame view.

18 lines
685 B
Plaintext
Raw Normal View History

Improve handling of dropped relations for REINDEX DATABASE/SCHEMA/SYSTEM When multiple relations are reindexed, a scan of pg_class is done first to build the list of relations to work on. However the REINDEX logic has never checked if a relation listed still exists when beginning the work on it, causing for example sudden cache lookup failures. This commit adds safeguards against dropped relations for REINDEX, similarly to VACUUM or CLUSTER where we try to open the relation, ignoring it if it is missing. A new option is added to the REINDEX routines to control if a missed relation is OK to ignore or not. An isolation test, based on REINDEX SCHEMA, is added for the concurrent and non-concurrent cases. Author: Michael Paquier Reviewed-by: Anastasia Lubennikova Discussion: https://postgr.es/m/20200813043805.GE11663@paquier.xyz
2020-09-02 02:08:12 +02:00
Parsed test spec with 3 sessions
starting permutation: begin1 lock1 reindex2 drop3 end1
step begin1: BEGIN;
step lock1: LOCK reindex_schema.tab_locked IN SHARE UPDATE EXCLUSIVE MODE;
step reindex2: REINDEX SCHEMA reindex_schema; <waiting ...>
step drop3: DROP TABLE reindex_schema.tab_dropped;
step end1: COMMIT;
step reindex2: <... completed>
starting permutation: begin1 lock1 reindex_conc2 drop3 end1
step begin1: BEGIN;
step lock1: LOCK reindex_schema.tab_locked IN SHARE UPDATE EXCLUSIVE MODE;
step reindex_conc2: REINDEX SCHEMA CONCURRENTLY reindex_schema; <waiting ...>
step drop3: DROP TABLE reindex_schema.tab_dropped;
step end1: COMMIT;
step reindex_conc2: <... completed>