Add testing to detect errors of omission in "pin" dependency creation.
It's essential that initdb.c's setup_depend() scan each system catalog
that could contain objects that need to have "p" (pin) entries in pg_depend
or pg_shdepend. Forgetting to add that, either when a catalog is first
invented or when it first acquires DATA() entries, is an obvious bug
hazard. We can detect such omissions at reasonable cost by probing every
OID-containing system catalog to see whether the lowest-numbered OID in it
is pinned. If so, the catalog must have been properly accounted for in
setup_depend(). If the lowest OID is above FirstNormalObjectId then the
catalog must have been empty at the end of initdb, so it doesn't matter.
There are a small number of catalogs whose first entry is made later in
initdb than setup_depend(), resulting in nonempty expected output of the
test, but these can be manually inspected to see that they are OK. Any
future mistake of this ilk will manifest as a new entry in the test's
output.
Since pg_conversion is already in the test's output, add it to the set of
catalogs scanned by setup_depend(). That has no effect today (hence, no
catversion bump here) but it will protect us if we ever do add pin-worthy
conversions.
This test is very much like the catalog sanity checks embodied in
opr_sanity.sql and type_sanity.sql, but testing pg_depend doesn't seem to
fit naturally into either of those scripts' charters. Hence, invent a new
test script misc_sanity.sql, which can be a home for this as well as tests
on any other catalogs we might want in future.
Discussion: https://postgr.es/m/8068.1498155068@sss.pgh.pa.us
2017-06-23 17:03:04 +02:00
|
|
|
--
|
|
|
|
-- MISC_SANITY
|
|
|
|
-- Sanity checks for common errors in making system tables that don't fit
|
|
|
|
-- comfortably into either opr_sanity or type_sanity.
|
|
|
|
--
|
|
|
|
-- Every test failure in this file should be closely inspected.
|
|
|
|
-- The description of the failing test should be read carefully before
|
|
|
|
-- adjusting the expected output. In most cases, the queries should
|
|
|
|
-- not find *any* matching entries.
|
|
|
|
--
|
|
|
|
-- NB: run this test early, because some later tests create bogus entries.
|
|
|
|
-- **************** pg_depend ****************
|
|
|
|
-- Look for illegal values in pg_depend fields.
|
|
|
|
-- classid/objid can be zero, but only in 'p' entries
|
|
|
|
SELECT *
|
|
|
|
FROM pg_depend as d1
|
|
|
|
WHERE refclassid = 0 OR refobjid = 0 OR
|
|
|
|
deptype NOT IN ('a', 'e', 'i', 'n', 'p') OR
|
|
|
|
(deptype != 'p' AND (classid = 0 OR objid = 0)) OR
|
|
|
|
(deptype = 'p' AND (classid != 0 OR objid != 0 OR objsubid != 0));
|
|
|
|
classid | objid | objsubid | refclassid | refobjid | refobjsubid | deptype
|
|
|
|
---------+-------+----------+------------+----------+-------------+---------
|
|
|
|
(0 rows)
|
|
|
|
|
|
|
|
-- **************** pg_shdepend ****************
|
|
|
|
-- Look for illegal values in pg_shdepend fields.
|
|
|
|
-- classid/objid can be zero, but only in 'p' entries
|
|
|
|
SELECT *
|
|
|
|
FROM pg_shdepend as d1
|
|
|
|
WHERE refclassid = 0 OR refobjid = 0 OR
|
|
|
|
deptype NOT IN ('a', 'o', 'p', 'r') OR
|
2017-08-28 16:14:20 +02:00
|
|
|
(deptype != 'p' AND (classid = 0 OR objid = 0)) OR
|
Add testing to detect errors of omission in "pin" dependency creation.
It's essential that initdb.c's setup_depend() scan each system catalog
that could contain objects that need to have "p" (pin) entries in pg_depend
or pg_shdepend. Forgetting to add that, either when a catalog is first
invented or when it first acquires DATA() entries, is an obvious bug
hazard. We can detect such omissions at reasonable cost by probing every
OID-containing system catalog to see whether the lowest-numbered OID in it
is pinned. If so, the catalog must have been properly accounted for in
setup_depend(). If the lowest OID is above FirstNormalObjectId then the
catalog must have been empty at the end of initdb, so it doesn't matter.
There are a small number of catalogs whose first entry is made later in
initdb than setup_depend(), resulting in nonempty expected output of the
test, but these can be manually inspected to see that they are OK. Any
future mistake of this ilk will manifest as a new entry in the test's
output.
Since pg_conversion is already in the test's output, add it to the set of
catalogs scanned by setup_depend(). That has no effect today (hence, no
catversion bump here) but it will protect us if we ever do add pin-worthy
conversions.
This test is very much like the catalog sanity checks embodied in
opr_sanity.sql and type_sanity.sql, but testing pg_depend doesn't seem to
fit naturally into either of those scripts' charters. Hence, invent a new
test script misc_sanity.sql, which can be a home for this as well as tests
on any other catalogs we might want in future.
Discussion: https://postgr.es/m/8068.1498155068@sss.pgh.pa.us
2017-06-23 17:03:04 +02:00
|
|
|
(deptype = 'p' AND (dbid != 0 OR classid != 0 OR objid != 0 OR objsubid != 0));
|
|
|
|
dbid | classid | objid | objsubid | refclassid | refobjid | deptype
|
|
|
|
------+---------+-------+----------+------------+----------+---------
|
|
|
|
(0 rows)
|
|
|
|
|
|
|
|
-- Check each OID-containing system catalog to see if its lowest-numbered OID
|
|
|
|
-- is pinned. If not, and if that OID was generated during initdb, then
|
|
|
|
-- perhaps initdb forgot to scan that catalog for pinnable entries.
|
|
|
|
-- Generally, it's okay for a catalog to be listed in the output of this
|
|
|
|
-- test if that catalog is scanned by initdb.c's setup_depend() function;
|
|
|
|
-- whatever OID the test is complaining about must have been added later
|
|
|
|
-- in initdb, where it intentionally isn't pinned. Legitimate exceptions
|
|
|
|
-- to that rule are listed in the comments in setup_depend().
|
|
|
|
do $$
|
|
|
|
declare relnm text;
|
|
|
|
reloid oid;
|
|
|
|
shared bool;
|
|
|
|
lowoid oid;
|
|
|
|
pinned bool;
|
|
|
|
begin
|
|
|
|
for relnm, reloid, shared in
|
|
|
|
select relname, oid, relisshared from pg_class
|
Remove WITH OIDS support, change oid catalog column visibility.
Previously tables declared WITH OIDS, including a significant fraction
of the catalog tables, stored the oid column not as a normal column,
but as part of the tuple header.
This special column was not shown by default, which was somewhat odd,
as it's often (consider e.g. pg_class.oid) one of the more important
parts of a row. Neither pg_dump nor COPY included the contents of the
oid column by default.
The fact that the oid column was not an ordinary column necessitated a
significant amount of special case code to support oid columns. That
already was painful for the existing, but upcoming work aiming to make
table storage pluggable, would have required expanding and duplicating
that "specialness" significantly.
WITH OIDS has been deprecated since 2005 (commit ff02d0a05280e0).
Remove it.
Removing includes:
- CREATE TABLE and ALTER TABLE syntax for declaring the table to be
WITH OIDS has been removed (WITH (oids[ = true]) will error out)
- pg_dump does not support dumping tables declared WITH OIDS and will
issue a warning when dumping one (and ignore the oid column).
- restoring an pg_dump archive with pg_restore will warn when
restoring a table with oid contents (and ignore the oid column)
- COPY will refuse to load binary dump that includes oids.
- pg_upgrade will error out when encountering tables declared WITH
OIDS, they have to be altered to remove the oid column first.
- Functionality to access the oid of the last inserted row (like
plpgsql's RESULT_OID, spi's SPI_lastoid, ...) has been removed.
The syntax for declaring a table WITHOUT OIDS (or WITH (oids = false)
for CREATE TABLE) is still supported. While that requires a bit of
support code, it seems unnecessary to break applications / dumps that
do not use oids, and are explicit about not using them.
The biggest user of WITH OID columns was postgres' catalog. This
commit changes all 'magic' oid columns to be columns that are normally
declared and stored. To reduce unnecessary query breakage all the
newly added columns are still named 'oid', even if a table's column
naming scheme would indicate 'reloid' or such. This obviously
requires adapting a lot code, mostly replacing oid access via
HeapTupleGetOid() with access to the underlying Form_pg_*->oid column.
The bootstrap process now assigns oids for all oid columns in
genbki.pl that do not have an explicit value (starting at the largest
oid previously used), only oids assigned later by oids will be above
FirstBootstrapObjectId. As the oid column now is a normal column the
special bootstrap syntax for oids has been removed.
Oids are not automatically assigned during insertion anymore, all
backend code explicitly assigns oids with GetNewOidWithIndex(). For
the rare case that insertions into the catalog via SQL are called for
the new pg_nextoid() function can be used (which only works on catalog
tables).
The fact that oid columns on system tables are now normal columns
means that they will be included in the set of columns expanded
by * (i.e. SELECT * FROM pg_class will now include the table's oid,
previously it did not). It'd not technically be hard to hide oid
column by default, but that'd mean confusing behavior would either
have to be carried forward forever, or it'd cause breakage down the
line.
While it's not unlikely that further adjustments are needed, the
scope/invasiveness of the patch makes it worthwhile to get merge this
now. It's painful to maintain externally, too complicated to commit
after the code code freeze, and a dependency of a number of other
patches.
Catversion bump, for obvious reasons.
Author: Andres Freund, with contributions by John Naylor
Discussion: https://postgr.es/m/20180930034810.ywp2c7awz7opzcfr@alap3.anarazel.de
2018-11-21 00:36:57 +01:00
|
|
|
where EXISTS(
|
|
|
|
SELECT * FROM pg_attribute
|
|
|
|
WHERE attrelid = pg_class.oid AND attname = 'oid')
|
|
|
|
and relkind = 'r' and oid < 16384 order by 1
|
Add testing to detect errors of omission in "pin" dependency creation.
It's essential that initdb.c's setup_depend() scan each system catalog
that could contain objects that need to have "p" (pin) entries in pg_depend
or pg_shdepend. Forgetting to add that, either when a catalog is first
invented or when it first acquires DATA() entries, is an obvious bug
hazard. We can detect such omissions at reasonable cost by probing every
OID-containing system catalog to see whether the lowest-numbered OID in it
is pinned. If so, the catalog must have been properly accounted for in
setup_depend(). If the lowest OID is above FirstNormalObjectId then the
catalog must have been empty at the end of initdb, so it doesn't matter.
There are a small number of catalogs whose first entry is made later in
initdb than setup_depend(), resulting in nonempty expected output of the
test, but these can be manually inspected to see that they are OK. Any
future mistake of this ilk will manifest as a new entry in the test's
output.
Since pg_conversion is already in the test's output, add it to the set of
catalogs scanned by setup_depend(). That has no effect today (hence, no
catversion bump here) but it will protect us if we ever do add pin-worthy
conversions.
This test is very much like the catalog sanity checks embodied in
opr_sanity.sql and type_sanity.sql, but testing pg_depend doesn't seem to
fit naturally into either of those scripts' charters. Hence, invent a new
test script misc_sanity.sql, which can be a home for this as well as tests
on any other catalogs we might want in future.
Discussion: https://postgr.es/m/8068.1498155068@sss.pgh.pa.us
2017-06-23 17:03:04 +02:00
|
|
|
loop
|
|
|
|
execute 'select min(oid) from ' || relnm into lowoid;
|
|
|
|
continue when lowoid is null or lowoid >= 16384;
|
|
|
|
if shared then
|
|
|
|
pinned := exists(select 1 from pg_shdepend
|
|
|
|
where refclassid = reloid and refobjid = lowoid
|
|
|
|
and deptype = 'p');
|
|
|
|
else
|
|
|
|
pinned := exists(select 1 from pg_depend
|
|
|
|
where refclassid = reloid and refobjid = lowoid
|
|
|
|
and deptype = 'p');
|
|
|
|
end if;
|
|
|
|
if not pinned then
|
|
|
|
raise notice '% contains unpinned initdb-created object(s)', relnm;
|
|
|
|
end if;
|
|
|
|
end loop;
|
|
|
|
end$$;
|
|
|
|
NOTICE: pg_constraint contains unpinned initdb-created object(s)
|
|
|
|
NOTICE: pg_database contains unpinned initdb-created object(s)
|
|
|
|
NOTICE: pg_extension contains unpinned initdb-created object(s)
|
|
|
|
NOTICE: pg_rewrite contains unpinned initdb-created object(s)
|
|
|
|
NOTICE: pg_tablespace contains unpinned initdb-created object(s)
|
2018-07-12 12:31:49 +02:00
|
|
|
-- **************** pg_class ****************
|
Add toast tables to most system catalogs
It has been project policy to create toast tables only for those catalogs
that might reasonably need one. Since this judgment call can change over
time, just create one for every catalog, as this can be useful when
creating rather-long entries in catalogs, with recent examples being in
the shape of policy expressions or customly-formatted SCRAM verifiers.
To prevent circular dependencies and to avoid adding complexity to VACUUM
FULL logic, exclude pg_class, pg_attribute, and pg_index. Also, to
prevent pg_upgrade from seeing a non-empty new cluster, exclude
pg_largeobject and pg_largeobject_metadata from the set as large object
data is handled as user data. Those relations have no reason to use a
toast table anyway.
Author: Joe Conway, John Naylor
Reviewed-by: Michael Paquier, Tom Lane
Discussion: https://postgr.es/m/84ddff04-f122-784b-b6c5-3536804495f8@joeconway.com
2018-07-20 00:43:41 +02:00
|
|
|
-- Look for system tables with varlena columns but no toast table. All
|
|
|
|
-- system tables with toastable columns should have toast tables, with
|
|
|
|
-- the following exceptions:
|
|
|
|
-- 1. pg_class, pg_attribute, and pg_index, due to fear of recursive
|
|
|
|
-- dependencies as toast tables depend on them.
|
|
|
|
-- 2. pg_largeobject and pg_largeobject_metadata. Large object catalogs
|
|
|
|
-- and toast tables are mutually exclusive and large object data is handled
|
|
|
|
-- as user data by pg_upgrade, which would cause failures.
|
2018-07-12 12:31:49 +02:00
|
|
|
SELECT relname, attname, atttypid::regtype
|
|
|
|
FROM pg_class c JOIN pg_attribute a ON c.oid = attrelid
|
|
|
|
WHERE c.oid < 16384 AND
|
|
|
|
reltoastrelid = 0 AND
|
|
|
|
relkind = 'r' AND
|
|
|
|
attstorage != 'p'
|
|
|
|
ORDER BY 1, 2;
|
Add toast tables to most system catalogs
It has been project policy to create toast tables only for those catalogs
that might reasonably need one. Since this judgment call can change over
time, just create one for every catalog, as this can be useful when
creating rather-long entries in catalogs, with recent examples being in
the shape of policy expressions or customly-formatted SCRAM verifiers.
To prevent circular dependencies and to avoid adding complexity to VACUUM
FULL logic, exclude pg_class, pg_attribute, and pg_index. Also, to
prevent pg_upgrade from seeing a non-empty new cluster, exclude
pg_largeobject and pg_largeobject_metadata from the set as large object
data is handled as user data. Those relations have no reason to use a
toast table anyway.
Author: Joe Conway, John Naylor
Reviewed-by: Michael Paquier, Tom Lane
Discussion: https://postgr.es/m/84ddff04-f122-784b-b6c5-3536804495f8@joeconway.com
2018-07-20 00:43:41 +02:00
|
|
|
relname | attname | atttypid
|
|
|
|
-------------------------+---------------+--------------
|
|
|
|
pg_attribute | attacl | aclitem[]
|
|
|
|
pg_attribute | attfdwoptions | text[]
|
|
|
|
pg_attribute | attmissingval | anyarray
|
|
|
|
pg_attribute | attoptions | text[]
|
|
|
|
pg_class | relacl | aclitem[]
|
|
|
|
pg_class | reloptions | text[]
|
|
|
|
pg_class | relpartbound | pg_node_tree
|
|
|
|
pg_index | indexprs | pg_node_tree
|
|
|
|
pg_index | indpred | pg_node_tree
|
|
|
|
pg_largeobject | data | bytea
|
|
|
|
pg_largeobject_metadata | lomacl | aclitem[]
|
|
|
|
(11 rows)
|
2018-07-12 12:31:49 +02:00
|
|
|
|