2002-04-15 07:22:04 +02:00
|
|
|
/*-------------------------------------------------------------------------
|
|
|
|
*
|
|
|
|
* aggregatecmds.c
|
|
|
|
*
|
|
|
|
* Routines for aggregate-manipulation commands
|
|
|
|
*
|
2013-01-01 23:15:01 +01:00
|
|
|
* Portions Copyright (c) 1996-2013, PostgreSQL Global Development Group
|
2002-04-15 07:22:04 +02:00
|
|
|
* Portions Copyright (c) 1994, Regents of the University of California
|
|
|
|
*
|
|
|
|
*
|
|
|
|
* IDENTIFICATION
|
2010-09-20 22:08:53 +02:00
|
|
|
* src/backend/commands/aggregatecmds.c
|
2002-04-15 07:22:04 +02:00
|
|
|
*
|
|
|
|
* DESCRIPTION
|
|
|
|
* The "DefineFoo" routines take the parse tree and pick out the
|
|
|
|
* appropriate arguments/flags, passing the results to the
|
|
|
|
* corresponding "FooDefine" routines (in src/catalog) that do
|
|
|
|
* the actual catalog-munging. These routines also verify permission
|
|
|
|
* of the user to execute the command.
|
|
|
|
*
|
|
|
|
*-------------------------------------------------------------------------
|
|
|
|
*/
|
|
|
|
#include "postgres.h"
|
|
|
|
|
|
|
|
#include "access/heapam.h"
|
2012-08-30 22:15:44 +02:00
|
|
|
#include "access/htup_details.h"
|
2002-07-12 20:43:19 +02:00
|
|
|
#include "catalog/dependency.h"
|
2003-06-27 16:45:32 +02:00
|
|
|
#include "catalog/indexing.h"
|
2002-04-15 07:22:04 +02:00
|
|
|
#include "catalog/pg_aggregate.h"
|
2002-04-27 05:45:03 +02:00
|
|
|
#include "catalog/pg_proc.h"
|
2002-08-22 02:01:51 +02:00
|
|
|
#include "catalog/pg_type.h"
|
2013-03-07 02:52:06 +01:00
|
|
|
#include "commands/alter.h"
|
2002-04-15 07:22:04 +02:00
|
|
|
#include "commands/defrem.h"
|
|
|
|
#include "miscadmin.h"
|
|
|
|
#include "parser/parse_func.h"
|
|
|
|
#include "parser/parse_type.h"
|
|
|
|
#include "utils/acl.h"
|
|
|
|
#include "utils/builtins.h"
|
|
|
|
#include "utils/lsyscache.h"
|
|
|
|
#include "utils/syscache.h"
|
|
|
|
|
|
|
|
|
|
|
|
/*
|
|
|
|
* DefineAggregate
|
2006-04-15 19:45:46 +02:00
|
|
|
*
|
|
|
|
* "oldstyle" signals the old (pre-8.2) style where the aggregate input type
|
|
|
|
* is specified by a BASETYPE element in the parameters. Otherwise,
|
Allow aggregate functions to be VARIADIC.
There's no inherent reason why an aggregate function can't be variadic
(even VARIADIC ANY) if its transition function can handle the case.
Indeed, this patch to add the feature touches none of the planner or
executor, and little of the parser; the main missing stuff was DDL and
pg_dump support.
It is true that variadic aggregates can create the same sort of ambiguity
about parameters versus ORDER BY keys that was complained of when we
(briefly) had both one- and two-argument forms of string_agg(). However,
the policy formed in response to that discussion only said that we'd not
create any built-in aggregates with varying numbers of arguments, not that
we shouldn't allow users to do it. So the logical extension of that is
we can allow users to make variadic aggregates as long as we're wary about
shipping any such in core.
In passing, this patch allows aggregate function arguments to be named, to
the extent of remembering the names in pg_proc and dumping them in pg_dump.
You can't yet call an aggregate using named-parameter notation. That seems
like a likely future extension, but it'll take some work, and it's not what
this patch is really about. Likewise, there's still some work needed to
make window functions handle VARIADIC fully, but I left that for another
day.
initdb forced because of new aggvariadic field in Aggref parse nodes.
2013-09-03 23:08:38 +02:00
|
|
|
* "args" is a list of FunctionParameter structs defining the agg's arguments.
|
|
|
|
* "parameters" is a list of DefElem representing the agg's definition clauses.
|
2002-04-15 07:22:04 +02:00
|
|
|
*/
|
2012-12-24 00:25:03 +01:00
|
|
|
Oid
|
Allow aggregate functions to be VARIADIC.
There's no inherent reason why an aggregate function can't be variadic
(even VARIADIC ANY) if its transition function can handle the case.
Indeed, this patch to add the feature touches none of the planner or
executor, and little of the parser; the main missing stuff was DDL and
pg_dump support.
It is true that variadic aggregates can create the same sort of ambiguity
about parameters versus ORDER BY keys that was complained of when we
(briefly) had both one- and two-argument forms of string_agg(). However,
the policy formed in response to that discussion only said that we'd not
create any built-in aggregates with varying numbers of arguments, not that
we shouldn't allow users to do it. So the logical extension of that is
we can allow users to make variadic aggregates as long as we're wary about
shipping any such in core.
In passing, this patch allows aggregate function arguments to be named, to
the extent of remembering the names in pg_proc and dumping them in pg_dump.
You can't yet call an aggregate using named-parameter notation. That seems
like a likely future extension, but it'll take some work, and it's not what
this patch is really about. Likewise, there's still some work needed to
make window functions handle VARIADIC fully, but I left that for another
day.
initdb forced because of new aggvariadic field in Aggref parse nodes.
2013-09-03 23:08:38 +02:00
|
|
|
DefineAggregate(List *name, List *args, bool oldstyle, List *parameters,
|
|
|
|
const char *queryString)
|
2002-04-15 07:22:04 +02:00
|
|
|
{
|
|
|
|
char *aggName;
|
|
|
|
Oid aggNamespace;
|
2002-04-27 05:45:03 +02:00
|
|
|
AclResult aclresult;
|
2002-04-15 07:22:04 +02:00
|
|
|
List *transfuncName = NIL;
|
|
|
|
List *finalfuncName = NIL;
|
2005-04-12 06:26:34 +02:00
|
|
|
List *sortoperatorName = NIL;
|
2002-04-15 07:22:04 +02:00
|
|
|
TypeName *baseType = NULL;
|
|
|
|
TypeName *transType = NULL;
|
|
|
|
char *initval = NULL;
|
2006-10-04 02:30:14 +02:00
|
|
|
int numArgs;
|
Allow aggregate functions to be VARIADIC.
There's no inherent reason why an aggregate function can't be variadic
(even VARIADIC ANY) if its transition function can handle the case.
Indeed, this patch to add the feature touches none of the planner or
executor, and little of the parser; the main missing stuff was DDL and
pg_dump support.
It is true that variadic aggregates can create the same sort of ambiguity
about parameters versus ORDER BY keys that was complained of when we
(briefly) had both one- and two-argument forms of string_agg(). However,
the policy formed in response to that discussion only said that we'd not
create any built-in aggregates with varying numbers of arguments, not that
we shouldn't allow users to do it. So the logical extension of that is
we can allow users to make variadic aggregates as long as we're wary about
shipping any such in core.
In passing, this patch allows aggregate function arguments to be named, to
the extent of remembering the names in pg_proc and dumping them in pg_dump.
You can't yet call an aggregate using named-parameter notation. That seems
like a likely future extension, but it'll take some work, and it's not what
this patch is really about. Likewise, there's still some work needed to
make window functions handle VARIADIC fully, but I left that for another
day.
initdb forced because of new aggvariadic field in Aggref parse nodes.
2013-09-03 23:08:38 +02:00
|
|
|
oidvector *parameterTypes;
|
|
|
|
ArrayType *allParameterTypes;
|
|
|
|
ArrayType *parameterModes;
|
|
|
|
ArrayType *parameterNames;
|
|
|
|
List *parameterDefaults;
|
2002-04-15 07:22:04 +02:00
|
|
|
Oid transTypeId;
|
2012-10-04 23:54:53 +02:00
|
|
|
char transTypeType;
|
2004-05-26 06:41:50 +02:00
|
|
|
ListCell *pl;
|
2002-04-15 07:22:04 +02:00
|
|
|
|
|
|
|
/* Convert list of names to a name and namespace */
|
2006-04-15 19:45:46 +02:00
|
|
|
aggNamespace = QualifiedNameGetCreationNamespace(name, &aggName);
|
2002-04-15 07:22:04 +02:00
|
|
|
|
2002-04-27 05:45:03 +02:00
|
|
|
/* Check we have creation rights in target namespace */
|
|
|
|
aclresult = pg_namespace_aclcheck(aggNamespace, GetUserId(), ACL_CREATE);
|
|
|
|
if (aclresult != ACLCHECK_OK)
|
2003-08-01 02:15:26 +02:00
|
|
|
aclcheck_error(aclresult, ACL_KIND_NAMESPACE,
|
|
|
|
get_namespace_name(aggNamespace));
|
2002-04-27 05:45:03 +02:00
|
|
|
|
2002-04-15 07:22:04 +02:00
|
|
|
foreach(pl, parameters)
|
|
|
|
{
|
|
|
|
DefElem *defel = (DefElem *) lfirst(pl);
|
|
|
|
|
|
|
|
/*
|
2005-10-15 04:49:52 +02:00
|
|
|
* sfunc1, stype1, and initcond1 are accepted as obsolete spellings
|
|
|
|
* for sfunc, stype, initcond.
|
2002-04-15 07:22:04 +02:00
|
|
|
*/
|
2004-05-07 02:24:59 +02:00
|
|
|
if (pg_strcasecmp(defel->defname, "sfunc") == 0)
|
2002-04-15 07:22:04 +02:00
|
|
|
transfuncName = defGetQualifiedName(defel);
|
2004-05-07 02:24:59 +02:00
|
|
|
else if (pg_strcasecmp(defel->defname, "sfunc1") == 0)
|
2002-04-15 07:22:04 +02:00
|
|
|
transfuncName = defGetQualifiedName(defel);
|
2004-05-07 02:24:59 +02:00
|
|
|
else if (pg_strcasecmp(defel->defname, "finalfunc") == 0)
|
2002-04-15 07:22:04 +02:00
|
|
|
finalfuncName = defGetQualifiedName(defel);
|
2005-04-12 06:26:34 +02:00
|
|
|
else if (pg_strcasecmp(defel->defname, "sortop") == 0)
|
|
|
|
sortoperatorName = defGetQualifiedName(defel);
|
2004-05-07 02:24:59 +02:00
|
|
|
else if (pg_strcasecmp(defel->defname, "basetype") == 0)
|
2002-04-15 07:22:04 +02:00
|
|
|
baseType = defGetTypeName(defel);
|
2004-05-07 02:24:59 +02:00
|
|
|
else if (pg_strcasecmp(defel->defname, "stype") == 0)
|
2002-04-15 07:22:04 +02:00
|
|
|
transType = defGetTypeName(defel);
|
2004-05-07 02:24:59 +02:00
|
|
|
else if (pg_strcasecmp(defel->defname, "stype1") == 0)
|
2002-04-15 07:22:04 +02:00
|
|
|
transType = defGetTypeName(defel);
|
2004-05-07 02:24:59 +02:00
|
|
|
else if (pg_strcasecmp(defel->defname, "initcond") == 0)
|
2002-04-15 07:22:04 +02:00
|
|
|
initval = defGetString(defel);
|
2004-05-07 02:24:59 +02:00
|
|
|
else if (pg_strcasecmp(defel->defname, "initcond1") == 0)
|
2002-04-15 07:22:04 +02:00
|
|
|
initval = defGetString(defel);
|
|
|
|
else
|
2003-07-20 23:56:35 +02:00
|
|
|
ereport(WARNING,
|
|
|
|
(errcode(ERRCODE_SYNTAX_ERROR),
|
|
|
|
errmsg("aggregate attribute \"%s\" not recognized",
|
|
|
|
defel->defname)));
|
2002-04-15 07:22:04 +02:00
|
|
|
}
|
|
|
|
|
|
|
|
/*
|
|
|
|
* make sure we have our required definitions
|
|
|
|
*/
|
|
|
|
if (transType == NULL)
|
2003-07-20 23:56:35 +02:00
|
|
|
ereport(ERROR,
|
|
|
|
(errcode(ERRCODE_INVALID_FUNCTION_DEFINITION),
|
|
|
|
errmsg("aggregate stype must be specified")));
|
2002-04-15 07:22:04 +02:00
|
|
|
if (transfuncName == NIL)
|
2003-07-20 23:56:35 +02:00
|
|
|
ereport(ERROR,
|
|
|
|
(errcode(ERRCODE_INVALID_FUNCTION_DEFINITION),
|
|
|
|
errmsg("aggregate sfunc must be specified")));
|
2002-04-15 07:22:04 +02:00
|
|
|
|
|
|
|
/*
|
2006-07-27 21:52:07 +02:00
|
|
|
* look up the aggregate's input datatype(s).
|
2006-04-15 19:45:46 +02:00
|
|
|
*/
|
|
|
|
if (oldstyle)
|
|
|
|
{
|
|
|
|
/*
|
2006-10-04 02:30:14 +02:00
|
|
|
* Old style: use basetype parameter. This supports aggregates of
|
|
|
|
* zero or one input, with input type ANY meaning zero inputs.
|
2006-04-15 19:45:46 +02:00
|
|
|
*
|
|
|
|
* Historically we allowed the command to look like basetype = 'ANY'
|
|
|
|
* so we must do a case-insensitive comparison for the name ANY. Ugh.
|
|
|
|
*/
|
Allow aggregate functions to be VARIADIC.
There's no inherent reason why an aggregate function can't be variadic
(even VARIADIC ANY) if its transition function can handle the case.
Indeed, this patch to add the feature touches none of the planner or
executor, and little of the parser; the main missing stuff was DDL and
pg_dump support.
It is true that variadic aggregates can create the same sort of ambiguity
about parameters versus ORDER BY keys that was complained of when we
(briefly) had both one- and two-argument forms of string_agg(). However,
the policy formed in response to that discussion only said that we'd not
create any built-in aggregates with varying numbers of arguments, not that
we shouldn't allow users to do it. So the logical extension of that is
we can allow users to make variadic aggregates as long as we're wary about
shipping any such in core.
In passing, this patch allows aggregate function arguments to be named, to
the extent of remembering the names in pg_proc and dumping them in pg_dump.
You can't yet call an aggregate using named-parameter notation. That seems
like a likely future extension, but it'll take some work, and it's not what
this patch is really about. Likewise, there's still some work needed to
make window functions handle VARIADIC fully, but I left that for another
day.
initdb forced because of new aggvariadic field in Aggref parse nodes.
2013-09-03 23:08:38 +02:00
|
|
|
Oid aggArgTypes[1];
|
|
|
|
|
2006-04-15 19:45:46 +02:00
|
|
|
if (baseType == NULL)
|
|
|
|
ereport(ERROR,
|
|
|
|
(errcode(ERRCODE_INVALID_FUNCTION_DEFINITION),
|
|
|
|
errmsg("aggregate input type must be specified")));
|
|
|
|
|
|
|
|
if (pg_strcasecmp(TypeNameToString(baseType), "ANY") == 0)
|
2006-07-27 21:52:07 +02:00
|
|
|
{
|
|
|
|
numArgs = 0;
|
Allow aggregate functions to be VARIADIC.
There's no inherent reason why an aggregate function can't be variadic
(even VARIADIC ANY) if its transition function can handle the case.
Indeed, this patch to add the feature touches none of the planner or
executor, and little of the parser; the main missing stuff was DDL and
pg_dump support.
It is true that variadic aggregates can create the same sort of ambiguity
about parameters versus ORDER BY keys that was complained of when we
(briefly) had both one- and two-argument forms of string_agg(). However,
the policy formed in response to that discussion only said that we'd not
create any built-in aggregates with varying numbers of arguments, not that
we shouldn't allow users to do it. So the logical extension of that is
we can allow users to make variadic aggregates as long as we're wary about
shipping any such in core.
In passing, this patch allows aggregate function arguments to be named, to
the extent of remembering the names in pg_proc and dumping them in pg_dump.
You can't yet call an aggregate using named-parameter notation. That seems
like a likely future extension, but it'll take some work, and it's not what
this patch is really about. Likewise, there's still some work needed to
make window functions handle VARIADIC fully, but I left that for another
day.
initdb forced because of new aggvariadic field in Aggref parse nodes.
2013-09-03 23:08:38 +02:00
|
|
|
aggArgTypes[0] = InvalidOid;
|
2006-07-27 21:52:07 +02:00
|
|
|
}
|
2006-04-15 19:45:46 +02:00
|
|
|
else
|
2006-07-27 21:52:07 +02:00
|
|
|
{
|
|
|
|
numArgs = 1;
|
2010-10-25 20:40:46 +02:00
|
|
|
aggArgTypes[0] = typenameTypeId(NULL, baseType);
|
2006-07-27 21:52:07 +02:00
|
|
|
}
|
Allow aggregate functions to be VARIADIC.
There's no inherent reason why an aggregate function can't be variadic
(even VARIADIC ANY) if its transition function can handle the case.
Indeed, this patch to add the feature touches none of the planner or
executor, and little of the parser; the main missing stuff was DDL and
pg_dump support.
It is true that variadic aggregates can create the same sort of ambiguity
about parameters versus ORDER BY keys that was complained of when we
(briefly) had both one- and two-argument forms of string_agg(). However,
the policy formed in response to that discussion only said that we'd not
create any built-in aggregates with varying numbers of arguments, not that
we shouldn't allow users to do it. So the logical extension of that is
we can allow users to make variadic aggregates as long as we're wary about
shipping any such in core.
In passing, this patch allows aggregate function arguments to be named, to
the extent of remembering the names in pg_proc and dumping them in pg_dump.
You can't yet call an aggregate using named-parameter notation. That seems
like a likely future extension, but it'll take some work, and it's not what
this patch is really about. Likewise, there's still some work needed to
make window functions handle VARIADIC fully, but I left that for another
day.
initdb forced because of new aggvariadic field in Aggref parse nodes.
2013-09-03 23:08:38 +02:00
|
|
|
parameterTypes = buildoidvector(aggArgTypes, numArgs);
|
|
|
|
allParameterTypes = NULL;
|
|
|
|
parameterModes = NULL;
|
|
|
|
parameterNames = NULL;
|
|
|
|
parameterDefaults = NIL;
|
2006-04-15 19:45:46 +02:00
|
|
|
}
|
|
|
|
else
|
|
|
|
{
|
|
|
|
/*
|
Allow aggregate functions to be VARIADIC.
There's no inherent reason why an aggregate function can't be variadic
(even VARIADIC ANY) if its transition function can handle the case.
Indeed, this patch to add the feature touches none of the planner or
executor, and little of the parser; the main missing stuff was DDL and
pg_dump support.
It is true that variadic aggregates can create the same sort of ambiguity
about parameters versus ORDER BY keys that was complained of when we
(briefly) had both one- and two-argument forms of string_agg(). However,
the policy formed in response to that discussion only said that we'd not
create any built-in aggregates with varying numbers of arguments, not that
we shouldn't allow users to do it. So the logical extension of that is
we can allow users to make variadic aggregates as long as we're wary about
shipping any such in core.
In passing, this patch allows aggregate function arguments to be named, to
the extent of remembering the names in pg_proc and dumping them in pg_dump.
You can't yet call an aggregate using named-parameter notation. That seems
like a likely future extension, but it'll take some work, and it's not what
this patch is really about. Likewise, there's still some work needed to
make window functions handle VARIADIC fully, but I left that for another
day.
initdb forced because of new aggvariadic field in Aggref parse nodes.
2013-09-03 23:08:38 +02:00
|
|
|
* New style: args is a list of FunctionParameters (possibly zero of
|
|
|
|
* 'em). We share functioncmds.c's code for processing them.
|
2006-04-15 19:45:46 +02:00
|
|
|
*/
|
Allow aggregate functions to be VARIADIC.
There's no inherent reason why an aggregate function can't be variadic
(even VARIADIC ANY) if its transition function can handle the case.
Indeed, this patch to add the feature touches none of the planner or
executor, and little of the parser; the main missing stuff was DDL and
pg_dump support.
It is true that variadic aggregates can create the same sort of ambiguity
about parameters versus ORDER BY keys that was complained of when we
(briefly) had both one- and two-argument forms of string_agg(). However,
the policy formed in response to that discussion only said that we'd not
create any built-in aggregates with varying numbers of arguments, not that
we shouldn't allow users to do it. So the logical extension of that is
we can allow users to make variadic aggregates as long as we're wary about
shipping any such in core.
In passing, this patch allows aggregate function arguments to be named, to
the extent of remembering the names in pg_proc and dumping them in pg_dump.
You can't yet call an aggregate using named-parameter notation. That seems
like a likely future extension, but it'll take some work, and it's not what
this patch is really about. Likewise, there's still some work needed to
make window functions handle VARIADIC fully, but I left that for another
day.
initdb forced because of new aggvariadic field in Aggref parse nodes.
2013-09-03 23:08:38 +02:00
|
|
|
Oid requiredResultType;
|
2006-07-27 21:52:07 +02:00
|
|
|
|
2006-04-15 19:45:46 +02:00
|
|
|
if (baseType != NULL)
|
|
|
|
ereport(ERROR,
|
|
|
|
(errcode(ERRCODE_INVALID_FUNCTION_DEFINITION),
|
|
|
|
errmsg("basetype is redundant with aggregate input type specification")));
|
|
|
|
|
2006-07-27 21:52:07 +02:00
|
|
|
numArgs = list_length(args);
|
Allow aggregate functions to be VARIADIC.
There's no inherent reason why an aggregate function can't be variadic
(even VARIADIC ANY) if its transition function can handle the case.
Indeed, this patch to add the feature touches none of the planner or
executor, and little of the parser; the main missing stuff was DDL and
pg_dump support.
It is true that variadic aggregates can create the same sort of ambiguity
about parameters versus ORDER BY keys that was complained of when we
(briefly) had both one- and two-argument forms of string_agg(). However,
the policy formed in response to that discussion only said that we'd not
create any built-in aggregates with varying numbers of arguments, not that
we shouldn't allow users to do it. So the logical extension of that is
we can allow users to make variadic aggregates as long as we're wary about
shipping any such in core.
In passing, this patch allows aggregate function arguments to be named, to
the extent of remembering the names in pg_proc and dumping them in pg_dump.
You can't yet call an aggregate using named-parameter notation. That seems
like a likely future extension, but it'll take some work, and it's not what
this patch is really about. Likewise, there's still some work needed to
make window functions handle VARIADIC fully, but I left that for another
day.
initdb forced because of new aggvariadic field in Aggref parse nodes.
2013-09-03 23:08:38 +02:00
|
|
|
interpret_function_parameter_list(args,
|
|
|
|
InvalidOid,
|
|
|
|
true, /* is an aggregate */
|
|
|
|
queryString,
|
|
|
|
¶meterTypes,
|
|
|
|
&allParameterTypes,
|
|
|
|
¶meterModes,
|
|
|
|
¶meterNames,
|
|
|
|
¶meterDefaults,
|
|
|
|
&requiredResultType);
|
|
|
|
/* Parameter defaults are not currently allowed by the grammar */
|
|
|
|
Assert(parameterDefaults == NIL);
|
|
|
|
/* There shouldn't have been any OUT parameters, either */
|
|
|
|
Assert(requiredResultType == InvalidOid);
|
2006-04-15 19:45:46 +02:00
|
|
|
}
|
|
|
|
|
|
|
|
/*
|
|
|
|
* look up the aggregate's transtype.
|
2002-08-22 02:01:51 +02:00
|
|
|
*
|
2006-10-04 02:30:14 +02:00
|
|
|
* transtype can't be a pseudo-type, since we need to be able to store
|
|
|
|
* values of the transtype. However, we can allow polymorphic transtype
|
2009-06-11 16:49:15 +02:00
|
|
|
* in some cases (AggregateCreate will check). Also, we allow "internal"
|
2008-11-14 20:47:50 +01:00
|
|
|
* for functions that want to pass pointers to private data structures;
|
2009-06-11 16:49:15 +02:00
|
|
|
* but allow that only to superusers, since you could crash the system (or
|
|
|
|
* worse) by connecting up incompatible internal-using functions in an
|
|
|
|
* aggregate.
|
2002-04-15 07:22:04 +02:00
|
|
|
*/
|
2010-10-25 20:40:46 +02:00
|
|
|
transTypeId = typenameTypeId(NULL, transType);
|
2012-10-04 23:54:53 +02:00
|
|
|
transTypeType = get_typtype(transTypeId);
|
|
|
|
if (transTypeType == TYPTYPE_PSEUDO &&
|
2007-04-02 05:49:42 +02:00
|
|
|
!IsPolymorphicType(transTypeId))
|
2008-11-14 20:47:50 +01:00
|
|
|
{
|
|
|
|
if (transTypeId == INTERNALOID && superuser())
|
2009-06-11 16:49:15 +02:00
|
|
|
/* okay */ ;
|
2008-11-14 20:47:50 +01:00
|
|
|
else
|
|
|
|
ereport(ERROR,
|
|
|
|
(errcode(ERRCODE_INVALID_FUNCTION_DEFINITION),
|
|
|
|
errmsg("aggregate transition data type cannot be %s",
|
|
|
|
format_type_be(transTypeId))));
|
|
|
|
}
|
2002-04-15 07:22:04 +02:00
|
|
|
|
2012-10-04 23:54:53 +02:00
|
|
|
/*
|
|
|
|
* If we have an initval, and it's not for a pseudotype (particularly a
|
|
|
|
* polymorphic type), make sure it's acceptable to the type's input
|
|
|
|
* function. We will store the initval as text, because the input
|
|
|
|
* function isn't necessarily immutable (consider "now" for timestamp),
|
|
|
|
* and we want to use the runtime not creation-time interpretation of the
|
|
|
|
* value. However, if it's an incorrect value it seems much more
|
|
|
|
* user-friendly to complain at CREATE AGGREGATE time.
|
|
|
|
*/
|
|
|
|
if (initval && transTypeType != TYPTYPE_PSEUDO)
|
|
|
|
{
|
|
|
|
Oid typinput,
|
|
|
|
typioparam;
|
|
|
|
|
|
|
|
getTypeInputInfo(transTypeId, &typinput, &typioparam);
|
|
|
|
(void) OidInputFunctionCall(typinput, initval, typioparam, -1);
|
|
|
|
}
|
|
|
|
|
2002-04-15 07:22:04 +02:00
|
|
|
/*
|
|
|
|
* Most of the argument-checking is done inside of AggregateCreate
|
|
|
|
*/
|
2013-05-29 22:58:43 +02:00
|
|
|
return AggregateCreate(aggName, /* aggregate name */
|
2012-12-24 00:25:03 +01:00
|
|
|
aggNamespace, /* namespace */
|
|
|
|
numArgs,
|
Allow aggregate functions to be VARIADIC.
There's no inherent reason why an aggregate function can't be variadic
(even VARIADIC ANY) if its transition function can handle the case.
Indeed, this patch to add the feature touches none of the planner or
executor, and little of the parser; the main missing stuff was DDL and
pg_dump support.
It is true that variadic aggregates can create the same sort of ambiguity
about parameters versus ORDER BY keys that was complained of when we
(briefly) had both one- and two-argument forms of string_agg(). However,
the policy formed in response to that discussion only said that we'd not
create any built-in aggregates with varying numbers of arguments, not that
we shouldn't allow users to do it. So the logical extension of that is
we can allow users to make variadic aggregates as long as we're wary about
shipping any such in core.
In passing, this patch allows aggregate function arguments to be named, to
the extent of remembering the names in pg_proc and dumping them in pg_dump.
You can't yet call an aggregate using named-parameter notation. That seems
like a likely future extension, but it'll take some work, and it's not what
this patch is really about. Likewise, there's still some work needed to
make window functions handle VARIADIC fully, but I left that for another
day.
initdb forced because of new aggvariadic field in Aggref parse nodes.
2013-09-03 23:08:38 +02:00
|
|
|
parameterTypes,
|
|
|
|
PointerGetDatum(allParameterTypes),
|
|
|
|
PointerGetDatum(parameterModes),
|
|
|
|
PointerGetDatum(parameterNames),
|
|
|
|
parameterDefaults,
|
2012-12-24 00:25:03 +01:00
|
|
|
transfuncName, /* step function name */
|
|
|
|
finalfuncName, /* final function name */
|
|
|
|
sortoperatorName, /* sort operator name */
|
2013-05-29 22:58:43 +02:00
|
|
|
transTypeId, /* transition data type */
|
2012-12-24 00:25:03 +01:00
|
|
|
initval); /* initial condition */
|
2002-04-15 07:22:04 +02:00
|
|
|
}
|