2015-04-26 16:33:14 +02:00
|
|
|
# contrib/hstore_plperl/Makefile
|
|
|
|
|
|
|
|
MODULE_big = hstore_plperl
|
2015-05-03 15:10:47 +02:00
|
|
|
OBJS = hstore_plperl.o $(WIN32RES)
|
|
|
|
PGFILEDESC = "hstore_plperl - hstore transform for plperl"
|
2015-04-26 16:33:14 +02:00
|
|
|
|
2015-05-02 04:16:58 +02:00
|
|
|
|
2015-04-26 16:33:14 +02:00
|
|
|
EXTENSION = hstore_plperl hstore_plperlu
|
|
|
|
DATA = hstore_plperl--1.0.sql hstore_plperlu--1.0.sql
|
|
|
|
|
2015-04-26 22:09:22 +02:00
|
|
|
REGRESS = hstore_plperl hstore_plperlu create_transform
|
2015-04-26 16:33:14 +02:00
|
|
|
EXTRA_INSTALL = contrib/hstore
|
|
|
|
|
|
|
|
ifdef USE_PGXS
|
2018-09-16 19:46:45 +02:00
|
|
|
PG_CPPFLAGS = -I$(includedir_server)/extension
|
2015-04-26 16:33:14 +02:00
|
|
|
PG_CONFIG = pg_config
|
|
|
|
PGXS := $(shell $(PG_CONFIG) --pgxs)
|
|
|
|
include $(PGXS)
|
|
|
|
else
|
2018-09-16 19:46:45 +02:00
|
|
|
PG_CPPFLAGS = -I$(top_srcdir)/src/pl/plperl -I$(top_srcdir)/contrib
|
2015-04-26 16:33:14 +02:00
|
|
|
subdir = contrib/hstore_plperl
|
|
|
|
top_builddir = ../..
|
|
|
|
include $(top_builddir)/src/Makefile.global
|
|
|
|
include $(top_srcdir)/contrib/contrib-global.mk
|
|
|
|
endif
|
2015-05-02 14:03:47 +02:00
|
|
|
|
2016-10-04 23:49:07 +02:00
|
|
|
# We must link libperl explicitly
|
2015-05-02 14:03:47 +02:00
|
|
|
ifeq ($(PORTNAME), win32)
|
2015-05-03 15:10:47 +02:00
|
|
|
# these settings are the same as for plperl
|
2015-05-02 14:03:47 +02:00
|
|
|
override CPPFLAGS += -DPLPERL_HAVE_UID_GID -Wno-comment
|
2016-10-04 23:49:07 +02:00
|
|
|
# ... see silliness in plperl Makefile ...
|
Prevent accidental linking of system-supplied copies of libpq.so etc.
We were being careless in some places about the order of -L switches in
link command lines, such that -L switches referring to external directories
could come before those referring to directories within the build tree.
This made it possible to accidentally link a system-supplied library, for
example /usr/lib/libpq.so, in place of the one built in the build tree.
Hilarity ensued, the more so the older the system-supplied library is.
To fix, break LDFLAGS into two parts, a sub-variable LDFLAGS_INTERNAL
and the main LDFLAGS variable, both of which are "recursively expanded"
so that they can be incrementally adjusted by different makefiles.
Establish a policy that -L switches for directories in the build tree
must always be added to LDFLAGS_INTERNAL, while -L switches for external
directories must always be added to LDFLAGS. This is sufficient to
ensure a safe search order. For simplicity, we typically also put -l
switches for the respective libraries into those same variables.
(Traditional make usage would have us put -l switches into LIBS, but
cleaning that up is a project for another day, as there's no clear
need for it.)
This turns out to also require separating SHLIB_LINK into two variables,
SHLIB_LINK and SHLIB_LINK_INTERNAL, with a similar rule about which
switches go into which variable. And likewise for PG_LIBS.
Although this change might appear to affect external users of pgxs.mk,
I think it doesn't; they shouldn't have any need to touch the _INTERNAL
variables.
In passing, tweak src/common/Makefile so that the value of CPPFLAGS
recorded in pg_config lacks "-DFRONTEND" and the recorded value of
LDFLAGS lacks "-L../../../src/common". Both of those things are
mistakes, apparently introduced during prior code rearrangements,
as old versions of pg_config don't print them. In general we don't
want anything that's specific to the src/common subdirectory to
appear in those outputs.
This is certainly a bug fix, but in view of the lack of field
complaints, I'm unsure whether it's worth the risk of back-patching.
In any case it seems wise to see what the buildfarm makes of it first.
Discussion: https://postgr.es/m/25214.1522604295@sss.pgh.pa.us
2018-04-03 22:26:05 +02:00
|
|
|
SHLIB_LINK_INTERNAL += $(sort $(wildcard ../../src/pl/plperl/libperl*.a))
|
2016-10-04 23:49:07 +02:00
|
|
|
else
|
|
|
|
rpathdir = $(perl_archlibexp)/CORE
|
|
|
|
SHLIB_LINK += $(perl_embed_ldflags)
|
2015-05-02 14:03:47 +02:00
|
|
|
endif
|
2015-07-18 16:09:04 +02:00
|
|
|
|
2015-05-03 15:10:47 +02:00
|
|
|
# As with plperl we need to make sure that the CORE directory is included
|
|
|
|
# last, probably because it sometimes contains some header files with names
|
|
|
|
# that clash with some of ours, or with some that we include, notably on
|
|
|
|
# Windows.
|
PL/Perl portability fix: absorb relevant -D switches from Perl.
The Perl documentation is very clear that stuff calling libperl should
be built with the compiler switches shown by Perl's $Config{ccflags}.
We'd been ignoring that up to now, and mostly getting away with it,
but recent Perl versions contain ABI compatibility cross-checks that
fail on some builds because of this omission. In particular the
sizeof(PerlInterpreter) can come out different due to some fields being
added or removed; which means we have a live ABI hazard that we'd better
fix rather than continuing to sweep it under the rug.
However, it still seems like a bad idea to just absorb $Config{ccflags}
verbatim. In some environments Perl was built with a different compiler
that doesn't even use the same switch syntax. -D switch syntax is pretty
universal though, and absorbing Perl's -D switches really ought to be
enough to fix the problem.
Furthermore, Perl likes to inject stuff like -D_LARGEFILE_SOURCE and
-D_FILE_OFFSET_BITS=64 into $Config{ccflags}, which affect libc ABIs on
platforms where they're relevant. Adopting those seems dangerous too.
It's unclear whether a build wherein Perl and Postgres have different ideas
of sizeof(off_t) etc would work, or whether anyone would care about making
it work. But it's dead certain that having different stdio ABIs in
core Postgres and PL/Perl will not work; we've seen that movie before.
Therefore, let's also ignore -D switches for symbols beginning with
underscore. The symbols that we actually need to import should be the ones
mentioned in perl.h's PL_bincompat_options stanza, and none of those start
with underscore, so this seems likely to work. (If it turns out not to
work everywhere, we could consider intersecting the symbols mentioned in
PL_bincompat_options with the -D switches. But that will be much more
complicated, so let's try this way first.)
This will need to be back-patched, but first let's see what the
buildfarm makes of it.
Ashutosh Sharma, some adjustments by me
Discussion: https://postgr.es/m/CANFyU97OVQ3+Mzfmt3MhuUm5NwPU=-FtbNH5Eb7nZL9ua8=rcA@mail.gmail.com
2017-07-28 20:25:28 +02:00
|
|
|
override CPPFLAGS := $(CPPFLAGS) $(perl_embed_ccflags) -I$(perl_archlibexp)/CORE
|