postgresql/src/tools/pgflex

Ignoring revisions in .git-blame-ignore-revs. Click here to bypass and see the normal blame view.

86 lines
2.9 KiB
Plaintext
Raw Normal View History

meson: Add initial version of meson based build system Autoconf is showing its age, fewer and fewer contributors know how to wrangle it. Recursive make has a lot of hard to resolve dependency issues and slow incremental rebuilds. Our home-grown MSVC build system is hard to maintain for developers not using Windows and runs tests serially. While these and other issues could individually be addressed with incremental improvements, together they seem best addressed by moving to a more modern build system. After evaluating different build system choices, we chose to use meson, to a good degree based on the adoption by other open source projects. We decided that it's more realistic to commit a relatively early version of the new build system and mature it in tree. This commit adds an initial version of a meson based build system. It supports building postgres on at least AIX, FreeBSD, Linux, macOS, NetBSD, OpenBSD, Solaris and Windows (however only gcc is supported on aix, solaris). For Windows/MSVC postgres can now be built with ninja (faster, particularly for incremental builds) and msbuild (supporting the visual studio GUI, but building slower). Several aspects (e.g. Windows rc file generation, PGXS compatibility, LLVM bitcode generation, documentation adjustments) are done in subsequent commits requiring further review. Other aspects (e.g. not installing test-only extensions) are not yet addressed. When building on Windows with msbuild, builds are slower when using a visual studio version older than 2019, because those versions do not support MultiToolTask, required by meson for intra-target parallelism. The plan is to remove the MSVC specific build system in src/tools/msvc soon after reaching feature parity. However, we're not planning to remove the autoconf/make build system in the near future. Likely we're going to keep at least the parts required for PGXS to keep working around until all supported versions build with meson. Some initial help for postgres developers is at https://wiki.postgresql.org/wiki/Meson With contributions from Thomas Munro, John Naylor, Stone Tickle and others. Author: Andres Freund <andres@anarazel.de> Author: Nazir Bilal Yavuz <byavuz81@gmail.com> Author: Peter Eisentraut <peter@eisentraut.org> Reviewed-By: Peter Eisentraut <peter.eisentraut@enterprisedb.com> Discussion: https://postgr.es/m/20211012083721.hvixq4pnh2pixr3j@alap3.anarazel.de
2022-09-22 06:53:12 +02:00
#!/usr/bin/env python3
#
# Wrapper around flex that:
# - ensures lex.backup is created in a private directory
# - can error out if lex.backup is created (--no-backup)
# - can fix warnings (--fix-warnings)
# - works around concurrency issues with win_flex.exe:
# https://github.com/lexxmark/winflexbison/issues/86
import argparse
import os
import subprocess
import sys
from os.path import abspath
parser = argparse.ArgumentParser()
parser.add_argument('--flex', type=abspath, required=True)
parser.add_argument('--perl', type=abspath, required=True)
parser.add_argument('--builddir', type=abspath, required=True)
parser.add_argument('--srcdir', type=abspath, required=True)
parser.add_argument('--privatedir', type=abspath, required=True,
help='private directory for target')
parser.add_argument('-o', dest='output_file', type=abspath, required=True,
help='output file')
parser.add_argument('-i', dest='input_file', type=abspath, help='input file')
parser.add_argument('--fix-warnings', action='store_true',
help='whether to fix warnings in generated file')
parser.add_argument('--no-backup', action='store_true',
help='whether no_backup is enabled or not')
parser.add_argument('flex_flags', nargs='*', help='flags passed on to flex')
args = parser.parse_args()
# Since 'lex.backup' is always named that and ninja uses the top level build
# directory as current directory for all commands, change directory to
# temporary directory to avoid conflicts between concurrent flex
# invocations. Only unreleased versions of flex have an argument to change
# lex.filename to be named differently.
if not os.path.isdir(args.privatedir):
os.mkdir(args.privatedir)
os.chdir(args.privatedir)
# win_flex.exe generates names in a racy way, sometimes leading to random
# "error deleting file" failures and sometimes to intermingled file
# contents. Set FLEX_TMP_DIR to the target private directory to avoid
# that. That environment variable isn't consulted on other platforms, so we
# don't even need to make this conditional.
env = {'FLEX_TMP_DIR': args.privatedir}
# build flex invocation
command = [args.flex, '-o', args.output_file]
if args.no_backup:
command += ['-b']
command += args.flex_flags
command += [args.input_file]
# create .c file from .l file
sp = subprocess.run(command, env=env)
if sp.returncode != 0:
sys.exit(sp.returncode)
# check lex.backup
if args.no_backup:
with open('lex.backup') as lex:
if len(lex.readlines()) != 1:
sys.exit('Scanner requires backup; see lex.backup.')
os.remove('lex.backup')
# fix warnings
if args.fix_warnings:
fix_warning_script = os.path.join(args.srcdir,
'src/tools/fix-old-flex-code.pl')
command = [args.perl, fix_warning_script, args.output_file]
sp = subprocess.run(command)
if sp.returncode != 0:
sys.exit(sp.returncode)
sys.exit(0)