Improve error messages about mismatching relkind
Most error messages about a relkind that was not supported or
appropriate for the command was of the pattern
"relation \"%s\" is not a table, foreign table, or materialized view"
This style can become verbose and tedious to maintain. Moreover, it's
not very helpful: If I'm trying to create a comment on a TOAST table,
which is not supported, then the information that I could have created
a comment on a materialized view is pointless.
Instead, write the primary error message shorter and saying more
directly that what was attempted is not possible. Then, in the detail
message, explain that the operation is not supported for the relkind
the object was. To simplify that, add a new function
errdetail_relkind_not_supported() that does this.
In passing, make use of RELKIND_HAS_STORAGE() where appropriate,
instead of listing out the relkinds individually.
Reviewed-by: Michael Paquier <michael@paquier.xyz>
Reviewed-by: Alvaro Herrera <alvherre@alvh.no-ip.org>
Discussion: https://www.postgresql.org/message-id/flat/dc35a398-37d0-75ce-07ea-1dd71d98f8ec@2ndquadrant.com
2021-07-08 09:38:52 +02:00
|
|
|
/*-------------------------------------------------------------------------
|
|
|
|
*
|
|
|
|
* pg_class.c
|
|
|
|
* routines to support manipulation of the pg_class relation
|
|
|
|
*
|
2022-01-08 01:04:57 +01:00
|
|
|
* Portions Copyright (c) 1996-2022, PostgreSQL Global Development Group
|
Improve error messages about mismatching relkind
Most error messages about a relkind that was not supported or
appropriate for the command was of the pattern
"relation \"%s\" is not a table, foreign table, or materialized view"
This style can become verbose and tedious to maintain. Moreover, it's
not very helpful: If I'm trying to create a comment on a TOAST table,
which is not supported, then the information that I could have created
a comment on a materialized view is pointless.
Instead, write the primary error message shorter and saying more
directly that what was attempted is not possible. Then, in the detail
message, explain that the operation is not supported for the relkind
the object was. To simplify that, add a new function
errdetail_relkind_not_supported() that does this.
In passing, make use of RELKIND_HAS_STORAGE() where appropriate,
instead of listing out the relkinds individually.
Reviewed-by: Michael Paquier <michael@paquier.xyz>
Reviewed-by: Alvaro Herrera <alvherre@alvh.no-ip.org>
Discussion: https://www.postgresql.org/message-id/flat/dc35a398-37d0-75ce-07ea-1dd71d98f8ec@2ndquadrant.com
2021-07-08 09:38:52 +02:00
|
|
|
* Portions Copyright (c) 1994, Regents of the University of California
|
|
|
|
*
|
|
|
|
*
|
|
|
|
* IDENTIFICATION
|
|
|
|
* src/backend/catalog/pg_class.c
|
|
|
|
*
|
|
|
|
*-------------------------------------------------------------------------
|
|
|
|
*/
|
|
|
|
#include "postgres.h"
|
|
|
|
|
|
|
|
#include "catalog/pg_class.h"
|
|
|
|
|
|
|
|
/*
|
|
|
|
* Issue an errdetail() informing that the relkind is not supported for this
|
|
|
|
* operation.
|
|
|
|
*/
|
|
|
|
int
|
|
|
|
errdetail_relkind_not_supported(char relkind)
|
|
|
|
{
|
|
|
|
switch (relkind)
|
|
|
|
{
|
|
|
|
case RELKIND_RELATION:
|
|
|
|
return errdetail("This operation is not supported for tables.");
|
|
|
|
case RELKIND_INDEX:
|
|
|
|
return errdetail("This operation is not supported for indexes.");
|
|
|
|
case RELKIND_SEQUENCE:
|
|
|
|
return errdetail("This operation is not supported for sequences.");
|
|
|
|
case RELKIND_TOASTVALUE:
|
|
|
|
return errdetail("This operation is not supported for TOAST tables.");
|
|
|
|
case RELKIND_VIEW:
|
|
|
|
return errdetail("This operation is not supported for views.");
|
|
|
|
case RELKIND_MATVIEW:
|
|
|
|
return errdetail("This operation is not supported for materialized views.");
|
|
|
|
case RELKIND_COMPOSITE_TYPE:
|
|
|
|
return errdetail("This operation is not supported for composite types.");
|
|
|
|
case RELKIND_FOREIGN_TABLE:
|
|
|
|
return errdetail("This operation is not supported for foreign tables.");
|
|
|
|
case RELKIND_PARTITIONED_TABLE:
|
|
|
|
return errdetail("This operation is not supported for partitioned tables.");
|
|
|
|
case RELKIND_PARTITIONED_INDEX:
|
|
|
|
return errdetail("This operation is not supported for partitioned indexes.");
|
|
|
|
default:
|
|
|
|
elog(ERROR, "unrecognized relkind: '%c'", relkind);
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
}
|