2002-07-12 20:43:19 +02:00
|
|
|
/*-------------------------------------------------------------------------
|
|
|
|
*
|
|
|
|
* pg_constraint.c
|
|
|
|
* routines to support manipulation of the pg_constraint relation
|
|
|
|
*
|
2018-01-03 05:30:12 +01:00
|
|
|
* Portions Copyright (c) 1996-2018, PostgreSQL Global Development Group
|
2002-07-12 20:43:19 +02:00
|
|
|
* Portions Copyright (c) 1994, Regents of the University of California
|
|
|
|
*
|
|
|
|
*
|
|
|
|
* IDENTIFICATION
|
2010-09-20 22:08:53 +02:00
|
|
|
* src/backend/catalog/pg_constraint.c
|
2002-07-12 20:43:19 +02:00
|
|
|
*
|
|
|
|
*-------------------------------------------------------------------------
|
|
|
|
*/
|
|
|
|
#include "postgres.h"
|
|
|
|
|
|
|
|
#include "access/genam.h"
|
2006-07-11 19:26:59 +02:00
|
|
|
#include "access/heapam.h"
|
2012-08-30 22:15:44 +02:00
|
|
|
#include "access/htup_details.h"
|
2016-02-11 23:34:59 +01:00
|
|
|
#include "access/sysattr.h"
|
2018-04-15 02:12:14 +02:00
|
|
|
#include "access/tupconvert.h"
|
2002-07-12 20:43:19 +02:00
|
|
|
#include "catalog/dependency.h"
|
|
|
|
#include "catalog/indexing.h"
|
2010-11-25 17:48:49 +01:00
|
|
|
#include "catalog/objectaccess.h"
|
2018-04-15 02:12:14 +02:00
|
|
|
#include "catalog/partition.h"
|
2002-07-12 20:43:19 +02:00
|
|
|
#include "catalog/pg_constraint.h"
|
2007-02-14 02:58:58 +01:00
|
|
|
#include "catalog/pg_operator.h"
|
2002-08-26 19:54:02 +02:00
|
|
|
#include "catalog/pg_type.h"
|
2004-06-10 19:56:03 +02:00
|
|
|
#include "commands/defrem.h"
|
2018-04-04 19:02:31 +02:00
|
|
|
#include "commands/tablecmds.h"
|
2011-09-04 07:13:16 +02:00
|
|
|
#include "utils/array.h"
|
2002-07-12 20:43:19 +02:00
|
|
|
#include "utils/builtins.h"
|
|
|
|
#include "utils/fmgroids.h"
|
2008-01-17 19:56:54 +01:00
|
|
|
#include "utils/lsyscache.h"
|
2008-06-19 02:46:06 +02:00
|
|
|
#include "utils/rel.h"
|
2002-07-12 20:43:19 +02:00
|
|
|
#include "utils/syscache.h"
|
2008-03-26 22:10:39 +01:00
|
|
|
#include "utils/tqual.h"
|
2002-07-12 20:43:19 +02:00
|
|
|
|
|
|
|
|
|
|
|
/*
|
|
|
|
* CreateConstraintEntry
|
|
|
|
* Create a constraint table entry.
|
|
|
|
*
|
|
|
|
* Subsidiary records (such as triggers or indexes to implement the
|
2014-05-06 18:12:18 +02:00
|
|
|
* constraint) are *not* created here. But we do make dependency links
|
2002-07-12 20:43:19 +02:00
|
|
|
* from the constraint to the things it depends on.
|
2015-03-25 21:17:56 +01:00
|
|
|
*
|
|
|
|
* The new constraint's OID is returned.
|
2002-07-12 20:43:19 +02:00
|
|
|
*/
|
|
|
|
Oid
|
|
|
|
CreateConstraintEntry(const char *constraintName,
|
|
|
|
Oid constraintNamespace,
|
|
|
|
char constraintType,
|
|
|
|
bool isDeferrable,
|
|
|
|
bool isDeferred,
|
2011-02-08 13:23:20 +01:00
|
|
|
bool isValidated,
|
2018-03-23 14:48:22 +01:00
|
|
|
Oid parentConstrId,
|
2002-07-12 20:43:19 +02:00
|
|
|
Oid relId,
|
|
|
|
const int16 *constraintKey,
|
|
|
|
int constraintNKeys,
|
2018-04-07 22:00:39 +02:00
|
|
|
int constraintNTotalKeys,
|
2002-07-12 20:43:19 +02:00
|
|
|
Oid domainId,
|
2009-07-28 04:56:31 +02:00
|
|
|
Oid indexRelId,
|
2002-07-12 20:43:19 +02:00
|
|
|
Oid foreignRelId,
|
|
|
|
const int16 *foreignKey,
|
2007-02-14 02:58:58 +01:00
|
|
|
const Oid *pfEqOp,
|
|
|
|
const Oid *ppEqOp,
|
|
|
|
const Oid *ffEqOp,
|
2002-07-12 20:43:19 +02:00
|
|
|
int foreignNKeys,
|
|
|
|
char foreignUpdateType,
|
|
|
|
char foreignDeleteType,
|
|
|
|
char foreignMatchType,
|
2009-12-07 06:22:23 +01:00
|
|
|
const Oid *exclOp,
|
2002-07-16 07:53:34 +02:00
|
|
|
Node *conExpr,
|
2002-07-12 20:43:19 +02:00
|
|
|
const char *conBin,
|
2008-05-10 01:32:05 +02:00
|
|
|
const char *conSrc,
|
|
|
|
bool conIsLocal,
|
2011-12-05 19:10:18 +01:00
|
|
|
int conInhCount,
|
2013-03-18 03:55:14 +01:00
|
|
|
bool conNoInherit,
|
|
|
|
bool is_internal)
|
2002-07-12 20:43:19 +02:00
|
|
|
{
|
|
|
|
Relation conDesc;
|
|
|
|
Oid conOid;
|
|
|
|
HeapTuple tup;
|
2008-11-02 02:45:28 +01:00
|
|
|
bool nulls[Natts_pg_constraint];
|
2002-07-12 20:43:19 +02:00
|
|
|
Datum values[Natts_pg_constraint];
|
|
|
|
ArrayType *conkeyArray;
|
|
|
|
ArrayType *confkeyArray;
|
2007-02-14 02:58:58 +01:00
|
|
|
ArrayType *conpfeqopArray;
|
|
|
|
ArrayType *conppeqopArray;
|
|
|
|
ArrayType *conffeqopArray;
|
2009-12-07 06:22:23 +01:00
|
|
|
ArrayType *conexclopArray;
|
2002-07-12 20:43:19 +02:00
|
|
|
NameData cname;
|
|
|
|
int i;
|
|
|
|
ObjectAddress conobject;
|
|
|
|
|
2005-04-14 22:03:27 +02:00
|
|
|
conDesc = heap_open(ConstraintRelationId, RowExclusiveLock);
|
2002-07-12 20:43:19 +02:00
|
|
|
|
|
|
|
Assert(constraintName);
|
|
|
|
namestrcpy(&cname, constraintName);
|
|
|
|
|
|
|
|
/*
|
|
|
|
* Convert C arrays into Postgres arrays.
|
|
|
|
*/
|
|
|
|
if (constraintNKeys > 0)
|
|
|
|
{
|
|
|
|
Datum *conkey;
|
|
|
|
|
|
|
|
conkey = (Datum *) palloc(constraintNKeys * sizeof(Datum));
|
|
|
|
for (i = 0; i < constraintNKeys; i++)
|
|
|
|
conkey[i] = Int16GetDatum(constraintKey[i]);
|
|
|
|
conkeyArray = construct_array(conkey, constraintNKeys,
|
2002-08-26 19:54:02 +02:00
|
|
|
INT2OID, 2, true, 's');
|
2002-07-12 20:43:19 +02:00
|
|
|
}
|
|
|
|
else
|
|
|
|
conkeyArray = NULL;
|
|
|
|
|
|
|
|
if (foreignNKeys > 0)
|
|
|
|
{
|
2007-02-14 02:58:58 +01:00
|
|
|
Datum *fkdatums;
|
2002-07-12 20:43:19 +02:00
|
|
|
|
2007-02-14 02:58:58 +01:00
|
|
|
fkdatums = (Datum *) palloc(foreignNKeys * sizeof(Datum));
|
2002-07-12 20:43:19 +02:00
|
|
|
for (i = 0; i < foreignNKeys; i++)
|
2007-02-14 02:58:58 +01:00
|
|
|
fkdatums[i] = Int16GetDatum(foreignKey[i]);
|
|
|
|
confkeyArray = construct_array(fkdatums, foreignNKeys,
|
2002-08-26 19:54:02 +02:00
|
|
|
INT2OID, 2, true, 's');
|
2007-02-14 02:58:58 +01:00
|
|
|
for (i = 0; i < foreignNKeys; i++)
|
|
|
|
fkdatums[i] = ObjectIdGetDatum(pfEqOp[i]);
|
|
|
|
conpfeqopArray = construct_array(fkdatums, foreignNKeys,
|
|
|
|
OIDOID, sizeof(Oid), true, 'i');
|
|
|
|
for (i = 0; i < foreignNKeys; i++)
|
|
|
|
fkdatums[i] = ObjectIdGetDatum(ppEqOp[i]);
|
|
|
|
conppeqopArray = construct_array(fkdatums, foreignNKeys,
|
|
|
|
OIDOID, sizeof(Oid), true, 'i');
|
|
|
|
for (i = 0; i < foreignNKeys; i++)
|
|
|
|
fkdatums[i] = ObjectIdGetDatum(ffEqOp[i]);
|
|
|
|
conffeqopArray = construct_array(fkdatums, foreignNKeys,
|
|
|
|
OIDOID, sizeof(Oid), true, 'i');
|
2002-07-12 20:43:19 +02:00
|
|
|
}
|
|
|
|
else
|
2007-02-14 02:58:58 +01:00
|
|
|
{
|
2002-07-12 20:43:19 +02:00
|
|
|
confkeyArray = NULL;
|
2007-02-14 02:58:58 +01:00
|
|
|
conpfeqopArray = NULL;
|
|
|
|
conppeqopArray = NULL;
|
|
|
|
conffeqopArray = NULL;
|
|
|
|
}
|
2002-07-12 20:43:19 +02:00
|
|
|
|
2009-12-07 06:22:23 +01:00
|
|
|
if (exclOp != NULL)
|
|
|
|
{
|
|
|
|
Datum *opdatums;
|
|
|
|
|
|
|
|
opdatums = (Datum *) palloc(constraintNKeys * sizeof(Datum));
|
|
|
|
for (i = 0; i < constraintNKeys; i++)
|
|
|
|
opdatums[i] = ObjectIdGetDatum(exclOp[i]);
|
|
|
|
conexclopArray = construct_array(opdatums, constraintNKeys,
|
|
|
|
OIDOID, sizeof(Oid), true, 'i');
|
|
|
|
}
|
|
|
|
else
|
|
|
|
conexclopArray = NULL;
|
|
|
|
|
2002-07-12 20:43:19 +02:00
|
|
|
/* initialize nulls and values */
|
|
|
|
for (i = 0; i < Natts_pg_constraint; i++)
|
|
|
|
{
|
2008-11-02 02:45:28 +01:00
|
|
|
nulls[i] = false;
|
2002-07-12 20:43:19 +02:00
|
|
|
values[i] = (Datum) NULL;
|
|
|
|
}
|
|
|
|
|
|
|
|
values[Anum_pg_constraint_conname - 1] = NameGetDatum(&cname);
|
|
|
|
values[Anum_pg_constraint_connamespace - 1] = ObjectIdGetDatum(constraintNamespace);
|
|
|
|
values[Anum_pg_constraint_contype - 1] = CharGetDatum(constraintType);
|
|
|
|
values[Anum_pg_constraint_condeferrable - 1] = BoolGetDatum(isDeferrable);
|
|
|
|
values[Anum_pg_constraint_condeferred - 1] = BoolGetDatum(isDeferred);
|
2011-02-08 13:23:20 +01:00
|
|
|
values[Anum_pg_constraint_convalidated - 1] = BoolGetDatum(isValidated);
|
2002-07-12 20:43:19 +02:00
|
|
|
values[Anum_pg_constraint_conrelid - 1] = ObjectIdGetDatum(relId);
|
|
|
|
values[Anum_pg_constraint_contypid - 1] = ObjectIdGetDatum(domainId);
|
2009-07-28 04:56:31 +02:00
|
|
|
values[Anum_pg_constraint_conindid - 1] = ObjectIdGetDatum(indexRelId);
|
2018-03-23 14:48:22 +01:00
|
|
|
values[Anum_pg_constraint_conparentid - 1] = ObjectIdGetDatum(parentConstrId);
|
2002-07-12 20:43:19 +02:00
|
|
|
values[Anum_pg_constraint_confrelid - 1] = ObjectIdGetDatum(foreignRelId);
|
|
|
|
values[Anum_pg_constraint_confupdtype - 1] = CharGetDatum(foreignUpdateType);
|
|
|
|
values[Anum_pg_constraint_confdeltype - 1] = CharGetDatum(foreignDeleteType);
|
|
|
|
values[Anum_pg_constraint_confmatchtype - 1] = CharGetDatum(foreignMatchType);
|
2008-05-10 01:32:05 +02:00
|
|
|
values[Anum_pg_constraint_conislocal - 1] = BoolGetDatum(conIsLocal);
|
|
|
|
values[Anum_pg_constraint_coninhcount - 1] = Int32GetDatum(conInhCount);
|
2012-04-21 04:46:20 +02:00
|
|
|
values[Anum_pg_constraint_connoinherit - 1] = BoolGetDatum(conNoInherit);
|
2002-07-12 20:43:19 +02:00
|
|
|
|
|
|
|
if (conkeyArray)
|
|
|
|
values[Anum_pg_constraint_conkey - 1] = PointerGetDatum(conkeyArray);
|
|
|
|
else
|
2008-11-02 02:45:28 +01:00
|
|
|
nulls[Anum_pg_constraint_conkey - 1] = true;
|
2002-07-12 20:43:19 +02:00
|
|
|
|
|
|
|
if (confkeyArray)
|
|
|
|
values[Anum_pg_constraint_confkey - 1] = PointerGetDatum(confkeyArray);
|
|
|
|
else
|
2008-11-02 02:45:28 +01:00
|
|
|
nulls[Anum_pg_constraint_confkey - 1] = true;
|
2002-07-12 20:43:19 +02:00
|
|
|
|
2007-02-14 02:58:58 +01:00
|
|
|
if (conpfeqopArray)
|
|
|
|
values[Anum_pg_constraint_conpfeqop - 1] = PointerGetDatum(conpfeqopArray);
|
|
|
|
else
|
2008-11-02 02:45:28 +01:00
|
|
|
nulls[Anum_pg_constraint_conpfeqop - 1] = true;
|
2007-02-14 02:58:58 +01:00
|
|
|
|
|
|
|
if (conppeqopArray)
|
|
|
|
values[Anum_pg_constraint_conppeqop - 1] = PointerGetDatum(conppeqopArray);
|
|
|
|
else
|
2008-11-02 02:45:28 +01:00
|
|
|
nulls[Anum_pg_constraint_conppeqop - 1] = true;
|
2007-02-14 02:58:58 +01:00
|
|
|
|
|
|
|
if (conffeqopArray)
|
|
|
|
values[Anum_pg_constraint_conffeqop - 1] = PointerGetDatum(conffeqopArray);
|
|
|
|
else
|
2008-11-02 02:45:28 +01:00
|
|
|
nulls[Anum_pg_constraint_conffeqop - 1] = true;
|
2007-02-14 02:58:58 +01:00
|
|
|
|
2009-12-07 06:22:23 +01:00
|
|
|
if (conexclopArray)
|
|
|
|
values[Anum_pg_constraint_conexclop - 1] = PointerGetDatum(conexclopArray);
|
|
|
|
else
|
|
|
|
nulls[Anum_pg_constraint_conexclop - 1] = true;
|
|
|
|
|
2002-07-12 20:43:19 +02:00
|
|
|
/*
|
|
|
|
* initialize the binary form of the check constraint.
|
|
|
|
*/
|
|
|
|
if (conBin)
|
2008-03-25 23:42:46 +01:00
|
|
|
values[Anum_pg_constraint_conbin - 1] = CStringGetTextDatum(conBin);
|
2002-07-12 20:43:19 +02:00
|
|
|
else
|
2008-11-02 02:45:28 +01:00
|
|
|
nulls[Anum_pg_constraint_conbin - 1] = true;
|
2002-07-12 20:43:19 +02:00
|
|
|
|
|
|
|
/*
|
|
|
|
* initialize the text form of the check constraint
|
|
|
|
*/
|
|
|
|
if (conSrc)
|
2008-03-25 23:42:46 +01:00
|
|
|
values[Anum_pg_constraint_consrc - 1] = CStringGetTextDatum(conSrc);
|
2002-07-12 20:43:19 +02:00
|
|
|
else
|
2008-11-02 02:45:28 +01:00
|
|
|
nulls[Anum_pg_constraint_consrc - 1] = true;
|
2002-07-12 20:43:19 +02:00
|
|
|
|
2008-11-02 02:45:28 +01:00
|
|
|
tup = heap_form_tuple(RelationGetDescr(conDesc), values, nulls);
|
2002-07-12 20:43:19 +02:00
|
|
|
|
2017-01-31 22:42:24 +01:00
|
|
|
conOid = CatalogTupleInsert(conDesc, tup);
|
2002-07-12 20:43:19 +02:00
|
|
|
|
2005-04-14 22:03:27 +02:00
|
|
|
conobject.classId = ConstraintRelationId;
|
2002-07-12 20:43:19 +02:00
|
|
|
conobject.objectId = conOid;
|
|
|
|
conobject.objectSubId = 0;
|
|
|
|
|
|
|
|
heap_close(conDesc, RowExclusiveLock);
|
|
|
|
|
|
|
|
if (OidIsValid(relId))
|
|
|
|
{
|
|
|
|
/*
|
2005-10-15 04:49:52 +02:00
|
|
|
* Register auto dependency from constraint to owning relation, or to
|
|
|
|
* specific column(s) if any are mentioned.
|
2002-07-12 20:43:19 +02:00
|
|
|
*/
|
2002-09-04 22:31:48 +02:00
|
|
|
ObjectAddress relobject;
|
2002-07-12 20:43:19 +02:00
|
|
|
|
2005-04-14 03:38:22 +02:00
|
|
|
relobject.classId = RelationRelationId;
|
2002-07-12 20:43:19 +02:00
|
|
|
relobject.objectId = relId;
|
2018-04-07 22:00:39 +02:00
|
|
|
if (constraintNTotalKeys > 0)
|
2002-07-12 20:43:19 +02:00
|
|
|
{
|
2018-04-07 22:00:39 +02:00
|
|
|
for (i = 0; i < constraintNTotalKeys; i++)
|
2002-07-12 20:43:19 +02:00
|
|
|
{
|
|
|
|
relobject.objectSubId = constraintKey[i];
|
|
|
|
|
|
|
|
recordDependencyOn(&conobject, &relobject, DEPENDENCY_AUTO);
|
|
|
|
}
|
|
|
|
}
|
|
|
|
else
|
|
|
|
{
|
|
|
|
relobject.objectSubId = 0;
|
|
|
|
|
|
|
|
recordDependencyOn(&conobject, &relobject, DEPENDENCY_AUTO);
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2002-11-15 03:50:21 +01:00
|
|
|
if (OidIsValid(domainId))
|
|
|
|
{
|
|
|
|
/*
|
|
|
|
* Register auto dependency from constraint to owning domain
|
|
|
|
*/
|
2003-08-04 02:43:34 +02:00
|
|
|
ObjectAddress domobject;
|
2002-11-15 03:50:21 +01:00
|
|
|
|
2005-04-14 03:38:22 +02:00
|
|
|
domobject.classId = TypeRelationId;
|
2002-11-15 03:50:21 +01:00
|
|
|
domobject.objectId = domainId;
|
2002-12-06 06:00:34 +01:00
|
|
|
domobject.objectSubId = 0;
|
2002-11-15 03:50:21 +01:00
|
|
|
|
|
|
|
recordDependencyOn(&conobject, &domobject, DEPENDENCY_AUTO);
|
|
|
|
}
|
|
|
|
|
2002-07-12 20:43:19 +02:00
|
|
|
if (OidIsValid(foreignRelId))
|
|
|
|
{
|
|
|
|
/*
|
2005-10-15 04:49:52 +02:00
|
|
|
* Register normal dependency from constraint to foreign relation, or
|
|
|
|
* to specific column(s) if any are mentioned.
|
2002-07-12 20:43:19 +02:00
|
|
|
*/
|
2002-09-04 22:31:48 +02:00
|
|
|
ObjectAddress relobject;
|
2002-07-12 20:43:19 +02:00
|
|
|
|
2005-04-14 03:38:22 +02:00
|
|
|
relobject.classId = RelationRelationId;
|
2002-07-12 20:43:19 +02:00
|
|
|
relobject.objectId = foreignRelId;
|
|
|
|
if (foreignNKeys > 0)
|
|
|
|
{
|
|
|
|
for (i = 0; i < foreignNKeys; i++)
|
|
|
|
{
|
|
|
|
relobject.objectSubId = foreignKey[i];
|
|
|
|
|
2002-07-17 00:12:20 +02:00
|
|
|
recordDependencyOn(&conobject, &relobject, DEPENDENCY_NORMAL);
|
2002-07-12 20:43:19 +02:00
|
|
|
}
|
|
|
|
}
|
|
|
|
else
|
|
|
|
{
|
|
|
|
relobject.objectSubId = 0;
|
|
|
|
|
2002-07-17 00:12:20 +02:00
|
|
|
recordDependencyOn(&conobject, &relobject, DEPENDENCY_NORMAL);
|
2002-07-12 20:43:19 +02:00
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2009-07-28 04:56:31 +02:00
|
|
|
if (OidIsValid(indexRelId) && constraintType == CONSTRAINT_FOREIGN)
|
2002-09-22 02:37:09 +02:00
|
|
|
{
|
|
|
|
/*
|
2003-08-04 02:43:34 +02:00
|
|
|
* Register normal dependency on the unique index that supports a
|
2014-05-06 18:12:18 +02:00
|
|
|
* foreign-key constraint. (Note: for indexes associated with unique
|
2010-02-26 03:01:40 +01:00
|
|
|
* or primary-key constraints, the dependency runs the other way, and
|
|
|
|
* is not made here.)
|
2002-09-22 02:37:09 +02:00
|
|
|
*/
|
|
|
|
ObjectAddress relobject;
|
|
|
|
|
2005-04-14 03:38:22 +02:00
|
|
|
relobject.classId = RelationRelationId;
|
2002-09-22 02:37:09 +02:00
|
|
|
relobject.objectId = indexRelId;
|
|
|
|
relobject.objectSubId = 0;
|
|
|
|
|
|
|
|
recordDependencyOn(&conobject, &relobject, DEPENDENCY_NORMAL);
|
|
|
|
}
|
|
|
|
|
2007-02-14 02:58:58 +01:00
|
|
|
if (foreignNKeys > 0)
|
|
|
|
{
|
|
|
|
/*
|
2007-11-15 22:14:46 +01:00
|
|
|
* Register normal dependencies on the equality operators that support
|
|
|
|
* a foreign-key constraint. If the PK and FK types are the same then
|
|
|
|
* all three operators for a column are the same; otherwise they are
|
|
|
|
* different.
|
2007-02-14 02:58:58 +01:00
|
|
|
*/
|
|
|
|
ObjectAddress oprobject;
|
|
|
|
|
|
|
|
oprobject.classId = OperatorRelationId;
|
|
|
|
oprobject.objectSubId = 0;
|
|
|
|
|
|
|
|
for (i = 0; i < foreignNKeys; i++)
|
|
|
|
{
|
|
|
|
oprobject.objectId = pfEqOp[i];
|
|
|
|
recordDependencyOn(&conobject, &oprobject, DEPENDENCY_NORMAL);
|
|
|
|
if (ppEqOp[i] != pfEqOp[i])
|
|
|
|
{
|
|
|
|
oprobject.objectId = ppEqOp[i];
|
|
|
|
recordDependencyOn(&conobject, &oprobject, DEPENDENCY_NORMAL);
|
|
|
|
}
|
|
|
|
if (ffEqOp[i] != pfEqOp[i])
|
|
|
|
{
|
|
|
|
oprobject.objectId = ffEqOp[i];
|
|
|
|
recordDependencyOn(&conobject, &oprobject, DEPENDENCY_NORMAL);
|
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2009-12-07 06:22:23 +01:00
|
|
|
/*
|
2010-02-26 03:01:40 +01:00
|
|
|
* We don't bother to register dependencies on the exclusion operators of
|
|
|
|
* an exclusion constraint. We assume they are members of the opclass
|
|
|
|
* supporting the index, so there's an indirect dependency via that. (This
|
|
|
|
* would be pretty dicey for cross-type operators, but exclusion operators
|
|
|
|
* can never be cross-type.)
|
2009-12-07 06:22:23 +01:00
|
|
|
*/
|
|
|
|
|
2002-07-16 07:53:34 +02:00
|
|
|
if (conExpr != NULL)
|
|
|
|
{
|
|
|
|
/*
|
2005-10-15 04:49:52 +02:00
|
|
|
* Register dependencies from constraint to objects mentioned in CHECK
|
|
|
|
* expression.
|
2002-07-16 07:53:34 +02:00
|
|
|
*/
|
2003-05-28 18:04:02 +02:00
|
|
|
recordDependencyOnSingleRelExpr(&conobject, conExpr, relId,
|
|
|
|
DEPENDENCY_NORMAL,
|
Implement table partitioning.
Table partitioning is like table inheritance and reuses much of the
existing infrastructure, but there are some important differences.
The parent is called a partitioned table and is always empty; it may
not have indexes or non-inherited constraints, since those make no
sense for a relation with no data of its own. The children are called
partitions and contain all of the actual data. Each partition has an
implicit partitioning constraint. Multiple inheritance is not
allowed, and partitioning and inheritance can't be mixed. Partitions
can't have extra columns and may not allow nulls unless the parent
does. Tuples inserted into the parent are automatically routed to the
correct partition, so tuple-routing ON INSERT triggers are not needed.
Tuple routing isn't yet supported for partitions which are foreign
tables, and it doesn't handle updates that cross partition boundaries.
Currently, tables can be range-partitioned or list-partitioned. List
partitioning is limited to a single column, but range partitioning can
involve multiple columns. A partitioning "column" can be an
expression.
Because table partitioning is less general than table inheritance, it
is hoped that it will be easier to reason about properties of
partitions, and therefore that this will serve as a better foundation
for a variety of possible optimizations, including query planner
optimizations. The tuple routing based which this patch does based on
the implicit partitioning constraints is an example of this, but it
seems likely that many other useful optimizations are also possible.
Amit Langote, reviewed and tested by Robert Haas, Ashutosh Bapat,
Amit Kapila, Rajkumar Raghuwanshi, Corey Huinker, Jaime Casanova,
Rushabh Lathia, Erik Rijkers, among others. Minor revisions by me.
2016-12-07 19:17:43 +01:00
|
|
|
DEPENDENCY_NORMAL, false);
|
2002-07-16 07:53:34 +02:00
|
|
|
}
|
|
|
|
|
2010-11-25 17:48:49 +01:00
|
|
|
/* Post creation hook for new constraint */
|
2013-03-18 03:55:14 +01:00
|
|
|
InvokeObjectPostCreateHookArg(ConstraintRelationId, conOid, 0,
|
|
|
|
is_internal);
|
2010-11-25 17:48:49 +01:00
|
|
|
|
2002-07-12 20:43:19 +02:00
|
|
|
return conOid;
|
|
|
|
}
|
|
|
|
|
2018-04-04 19:02:31 +02:00
|
|
|
/*
|
|
|
|
* CloneForeignKeyConstraints
|
|
|
|
* Clone foreign keys from a partitioned table to a newly acquired
|
|
|
|
* partition.
|
|
|
|
*
|
|
|
|
* relationId is a partition of parentId, so we can be certain that it has the
|
|
|
|
* same columns with the same datatypes. The columns may be in different
|
|
|
|
* order, though.
|
|
|
|
*
|
|
|
|
* The *cloned list is appended ClonedConstraint elements describing what was
|
|
|
|
* created.
|
|
|
|
*/
|
|
|
|
void
|
|
|
|
CloneForeignKeyConstraints(Oid parentId, Oid relationId, List **cloned)
|
|
|
|
{
|
|
|
|
Relation pg_constraint;
|
|
|
|
Relation parentRel;
|
|
|
|
Relation rel;
|
2018-04-26 20:47:16 +02:00
|
|
|
ScanKeyData key;
|
|
|
|
SysScanDesc scan;
|
2018-04-04 19:02:31 +02:00
|
|
|
TupleDesc tupdesc;
|
|
|
|
HeapTuple tuple;
|
|
|
|
AttrNumber *attmap;
|
|
|
|
|
|
|
|
parentRel = heap_open(parentId, NoLock); /* already got lock */
|
|
|
|
/* see ATAddForeignKeyConstraint about lock level */
|
|
|
|
rel = heap_open(relationId, AccessExclusiveLock);
|
|
|
|
|
|
|
|
pg_constraint = heap_open(ConstraintRelationId, RowShareLock);
|
|
|
|
tupdesc = RelationGetDescr(pg_constraint);
|
|
|
|
|
|
|
|
/*
|
|
|
|
* The constraint key may differ, if the columns in the partition are
|
|
|
|
* different. This map is used to convert them.
|
|
|
|
*/
|
|
|
|
attmap = convert_tuples_by_name_map(RelationGetDescr(rel),
|
|
|
|
RelationGetDescr(parentRel),
|
|
|
|
gettext_noop("could not convert row type"));
|
|
|
|
|
|
|
|
ScanKeyInit(&key,
|
|
|
|
Anum_pg_constraint_conrelid, BTEqualStrategyNumber,
|
|
|
|
F_OIDEQ, ObjectIdGetDatum(parentId));
|
Fully enforce uniqueness of constraint names.
It's been true for a long time that we expect names of table and domain
constraints to be unique among the constraints of that table or domain.
However, the enforcement of that has been pretty haphazard, and it missed
some corner cases such as creating a CHECK constraint and then an index
constraint of the same name (as per recent report from André Hänsel).
Also, due to the lack of an actual unique index enforcing this, duplicates
could be created through race conditions.
Moreover, the code that searches pg_constraint has been quite inconsistent
about how to handle duplicate names if one did occur: some places checked
and threw errors if there was more than one match, while others just
processed the first match they came to.
To fix, create a unique index on (conrelid, contypid, conname). Since
either conrelid or contypid is zero, this will separately enforce
uniqueness of constraint names among constraints of any one table and any
one domain. (If we ever implement SQL assertions, and put them into this
catalog, more thought might be needed. But it'd be at least as reasonable
to put them into a new catalog; having overloaded this one catalog with
two kinds of constraints was a mistake already IMO.) This index can replace
the existing non-unique index on conrelid, though we need to keep the one
on contypid for query performance reasons.
Having done that, we can simplify the logic in various places that either
coped with duplicates or neglected to, as well as potentially improve
lookup performance when searching for a constraint by name.
Also, as per our usual practice, install a preliminary check so that you
get something more friendly than a unique-index violation report in the
case complained of by André. And teach ChooseIndexName to avoid choosing
autogenerated names that would draw such a failure.
While it's not possible to make such a change in the back branches,
it doesn't seem quite too late to put this into v11, so do so.
Discussion: https://postgr.es/m/0c1001d4428f$0942b430$1bc81c90$@webkr.de
2018-09-04 19:45:35 +02:00
|
|
|
scan = systable_beginscan(pg_constraint, ConstraintRelidTypidNameIndexId, true,
|
2018-04-04 19:02:31 +02:00
|
|
|
NULL, 1, &key);
|
|
|
|
|
|
|
|
while ((tuple = systable_getnext(scan)) != NULL)
|
|
|
|
{
|
2018-04-26 20:47:16 +02:00
|
|
|
Form_pg_constraint constrForm = (Form_pg_constraint) GETSTRUCT(tuple);
|
2018-04-04 19:02:31 +02:00
|
|
|
AttrNumber conkey[INDEX_MAX_KEYS];
|
|
|
|
AttrNumber mapped_conkey[INDEX_MAX_KEYS];
|
|
|
|
AttrNumber confkey[INDEX_MAX_KEYS];
|
|
|
|
Oid conpfeqop[INDEX_MAX_KEYS];
|
|
|
|
Oid conppeqop[INDEX_MAX_KEYS];
|
|
|
|
Oid conffeqop[INDEX_MAX_KEYS];
|
|
|
|
Constraint *fkconstraint;
|
|
|
|
ClonedConstraint *newc;
|
|
|
|
Oid constrOid;
|
|
|
|
ObjectAddress parentAddr,
|
|
|
|
childAddr;
|
|
|
|
int nelem;
|
|
|
|
int i;
|
|
|
|
ArrayType *arr;
|
|
|
|
Datum datum;
|
|
|
|
bool isnull;
|
|
|
|
|
|
|
|
/* only foreign keys */
|
|
|
|
if (constrForm->contype != CONSTRAINT_FOREIGN)
|
|
|
|
continue;
|
|
|
|
|
|
|
|
ObjectAddressSet(parentAddr, ConstraintRelationId,
|
|
|
|
HeapTupleGetOid(tuple));
|
|
|
|
|
|
|
|
datum = fastgetattr(tuple, Anum_pg_constraint_conkey,
|
|
|
|
tupdesc, &isnull);
|
|
|
|
if (isnull)
|
|
|
|
elog(ERROR, "null conkey");
|
|
|
|
arr = DatumGetArrayTypeP(datum);
|
|
|
|
nelem = ARR_DIMS(arr)[0];
|
|
|
|
if (ARR_NDIM(arr) != 1 ||
|
|
|
|
nelem < 1 ||
|
|
|
|
nelem > INDEX_MAX_KEYS ||
|
|
|
|
ARR_HASNULL(arr) ||
|
|
|
|
ARR_ELEMTYPE(arr) != INT2OID)
|
|
|
|
elog(ERROR, "conkey is not a 1-D smallint array");
|
|
|
|
memcpy(conkey, ARR_DATA_PTR(arr), nelem * sizeof(AttrNumber));
|
|
|
|
|
|
|
|
for (i = 0; i < nelem; i++)
|
|
|
|
mapped_conkey[i] = attmap[conkey[i] - 1];
|
|
|
|
|
|
|
|
datum = fastgetattr(tuple, Anum_pg_constraint_confkey,
|
|
|
|
tupdesc, &isnull);
|
|
|
|
if (isnull)
|
|
|
|
elog(ERROR, "null confkey");
|
|
|
|
arr = DatumGetArrayTypeP(datum);
|
|
|
|
nelem = ARR_DIMS(arr)[0];
|
|
|
|
if (ARR_NDIM(arr) != 1 ||
|
|
|
|
nelem < 1 ||
|
|
|
|
nelem > INDEX_MAX_KEYS ||
|
|
|
|
ARR_HASNULL(arr) ||
|
|
|
|
ARR_ELEMTYPE(arr) != INT2OID)
|
|
|
|
elog(ERROR, "confkey is not a 1-D smallint array");
|
|
|
|
memcpy(confkey, ARR_DATA_PTR(arr), nelem * sizeof(AttrNumber));
|
|
|
|
|
|
|
|
datum = fastgetattr(tuple, Anum_pg_constraint_conpfeqop,
|
|
|
|
tupdesc, &isnull);
|
|
|
|
if (isnull)
|
|
|
|
elog(ERROR, "null conpfeqop");
|
|
|
|
arr = DatumGetArrayTypeP(datum);
|
|
|
|
nelem = ARR_DIMS(arr)[0];
|
|
|
|
if (ARR_NDIM(arr) != 1 ||
|
|
|
|
nelem < 1 ||
|
|
|
|
nelem > INDEX_MAX_KEYS ||
|
|
|
|
ARR_HASNULL(arr) ||
|
|
|
|
ARR_ELEMTYPE(arr) != OIDOID)
|
|
|
|
elog(ERROR, "conpfeqop is not a 1-D OID array");
|
|
|
|
memcpy(conpfeqop, ARR_DATA_PTR(arr), nelem * sizeof(Oid));
|
|
|
|
|
|
|
|
datum = fastgetattr(tuple, Anum_pg_constraint_conpfeqop,
|
|
|
|
tupdesc, &isnull);
|
|
|
|
if (isnull)
|
|
|
|
elog(ERROR, "null conpfeqop");
|
|
|
|
arr = DatumGetArrayTypeP(datum);
|
|
|
|
nelem = ARR_DIMS(arr)[0];
|
|
|
|
if (ARR_NDIM(arr) != 1 ||
|
|
|
|
nelem < 1 ||
|
|
|
|
nelem > INDEX_MAX_KEYS ||
|
|
|
|
ARR_HASNULL(arr) ||
|
|
|
|
ARR_ELEMTYPE(arr) != OIDOID)
|
|
|
|
elog(ERROR, "conpfeqop is not a 1-D OID array");
|
|
|
|
memcpy(conpfeqop, ARR_DATA_PTR(arr), nelem * sizeof(Oid));
|
|
|
|
|
|
|
|
datum = fastgetattr(tuple, Anum_pg_constraint_conppeqop,
|
|
|
|
tupdesc, &isnull);
|
|
|
|
if (isnull)
|
|
|
|
elog(ERROR, "null conppeqop");
|
|
|
|
arr = DatumGetArrayTypeP(datum);
|
|
|
|
nelem = ARR_DIMS(arr)[0];
|
|
|
|
if (ARR_NDIM(arr) != 1 ||
|
|
|
|
nelem < 1 ||
|
|
|
|
nelem > INDEX_MAX_KEYS ||
|
|
|
|
ARR_HASNULL(arr) ||
|
|
|
|
ARR_ELEMTYPE(arr) != OIDOID)
|
|
|
|
elog(ERROR, "conppeqop is not a 1-D OID array");
|
|
|
|
memcpy(conppeqop, ARR_DATA_PTR(arr), nelem * sizeof(Oid));
|
|
|
|
|
|
|
|
datum = fastgetattr(tuple, Anum_pg_constraint_conffeqop,
|
|
|
|
tupdesc, &isnull);
|
|
|
|
if (isnull)
|
|
|
|
elog(ERROR, "null conffeqop");
|
|
|
|
arr = DatumGetArrayTypeP(datum);
|
|
|
|
nelem = ARR_DIMS(arr)[0];
|
|
|
|
if (ARR_NDIM(arr) != 1 ||
|
|
|
|
nelem < 1 ||
|
|
|
|
nelem > INDEX_MAX_KEYS ||
|
|
|
|
ARR_HASNULL(arr) ||
|
|
|
|
ARR_ELEMTYPE(arr) != OIDOID)
|
|
|
|
elog(ERROR, "conffeqop is not a 1-D OID array");
|
|
|
|
memcpy(conffeqop, ARR_DATA_PTR(arr), nelem * sizeof(Oid));
|
|
|
|
|
|
|
|
constrOid =
|
|
|
|
CreateConstraintEntry(NameStr(constrForm->conname),
|
|
|
|
constrForm->connamespace,
|
|
|
|
CONSTRAINT_FOREIGN,
|
|
|
|
constrForm->condeferrable,
|
|
|
|
constrForm->condeferred,
|
|
|
|
constrForm->convalidated,
|
|
|
|
HeapTupleGetOid(tuple),
|
|
|
|
relationId,
|
|
|
|
mapped_conkey,
|
|
|
|
nelem,
|
2018-04-07 22:00:39 +02:00
|
|
|
nelem,
|
2018-04-04 19:02:31 +02:00
|
|
|
InvalidOid, /* not a domain constraint */
|
2018-04-26 20:47:16 +02:00
|
|
|
constrForm->conindid, /* same index */
|
|
|
|
constrForm->confrelid, /* same foreign rel */
|
2018-04-04 19:02:31 +02:00
|
|
|
confkey,
|
|
|
|
conpfeqop,
|
|
|
|
conppeqop,
|
|
|
|
conffeqop,
|
|
|
|
nelem,
|
|
|
|
constrForm->confupdtype,
|
|
|
|
constrForm->confdeltype,
|
|
|
|
constrForm->confmatchtype,
|
|
|
|
NULL,
|
|
|
|
NULL,
|
|
|
|
NULL,
|
|
|
|
NULL,
|
|
|
|
false,
|
|
|
|
1, false, true);
|
|
|
|
|
|
|
|
ObjectAddressSet(childAddr, ConstraintRelationId, constrOid);
|
|
|
|
recordDependencyOn(&childAddr, &parentAddr, DEPENDENCY_INTERNAL_AUTO);
|
|
|
|
|
|
|
|
fkconstraint = makeNode(Constraint);
|
|
|
|
/* for now this is all we need */
|
2018-10-06 07:59:36 +02:00
|
|
|
fkconstraint->conname = pstrdup(NameStr(constrForm->conname));
|
2018-04-04 19:02:31 +02:00
|
|
|
fkconstraint->fk_upd_action = constrForm->confupdtype;
|
|
|
|
fkconstraint->fk_del_action = constrForm->confdeltype;
|
|
|
|
fkconstraint->deferrable = constrForm->condeferrable;
|
|
|
|
fkconstraint->initdeferred = constrForm->condeferred;
|
|
|
|
|
|
|
|
createForeignKeyTriggers(rel, constrForm->confrelid, fkconstraint,
|
|
|
|
constrOid, constrForm->conindid, false);
|
|
|
|
|
|
|
|
if (cloned)
|
|
|
|
{
|
|
|
|
/*
|
2018-04-26 20:47:16 +02:00
|
|
|
* Feed back caller about the constraints we created, so that they
|
|
|
|
* can set up constraint verification.
|
2018-04-04 19:02:31 +02:00
|
|
|
*/
|
|
|
|
newc = palloc(sizeof(ClonedConstraint));
|
|
|
|
newc->relid = relationId;
|
|
|
|
newc->refrelid = constrForm->confrelid;
|
|
|
|
newc->conindid = constrForm->conindid;
|
|
|
|
newc->conid = constrOid;
|
|
|
|
newc->constraint = fkconstraint;
|
|
|
|
|
|
|
|
*cloned = lappend(*cloned, newc);
|
|
|
|
}
|
|
|
|
}
|
|
|
|
systable_endscan(scan);
|
|
|
|
|
|
|
|
pfree(attmap);
|
|
|
|
|
|
|
|
if (rel->rd_rel->relkind == RELKIND_PARTITIONED_TABLE)
|
|
|
|
{
|
2018-04-26 20:47:16 +02:00
|
|
|
PartitionDesc partdesc = RelationGetPartitionDesc(rel);
|
2018-04-04 19:02:31 +02:00
|
|
|
int i;
|
|
|
|
|
|
|
|
for (i = 0; i < partdesc->nparts; i++)
|
|
|
|
CloneForeignKeyConstraints(RelationGetRelid(rel),
|
|
|
|
partdesc->oids[i],
|
|
|
|
cloned);
|
|
|
|
}
|
|
|
|
|
2018-04-26 20:47:16 +02:00
|
|
|
heap_close(rel, NoLock); /* keep lock till commit */
|
2018-04-04 19:02:31 +02:00
|
|
|
heap_close(parentRel, NoLock);
|
|
|
|
heap_close(pg_constraint, RowShareLock);
|
|
|
|
}
|
2002-07-12 20:43:19 +02:00
|
|
|
|
|
|
|
/*
|
|
|
|
* Test whether given name is currently used as a constraint name
|
2004-06-10 19:56:03 +02:00
|
|
|
* for the given object (relation or domain).
|
2002-07-12 20:43:19 +02:00
|
|
|
*
|
2004-06-10 19:56:03 +02:00
|
|
|
* This is used to decide whether to accept a user-specified constraint name.
|
|
|
|
* It is deliberately not the same test as ChooseConstraintName uses to decide
|
|
|
|
* whether an auto-generated name is OK: here, we will allow it unless there
|
|
|
|
* is an identical constraint name in use *on the same object*.
|
|
|
|
*
|
|
|
|
* NB: Caller should hold exclusive lock on the given object, else
|
|
|
|
* this test can be fooled by concurrent additions.
|
2002-07-12 20:43:19 +02:00
|
|
|
*/
|
|
|
|
bool
|
2004-06-10 19:56:03 +02:00
|
|
|
ConstraintNameIsUsed(ConstraintCategory conCat, Oid objId,
|
Fully enforce uniqueness of constraint names.
It's been true for a long time that we expect names of table and domain
constraints to be unique among the constraints of that table or domain.
However, the enforcement of that has been pretty haphazard, and it missed
some corner cases such as creating a CHECK constraint and then an index
constraint of the same name (as per recent report from André Hänsel).
Also, due to the lack of an actual unique index enforcing this, duplicates
could be created through race conditions.
Moreover, the code that searches pg_constraint has been quite inconsistent
about how to handle duplicate names if one did occur: some places checked
and threw errors if there was more than one match, while others just
processed the first match they came to.
To fix, create a unique index on (conrelid, contypid, conname). Since
either conrelid or contypid is zero, this will separately enforce
uniqueness of constraint names among constraints of any one table and any
one domain. (If we ever implement SQL assertions, and put them into this
catalog, more thought might be needed. But it'd be at least as reasonable
to put them into a new catalog; having overloaded this one catalog with
two kinds of constraints was a mistake already IMO.) This index can replace
the existing non-unique index on conrelid, though we need to keep the one
on contypid for query performance reasons.
Having done that, we can simplify the logic in various places that either
coped with duplicates or neglected to, as well as potentially improve
lookup performance when searching for a constraint by name.
Also, as per our usual practice, install a preliminary check so that you
get something more friendly than a unique-index violation report in the
case complained of by André. And teach ChooseIndexName to avoid choosing
autogenerated names that would draw such a failure.
While it's not possible to make such a change in the back branches,
it doesn't seem quite too late to put this into v11, so do so.
Discussion: https://postgr.es/m/0c1001d4428f$0942b430$1bc81c90$@webkr.de
2018-09-04 19:45:35 +02:00
|
|
|
const char *conname)
|
2002-07-12 20:43:19 +02:00
|
|
|
{
|
|
|
|
bool found;
|
|
|
|
Relation conDesc;
|
|
|
|
SysScanDesc conscan;
|
Fully enforce uniqueness of constraint names.
It's been true for a long time that we expect names of table and domain
constraints to be unique among the constraints of that table or domain.
However, the enforcement of that has been pretty haphazard, and it missed
some corner cases such as creating a CHECK constraint and then an index
constraint of the same name (as per recent report from André Hänsel).
Also, due to the lack of an actual unique index enforcing this, duplicates
could be created through race conditions.
Moreover, the code that searches pg_constraint has been quite inconsistent
about how to handle duplicate names if one did occur: some places checked
and threw errors if there was more than one match, while others just
processed the first match they came to.
To fix, create a unique index on (conrelid, contypid, conname). Since
either conrelid or contypid is zero, this will separately enforce
uniqueness of constraint names among constraints of any one table and any
one domain. (If we ever implement SQL assertions, and put them into this
catalog, more thought might be needed. But it'd be at least as reasonable
to put them into a new catalog; having overloaded this one catalog with
two kinds of constraints was a mistake already IMO.) This index can replace
the existing non-unique index on conrelid, though we need to keep the one
on contypid for query performance reasons.
Having done that, we can simplify the logic in various places that either
coped with duplicates or neglected to, as well as potentially improve
lookup performance when searching for a constraint by name.
Also, as per our usual practice, install a preliminary check so that you
get something more friendly than a unique-index violation report in the
case complained of by André. And teach ChooseIndexName to avoid choosing
autogenerated names that would draw such a failure.
While it's not possible to make such a change in the back branches,
it doesn't seem quite too late to put this into v11, so do so.
Discussion: https://postgr.es/m/0c1001d4428f$0942b430$1bc81c90$@webkr.de
2018-09-04 19:45:35 +02:00
|
|
|
ScanKeyData skey[3];
|
2002-07-12 20:43:19 +02:00
|
|
|
|
2005-04-14 22:03:27 +02:00
|
|
|
conDesc = heap_open(ConstraintRelationId, AccessShareLock);
|
2002-07-12 20:43:19 +02:00
|
|
|
|
Fully enforce uniqueness of constraint names.
It's been true for a long time that we expect names of table and domain
constraints to be unique among the constraints of that table or domain.
However, the enforcement of that has been pretty haphazard, and it missed
some corner cases such as creating a CHECK constraint and then an index
constraint of the same name (as per recent report from André Hänsel).
Also, due to the lack of an actual unique index enforcing this, duplicates
could be created through race conditions.
Moreover, the code that searches pg_constraint has been quite inconsistent
about how to handle duplicate names if one did occur: some places checked
and threw errors if there was more than one match, while others just
processed the first match they came to.
To fix, create a unique index on (conrelid, contypid, conname). Since
either conrelid or contypid is zero, this will separately enforce
uniqueness of constraint names among constraints of any one table and any
one domain. (If we ever implement SQL assertions, and put them into this
catalog, more thought might be needed. But it'd be at least as reasonable
to put them into a new catalog; having overloaded this one catalog with
two kinds of constraints was a mistake already IMO.) This index can replace
the existing non-unique index on conrelid, though we need to keep the one
on contypid for query performance reasons.
Having done that, we can simplify the logic in various places that either
coped with duplicates or neglected to, as well as potentially improve
lookup performance when searching for a constraint by name.
Also, as per our usual practice, install a preliminary check so that you
get something more friendly than a unique-index violation report in the
case complained of by André. And teach ChooseIndexName to avoid choosing
autogenerated names that would draw such a failure.
While it's not possible to make such a change in the back branches,
it doesn't seem quite too late to put this into v11, so do so.
Discussion: https://postgr.es/m/0c1001d4428f$0942b430$1bc81c90$@webkr.de
2018-09-04 19:45:35 +02:00
|
|
|
ScanKeyInit(&skey[0],
|
|
|
|
Anum_pg_constraint_conrelid,
|
|
|
|
BTEqualStrategyNumber, F_OIDEQ,
|
|
|
|
ObjectIdGetDatum((conCat == CONSTRAINT_RELATION)
|
|
|
|
? objId : InvalidOid));
|
|
|
|
ScanKeyInit(&skey[1],
|
|
|
|
Anum_pg_constraint_contypid,
|
|
|
|
BTEqualStrategyNumber, F_OIDEQ,
|
|
|
|
ObjectIdGetDatum((conCat == CONSTRAINT_DOMAIN)
|
|
|
|
? objId : InvalidOid));
|
|
|
|
ScanKeyInit(&skey[2],
|
|
|
|
Anum_pg_constraint_conname,
|
|
|
|
BTEqualStrategyNumber, F_NAMEEQ,
|
|
|
|
CStringGetDatum(conname));
|
|
|
|
|
|
|
|
conscan = systable_beginscan(conDesc, ConstraintRelidTypidNameIndexId,
|
|
|
|
true, NULL, 3, skey);
|
|
|
|
|
|
|
|
/* There can be at most one matching row */
|
|
|
|
found = (HeapTupleIsValid(systable_getnext(conscan)));
|
|
|
|
|
|
|
|
systable_endscan(conscan);
|
|
|
|
heap_close(conDesc, AccessShareLock);
|
|
|
|
|
|
|
|
return found;
|
|
|
|
}
|
|
|
|
|
|
|
|
/*
|
|
|
|
* Does any constraint of the given name exist in the given namespace?
|
|
|
|
*
|
|
|
|
* This is used for code that wants to match ChooseConstraintName's rule
|
|
|
|
* that we should avoid autogenerating duplicate constraint names within a
|
|
|
|
* namespace.
|
|
|
|
*/
|
|
|
|
bool
|
|
|
|
ConstraintNameExists(const char *conname, Oid namespaceid)
|
|
|
|
{
|
|
|
|
bool found;
|
|
|
|
Relation conDesc;
|
|
|
|
SysScanDesc conscan;
|
|
|
|
ScanKeyData skey[2];
|
|
|
|
|
|
|
|
conDesc = heap_open(ConstraintRelationId, AccessShareLock);
|
2002-07-12 20:43:19 +02:00
|
|
|
|
2003-11-12 22:15:59 +01:00
|
|
|
ScanKeyInit(&skey[0],
|
|
|
|
Anum_pg_constraint_conname,
|
|
|
|
BTEqualStrategyNumber, F_NAMEEQ,
|
2004-06-10 19:56:03 +02:00
|
|
|
CStringGetDatum(conname));
|
2002-07-12 20:43:19 +02:00
|
|
|
|
2003-11-12 22:15:59 +01:00
|
|
|
ScanKeyInit(&skey[1],
|
|
|
|
Anum_pg_constraint_connamespace,
|
|
|
|
BTEqualStrategyNumber, F_OIDEQ,
|
Fully enforce uniqueness of constraint names.
It's been true for a long time that we expect names of table and domain
constraints to be unique among the constraints of that table or domain.
However, the enforcement of that has been pretty haphazard, and it missed
some corner cases such as creating a CHECK constraint and then an index
constraint of the same name (as per recent report from André Hänsel).
Also, due to the lack of an actual unique index enforcing this, duplicates
could be created through race conditions.
Moreover, the code that searches pg_constraint has been quite inconsistent
about how to handle duplicate names if one did occur: some places checked
and threw errors if there was more than one match, while others just
processed the first match they came to.
To fix, create a unique index on (conrelid, contypid, conname). Since
either conrelid or contypid is zero, this will separately enforce
uniqueness of constraint names among constraints of any one table and any
one domain. (If we ever implement SQL assertions, and put them into this
catalog, more thought might be needed. But it'd be at least as reasonable
to put them into a new catalog; having overloaded this one catalog with
two kinds of constraints was a mistake already IMO.) This index can replace
the existing non-unique index on conrelid, though we need to keep the one
on contypid for query performance reasons.
Having done that, we can simplify the logic in various places that either
coped with duplicates or neglected to, as well as potentially improve
lookup performance when searching for a constraint by name.
Also, as per our usual practice, install a preliminary check so that you
get something more friendly than a unique-index violation report in the
case complained of by André. And teach ChooseIndexName to avoid choosing
autogenerated names that would draw such a failure.
While it's not possible to make such a change in the back branches,
it doesn't seem quite too late to put this into v11, so do so.
Discussion: https://postgr.es/m/0c1001d4428f$0942b430$1bc81c90$@webkr.de
2018-09-04 19:45:35 +02:00
|
|
|
ObjectIdGetDatum(namespaceid));
|
2002-07-12 20:43:19 +02:00
|
|
|
|
2005-04-14 22:03:27 +02:00
|
|
|
conscan = systable_beginscan(conDesc, ConstraintNameNspIndexId, true,
|
Use an MVCC snapshot, rather than SnapshotNow, for catalog scans.
SnapshotNow scans have the undesirable property that, in the face of
concurrent updates, the scan can fail to see either the old or the new
versions of the row. In many cases, we work around this by requiring
DDL operations to hold AccessExclusiveLock on the object being
modified; in some cases, the existing locking is inadequate and random
failures occur as a result. This commit doesn't change anything
related to locking, but will hopefully pave the way to allowing lock
strength reductions in the future.
The major issue has held us back from making this change in the past
is that taking an MVCC snapshot is significantly more expensive than
using a static special snapshot such as SnapshotNow. However, testing
of various worst-case scenarios reveals that this problem is not
severe except under fairly extreme workloads. To mitigate those
problems, we avoid retaking the MVCC snapshot for each new scan;
instead, we take a new snapshot only when invalidation messages have
been processed. The catcache machinery already requires that
invalidation messages be sent before releasing the related heavyweight
lock; else other backends might rely on locally-cached data rather
than scanning the catalog at all. Thus, making snapshot reuse
dependent on the same guarantees shouldn't break anything that wasn't
already subtly broken.
Patch by me. Review by Michael Paquier and Andres Freund.
2013-07-02 15:47:01 +02:00
|
|
|
NULL, 2, skey);
|
2002-07-12 20:43:19 +02:00
|
|
|
|
Fully enforce uniqueness of constraint names.
It's been true for a long time that we expect names of table and domain
constraints to be unique among the constraints of that table or domain.
However, the enforcement of that has been pretty haphazard, and it missed
some corner cases such as creating a CHECK constraint and then an index
constraint of the same name (as per recent report from André Hänsel).
Also, due to the lack of an actual unique index enforcing this, duplicates
could be created through race conditions.
Moreover, the code that searches pg_constraint has been quite inconsistent
about how to handle duplicate names if one did occur: some places checked
and threw errors if there was more than one match, while others just
processed the first match they came to.
To fix, create a unique index on (conrelid, contypid, conname). Since
either conrelid or contypid is zero, this will separately enforce
uniqueness of constraint names among constraints of any one table and any
one domain. (If we ever implement SQL assertions, and put them into this
catalog, more thought might be needed. But it'd be at least as reasonable
to put them into a new catalog; having overloaded this one catalog with
two kinds of constraints was a mistake already IMO.) This index can replace
the existing non-unique index on conrelid, though we need to keep the one
on contypid for query performance reasons.
Having done that, we can simplify the logic in various places that either
coped with duplicates or neglected to, as well as potentially improve
lookup performance when searching for a constraint by name.
Also, as per our usual practice, install a preliminary check so that you
get something more friendly than a unique-index violation report in the
case complained of by André. And teach ChooseIndexName to avoid choosing
autogenerated names that would draw such a failure.
While it's not possible to make such a change in the back branches,
it doesn't seem quite too late to put this into v11, so do so.
Discussion: https://postgr.es/m/0c1001d4428f$0942b430$1bc81c90$@webkr.de
2018-09-04 19:45:35 +02:00
|
|
|
found = (HeapTupleIsValid(systable_getnext(conscan)));
|
2002-07-12 20:43:19 +02:00
|
|
|
|
|
|
|
systable_endscan(conscan);
|
2004-06-10 19:56:03 +02:00
|
|
|
heap_close(conDesc, AccessShareLock);
|
2002-07-12 20:43:19 +02:00
|
|
|
|
|
|
|
return found;
|
|
|
|
}
|
|
|
|
|
|
|
|
/*
|
2004-06-10 19:56:03 +02:00
|
|
|
* Select a nonconflicting name for a new constraint.
|
|
|
|
*
|
|
|
|
* The objective here is to choose a name that is unique within the
|
|
|
|
* specified namespace. Postgres does not require this, but the SQL
|
|
|
|
* spec does, and some apps depend on it. Therefore we avoid choosing
|
|
|
|
* default names that so conflict.
|
|
|
|
*
|
|
|
|
* name1, name2, and label are used the same way as for makeObjectName(),
|
|
|
|
* except that the label can't be NULL; digits will be appended to the label
|
|
|
|
* if needed to create a name that is unique within the specified namespace.
|
2002-07-12 20:43:19 +02:00
|
|
|
*
|
2004-06-10 19:56:03 +02:00
|
|
|
* 'others' can be a list of string names already chosen within the current
|
|
|
|
* command (but not yet reflected into the catalogs); we will not choose
|
|
|
|
* a duplicate of one of these either.
|
2002-07-12 20:43:19 +02:00
|
|
|
*
|
2004-06-10 19:56:03 +02:00
|
|
|
* Note: it is theoretically possible to get a collision anyway, if someone
|
|
|
|
* else chooses the same name concurrently. This is fairly unlikely to be
|
|
|
|
* a problem in practice, especially if one is holding an exclusive lock on
|
|
|
|
* the relation identified by name1.
|
|
|
|
*
|
|
|
|
* Returns a palloc'd string.
|
2002-07-12 20:43:19 +02:00
|
|
|
*/
|
|
|
|
char *
|
2004-06-10 19:56:03 +02:00
|
|
|
ChooseConstraintName(const char *name1, const char *name2,
|
2009-07-16 08:33:46 +02:00
|
|
|
const char *label, Oid namespaceid,
|
2004-06-10 19:56:03 +02:00
|
|
|
List *others)
|
2002-07-12 20:43:19 +02:00
|
|
|
{
|
2004-06-10 19:56:03 +02:00
|
|
|
int pass = 0;
|
|
|
|
char *conname = NULL;
|
|
|
|
char modlabel[NAMEDATALEN];
|
2002-07-12 20:43:19 +02:00
|
|
|
Relation conDesc;
|
2004-06-10 19:56:03 +02:00
|
|
|
SysScanDesc conscan;
|
|
|
|
ScanKeyData skey[2];
|
|
|
|
bool found;
|
|
|
|
ListCell *l;
|
2002-07-12 20:43:19 +02:00
|
|
|
|
2005-04-14 22:03:27 +02:00
|
|
|
conDesc = heap_open(ConstraintRelationId, AccessShareLock);
|
2002-07-12 20:43:19 +02:00
|
|
|
|
2004-06-10 19:56:03 +02:00
|
|
|
/* try the unmodified label first */
|
|
|
|
StrNCpy(modlabel, label, sizeof(modlabel));
|
2002-07-12 20:43:19 +02:00
|
|
|
|
2004-06-10 19:56:03 +02:00
|
|
|
for (;;)
|
2002-07-12 20:43:19 +02:00
|
|
|
{
|
2004-06-10 19:56:03 +02:00
|
|
|
conname = makeObjectName(name1, name2, modlabel);
|
2002-07-12 20:43:19 +02:00
|
|
|
|
|
|
|
found = false;
|
|
|
|
|
2004-06-10 19:56:03 +02:00
|
|
|
foreach(l, others)
|
2002-07-12 20:43:19 +02:00
|
|
|
{
|
2004-06-10 19:56:03 +02:00
|
|
|
if (strcmp((char *) lfirst(l), conname) == 0)
|
2002-07-12 20:43:19 +02:00
|
|
|
{
|
|
|
|
found = true;
|
|
|
|
break;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2004-06-10 19:56:03 +02:00
|
|
|
if (!found)
|
|
|
|
{
|
|
|
|
ScanKeyInit(&skey[0],
|
|
|
|
Anum_pg_constraint_conname,
|
|
|
|
BTEqualStrategyNumber, F_NAMEEQ,
|
|
|
|
CStringGetDatum(conname));
|
2002-07-12 20:43:19 +02:00
|
|
|
|
2004-06-10 19:56:03 +02:00
|
|
|
ScanKeyInit(&skey[1],
|
|
|
|
Anum_pg_constraint_connamespace,
|
|
|
|
BTEqualStrategyNumber, F_OIDEQ,
|
2009-07-16 08:33:46 +02:00
|
|
|
ObjectIdGetDatum(namespaceid));
|
2002-07-12 20:43:19 +02:00
|
|
|
|
2005-04-14 22:03:27 +02:00
|
|
|
conscan = systable_beginscan(conDesc, ConstraintNameNspIndexId, true,
|
Use an MVCC snapshot, rather than SnapshotNow, for catalog scans.
SnapshotNow scans have the undesirable property that, in the face of
concurrent updates, the scan can fail to see either the old or the new
versions of the row. In many cases, we work around this by requiring
DDL operations to hold AccessExclusiveLock on the object being
modified; in some cases, the existing locking is inadequate and random
failures occur as a result. This commit doesn't change anything
related to locking, but will hopefully pave the way to allowing lock
strength reductions in the future.
The major issue has held us back from making this change in the past
is that taking an MVCC snapshot is significantly more expensive than
using a static special snapshot such as SnapshotNow. However, testing
of various worst-case scenarios reveals that this problem is not
severe except under fairly extreme workloads. To mitigate those
problems, we avoid retaking the MVCC snapshot for each new scan;
instead, we take a new snapshot only when invalidation messages have
been processed. The catcache machinery already requires that
invalidation messages be sent before releasing the related heavyweight
lock; else other backends might rely on locally-cached data rather
than scanning the catalog at all. Thus, making snapshot reuse
dependent on the same guarantees shouldn't break anything that wasn't
already subtly broken.
Patch by me. Review by Michael Paquier and Andres Freund.
2013-07-02 15:47:01 +02:00
|
|
|
NULL, 2, skey);
|
2002-07-12 20:43:19 +02:00
|
|
|
|
2004-06-10 19:56:03 +02:00
|
|
|
found = (HeapTupleIsValid(systable_getnext(conscan)));
|
|
|
|
|
|
|
|
systable_endscan(conscan);
|
|
|
|
}
|
|
|
|
|
|
|
|
if (!found)
|
|
|
|
break;
|
|
|
|
|
|
|
|
/* found a conflict, so try a new name component */
|
|
|
|
pfree(conname);
|
|
|
|
snprintf(modlabel, sizeof(modlabel), "%s%d", label, ++pass);
|
|
|
|
}
|
|
|
|
|
|
|
|
heap_close(conDesc, AccessShareLock);
|
|
|
|
|
|
|
|
return conname;
|
2002-07-12 20:43:19 +02:00
|
|
|
}
|
|
|
|
|
|
|
|
/*
|
|
|
|
* Delete a single constraint record.
|
|
|
|
*/
|
|
|
|
void
|
|
|
|
RemoveConstraintById(Oid conId)
|
|
|
|
{
|
2002-09-04 22:31:48 +02:00
|
|
|
Relation conDesc;
|
|
|
|
HeapTuple tup;
|
|
|
|
Form_pg_constraint con;
|
2002-07-12 20:43:19 +02:00
|
|
|
|
2005-04-14 22:03:27 +02:00
|
|
|
conDesc = heap_open(ConstraintRelationId, RowExclusiveLock);
|
2002-07-12 20:43:19 +02:00
|
|
|
|
2010-02-14 19:42:19 +01:00
|
|
|
tup = SearchSysCache1(CONSTROID, ObjectIdGetDatum(conId));
|
2007-02-14 02:58:58 +01:00
|
|
|
if (!HeapTupleIsValid(tup)) /* should not happen */
|
|
|
|
elog(ERROR, "cache lookup failed for constraint %u", conId);
|
2002-07-12 20:43:19 +02:00
|
|
|
con = (Form_pg_constraint) GETSTRUCT(tup);
|
|
|
|
|
|
|
|
/*
|
2002-12-12 21:35:16 +01:00
|
|
|
* Special processing depending on what the constraint is for.
|
2002-07-12 20:43:19 +02:00
|
|
|
*/
|
|
|
|
if (OidIsValid(con->conrelid))
|
|
|
|
{
|
|
|
|
Relation rel;
|
|
|
|
|
2002-12-12 21:35:16 +01:00
|
|
|
/*
|
2005-10-15 04:49:52 +02:00
|
|
|
* If the constraint is for a relation, open and exclusive-lock the
|
|
|
|
* relation it's for.
|
2002-12-12 21:35:16 +01:00
|
|
|
*/
|
2002-07-12 20:43:19 +02:00
|
|
|
rel = heap_open(con->conrelid, AccessExclusiveLock);
|
|
|
|
|
|
|
|
/*
|
2005-10-15 04:49:52 +02:00
|
|
|
* We need to update the relcheck count if it is a check constraint
|
|
|
|
* being dropped. This update will force backends to rebuild relcache
|
|
|
|
* entries when we commit.
|
2002-07-12 20:43:19 +02:00
|
|
|
*/
|
|
|
|
if (con->contype == CONSTRAINT_CHECK)
|
|
|
|
{
|
2002-09-04 22:31:48 +02:00
|
|
|
Relation pgrel;
|
|
|
|
HeapTuple relTup;
|
|
|
|
Form_pg_class classForm;
|
|
|
|
|
2005-04-14 22:03:27 +02:00
|
|
|
pgrel = heap_open(RelationRelationId, RowExclusiveLock);
|
2010-02-14 19:42:19 +01:00
|
|
|
relTup = SearchSysCacheCopy1(RELOID,
|
|
|
|
ObjectIdGetDatum(con->conrelid));
|
2002-07-12 20:43:19 +02:00
|
|
|
if (!HeapTupleIsValid(relTup))
|
2003-07-21 03:59:11 +02:00
|
|
|
elog(ERROR, "cache lookup failed for relation %u",
|
2002-07-12 20:43:19 +02:00
|
|
|
con->conrelid);
|
|
|
|
classForm = (Form_pg_class) GETSTRUCT(relTup);
|
|
|
|
|
Phase 2 of pgindent updates.
Change pg_bsd_indent to follow upstream rules for placement of comments
to the right of code, and remove pgindent hack that caused comments
following #endif to not obey the general rule.
Commit e3860ffa4dd0dad0dd9eea4be9cc1412373a8c89 wasn't actually using
the published version of pg_bsd_indent, but a hacked-up version that
tried to minimize the amount of movement of comments to the right of
code. The situation of interest is where such a comment has to be
moved to the right of its default placement at column 33 because there's
code there. BSD indent has always moved right in units of tab stops
in such cases --- but in the previous incarnation, indent was working
in 8-space tab stops, while now it knows we use 4-space tabs. So the
net result is that in about half the cases, such comments are placed
one tab stop left of before. This is better all around: it leaves
more room on the line for comment text, and it means that in such
cases the comment uniformly starts at the next 4-space tab stop after
the code, rather than sometimes one and sometimes two tabs after.
Also, ensure that comments following #endif are indented the same
as comments following other preprocessor commands such as #else.
That inconsistency turns out to have been self-inflicted damage
from a poorly-thought-through post-indent "fixup" in pgindent.
This patch is much less interesting than the first round of indent
changes, but also bulkier, so I thought it best to separate the effects.
Discussion: https://postgr.es/m/E1dAmxK-0006EE-1r@gemulon.postgresql.org
Discussion: https://postgr.es/m/30527.1495162840@sss.pgh.pa.us
2017-06-21 21:18:54 +02:00
|
|
|
if (classForm->relchecks == 0) /* should not happen */
|
2003-07-21 03:59:11 +02:00
|
|
|
elog(ERROR, "relation \"%s\" has relchecks = 0",
|
2002-07-12 20:43:19 +02:00
|
|
|
RelationGetRelationName(rel));
|
|
|
|
classForm->relchecks--;
|
|
|
|
|
2017-01-31 22:42:24 +01:00
|
|
|
CatalogTupleUpdate(pgrel, &relTup->t_self, relTup);
|
2002-07-12 20:43:19 +02:00
|
|
|
|
|
|
|
heap_freetuple(relTup);
|
|
|
|
|
|
|
|
heap_close(pgrel, RowExclusiveLock);
|
|
|
|
}
|
|
|
|
|
|
|
|
/* Keep lock on constraint's rel until end of xact */
|
|
|
|
heap_close(rel, NoLock);
|
|
|
|
}
|
2002-11-15 03:50:21 +01:00
|
|
|
else if (OidIsValid(con->contypid))
|
|
|
|
{
|
2002-12-12 21:35:16 +01:00
|
|
|
/*
|
2005-10-15 04:49:52 +02:00
|
|
|
* XXX for now, do nothing special when dropping a domain constraint
|
2002-12-12 21:35:16 +01:00
|
|
|
*
|
2005-11-22 19:17:34 +01:00
|
|
|
* Probably there should be some form of locking on the domain type,
|
|
|
|
* but we have no such concept at the moment.
|
2002-12-12 21:35:16 +01:00
|
|
|
*/
|
2002-11-15 03:50:21 +01:00
|
|
|
}
|
2002-12-06 06:00:34 +01:00
|
|
|
else
|
2003-07-21 03:59:11 +02:00
|
|
|
elog(ERROR, "constraint %u is not of a known type", conId);
|
2002-07-12 20:43:19 +02:00
|
|
|
|
|
|
|
/* Fry the constraint itself */
|
2017-02-01 22:13:30 +01:00
|
|
|
CatalogTupleDelete(conDesc, &tup->t_self);
|
2002-07-12 20:43:19 +02:00
|
|
|
|
|
|
|
/* Clean up */
|
2007-02-14 02:58:58 +01:00
|
|
|
ReleaseSysCache(tup);
|
2002-07-12 20:43:19 +02:00
|
|
|
heap_close(conDesc, RowExclusiveLock);
|
|
|
|
}
|
2005-03-25 22:58:00 +01:00
|
|
|
|
2008-01-17 19:56:54 +01:00
|
|
|
/*
|
|
|
|
* RenameConstraintById
|
|
|
|
* Rename a constraint.
|
|
|
|
*
|
|
|
|
* Note: this isn't intended to be a user-exposed function; it doesn't check
|
|
|
|
* permissions etc. Currently this is only invoked when renaming an index
|
|
|
|
* that is associated with a constraint, but it's made a little more general
|
|
|
|
* than that with the expectation of someday having ALTER TABLE RENAME
|
|
|
|
* CONSTRAINT.
|
|
|
|
*/
|
|
|
|
void
|
|
|
|
RenameConstraintById(Oid conId, const char *newname)
|
|
|
|
{
|
|
|
|
Relation conDesc;
|
|
|
|
HeapTuple tuple;
|
|
|
|
Form_pg_constraint con;
|
|
|
|
|
|
|
|
conDesc = heap_open(ConstraintRelationId, RowExclusiveLock);
|
|
|
|
|
2010-02-14 19:42:19 +01:00
|
|
|
tuple = SearchSysCacheCopy1(CONSTROID, ObjectIdGetDatum(conId));
|
2008-01-17 19:56:54 +01:00
|
|
|
if (!HeapTupleIsValid(tuple))
|
|
|
|
elog(ERROR, "cache lookup failed for constraint %u", conId);
|
|
|
|
con = (Form_pg_constraint) GETSTRUCT(tuple);
|
|
|
|
|
|
|
|
/*
|
Fully enforce uniqueness of constraint names.
It's been true for a long time that we expect names of table and domain
constraints to be unique among the constraints of that table or domain.
However, the enforcement of that has been pretty haphazard, and it missed
some corner cases such as creating a CHECK constraint and then an index
constraint of the same name (as per recent report from André Hänsel).
Also, due to the lack of an actual unique index enforcing this, duplicates
could be created through race conditions.
Moreover, the code that searches pg_constraint has been quite inconsistent
about how to handle duplicate names if one did occur: some places checked
and threw errors if there was more than one match, while others just
processed the first match they came to.
To fix, create a unique index on (conrelid, contypid, conname). Since
either conrelid or contypid is zero, this will separately enforce
uniqueness of constraint names among constraints of any one table and any
one domain. (If we ever implement SQL assertions, and put them into this
catalog, more thought might be needed. But it'd be at least as reasonable
to put them into a new catalog; having overloaded this one catalog with
two kinds of constraints was a mistake already IMO.) This index can replace
the existing non-unique index on conrelid, though we need to keep the one
on contypid for query performance reasons.
Having done that, we can simplify the logic in various places that either
coped with duplicates or neglected to, as well as potentially improve
lookup performance when searching for a constraint by name.
Also, as per our usual practice, install a preliminary check so that you
get something more friendly than a unique-index violation report in the
case complained of by André. And teach ChooseIndexName to avoid choosing
autogenerated names that would draw such a failure.
While it's not possible to make such a change in the back branches,
it doesn't seem quite too late to put this into v11, so do so.
Discussion: https://postgr.es/m/0c1001d4428f$0942b430$1bc81c90$@webkr.de
2018-09-04 19:45:35 +02:00
|
|
|
* For user-friendliness, check whether the name is already in use.
|
2008-01-17 19:56:54 +01:00
|
|
|
*/
|
|
|
|
if (OidIsValid(con->conrelid) &&
|
|
|
|
ConstraintNameIsUsed(CONSTRAINT_RELATION,
|
|
|
|
con->conrelid,
|
|
|
|
newname))
|
|
|
|
ereport(ERROR,
|
|
|
|
(errcode(ERRCODE_DUPLICATE_OBJECT),
|
Phase 3 of pgindent updates.
Don't move parenthesized lines to the left, even if that means they
flow past the right margin.
By default, BSD indent lines up statement continuation lines that are
within parentheses so that they start just to the right of the preceding
left parenthesis. However, traditionally, if that resulted in the
continuation line extending to the right of the desired right margin,
then indent would push it left just far enough to not overrun the margin,
if it could do so without making the continuation line start to the left of
the current statement indent. That makes for a weird mix of indentations
unless one has been completely rigid about never violating the 80-column
limit.
This behavior has been pretty universally panned by Postgres developers.
Hence, disable it with indent's new -lpl switch, so that parenthesized
lines are always lined up with the preceding left paren.
This patch is much less interesting than the first round of indent
changes, but also bulkier, so I thought it best to separate the effects.
Discussion: https://postgr.es/m/E1dAmxK-0006EE-1r@gemulon.postgresql.org
Discussion: https://postgr.es/m/30527.1495162840@sss.pgh.pa.us
2017-06-21 21:35:54 +02:00
|
|
|
errmsg("constraint \"%s\" for relation \"%s\" already exists",
|
|
|
|
newname, get_rel_name(con->conrelid))));
|
2008-01-17 19:56:54 +01:00
|
|
|
if (OidIsValid(con->contypid) &&
|
|
|
|
ConstraintNameIsUsed(CONSTRAINT_DOMAIN,
|
|
|
|
con->contypid,
|
|
|
|
newname))
|
|
|
|
ereport(ERROR,
|
|
|
|
(errcode(ERRCODE_DUPLICATE_OBJECT),
|
2012-01-24 20:49:27 +01:00
|
|
|
errmsg("constraint \"%s\" for domain %s already exists",
|
2008-01-17 19:56:54 +01:00
|
|
|
newname, format_type_be(con->contypid))));
|
|
|
|
|
|
|
|
/* OK, do the rename --- tuple is a copy, so OK to scribble on it */
|
|
|
|
namestrcpy(&(con->conname), newname);
|
|
|
|
|
2017-01-31 22:42:24 +01:00
|
|
|
CatalogTupleUpdate(conDesc, &tuple->t_self, tuple);
|
2008-01-17 19:56:54 +01:00
|
|
|
|
2013-03-18 03:55:14 +01:00
|
|
|
InvokeObjectPostAlterHook(ConstraintRelationId, conId, 0);
|
|
|
|
|
2008-01-17 19:56:54 +01:00
|
|
|
heap_freetuple(tuple);
|
|
|
|
heap_close(conDesc, RowExclusiveLock);
|
|
|
|
}
|
|
|
|
|
2005-08-01 06:03:59 +02:00
|
|
|
/*
|
|
|
|
* AlterConstraintNamespaces
|
|
|
|
* Find any constraints belonging to the specified object,
|
|
|
|
* and move them to the specified new namespace.
|
|
|
|
*
|
|
|
|
* isType indicates whether the owning object is a type or a relation.
|
|
|
|
*/
|
|
|
|
void
|
|
|
|
AlterConstraintNamespaces(Oid ownerId, Oid oldNspId,
|
Phase 3 of pgindent updates.
Don't move parenthesized lines to the left, even if that means they
flow past the right margin.
By default, BSD indent lines up statement continuation lines that are
within parentheses so that they start just to the right of the preceding
left parenthesis. However, traditionally, if that resulted in the
continuation line extending to the right of the desired right margin,
then indent would push it left just far enough to not overrun the margin,
if it could do so without making the continuation line start to the left of
the current statement indent. That makes for a weird mix of indentations
unless one has been completely rigid about never violating the 80-column
limit.
This behavior has been pretty universally panned by Postgres developers.
Hence, disable it with indent's new -lpl switch, so that parenthesized
lines are always lined up with the preceding left paren.
This patch is much less interesting than the first round of indent
changes, but also bulkier, so I thought it best to separate the effects.
Discussion: https://postgr.es/m/E1dAmxK-0006EE-1r@gemulon.postgresql.org
Discussion: https://postgr.es/m/30527.1495162840@sss.pgh.pa.us
2017-06-21 21:35:54 +02:00
|
|
|
Oid newNspId, bool isType, ObjectAddresses *objsMoved)
|
2005-08-01 06:03:59 +02:00
|
|
|
{
|
2005-10-15 04:49:52 +02:00
|
|
|
Relation conRel;
|
Fully enforce uniqueness of constraint names.
It's been true for a long time that we expect names of table and domain
constraints to be unique among the constraints of that table or domain.
However, the enforcement of that has been pretty haphazard, and it missed
some corner cases such as creating a CHECK constraint and then an index
constraint of the same name (as per recent report from André Hänsel).
Also, due to the lack of an actual unique index enforcing this, duplicates
could be created through race conditions.
Moreover, the code that searches pg_constraint has been quite inconsistent
about how to handle duplicate names if one did occur: some places checked
and threw errors if there was more than one match, while others just
processed the first match they came to.
To fix, create a unique index on (conrelid, contypid, conname). Since
either conrelid or contypid is zero, this will separately enforce
uniqueness of constraint names among constraints of any one table and any
one domain. (If we ever implement SQL assertions, and put them into this
catalog, more thought might be needed. But it'd be at least as reasonable
to put them into a new catalog; having overloaded this one catalog with
two kinds of constraints was a mistake already IMO.) This index can replace
the existing non-unique index on conrelid, though we need to keep the one
on contypid for query performance reasons.
Having done that, we can simplify the logic in various places that either
coped with duplicates or neglected to, as well as potentially improve
lookup performance when searching for a constraint by name.
Also, as per our usual practice, install a preliminary check so that you
get something more friendly than a unique-index violation report in the
case complained of by André. And teach ChooseIndexName to avoid choosing
autogenerated names that would draw such a failure.
While it's not possible to make such a change in the back branches,
it doesn't seem quite too late to put this into v11, so do so.
Discussion: https://postgr.es/m/0c1001d4428f$0942b430$1bc81c90$@webkr.de
2018-09-04 19:45:35 +02:00
|
|
|
ScanKeyData key[2];
|
2005-10-15 04:49:52 +02:00
|
|
|
SysScanDesc scan;
|
|
|
|
HeapTuple tup;
|
2005-08-01 06:03:59 +02:00
|
|
|
|
|
|
|
conRel = heap_open(ConstraintRelationId, RowExclusiveLock);
|
|
|
|
|
Fully enforce uniqueness of constraint names.
It's been true for a long time that we expect names of table and domain
constraints to be unique among the constraints of that table or domain.
However, the enforcement of that has been pretty haphazard, and it missed
some corner cases such as creating a CHECK constraint and then an index
constraint of the same name (as per recent report from André Hänsel).
Also, due to the lack of an actual unique index enforcing this, duplicates
could be created through race conditions.
Moreover, the code that searches pg_constraint has been quite inconsistent
about how to handle duplicate names if one did occur: some places checked
and threw errors if there was more than one match, while others just
processed the first match they came to.
To fix, create a unique index on (conrelid, contypid, conname). Since
either conrelid or contypid is zero, this will separately enforce
uniqueness of constraint names among constraints of any one table and any
one domain. (If we ever implement SQL assertions, and put them into this
catalog, more thought might be needed. But it'd be at least as reasonable
to put them into a new catalog; having overloaded this one catalog with
two kinds of constraints was a mistake already IMO.) This index can replace
the existing non-unique index on conrelid, though we need to keep the one
on contypid for query performance reasons.
Having done that, we can simplify the logic in various places that either
coped with duplicates or neglected to, as well as potentially improve
lookup performance when searching for a constraint by name.
Also, as per our usual practice, install a preliminary check so that you
get something more friendly than a unique-index violation report in the
case complained of by André. And teach ChooseIndexName to avoid choosing
autogenerated names that would draw such a failure.
While it's not possible to make such a change in the back branches,
it doesn't seem quite too late to put this into v11, so do so.
Discussion: https://postgr.es/m/0c1001d4428f$0942b430$1bc81c90$@webkr.de
2018-09-04 19:45:35 +02:00
|
|
|
ScanKeyInit(&key[0],
|
|
|
|
Anum_pg_constraint_conrelid,
|
|
|
|
BTEqualStrategyNumber, F_OIDEQ,
|
|
|
|
ObjectIdGetDatum(isType ? InvalidOid : ownerId));
|
|
|
|
ScanKeyInit(&key[1],
|
|
|
|
Anum_pg_constraint_contypid,
|
|
|
|
BTEqualStrategyNumber, F_OIDEQ,
|
|
|
|
ObjectIdGetDatum(isType ? ownerId : InvalidOid));
|
2005-08-01 06:03:59 +02:00
|
|
|
|
Fully enforce uniqueness of constraint names.
It's been true for a long time that we expect names of table and domain
constraints to be unique among the constraints of that table or domain.
However, the enforcement of that has been pretty haphazard, and it missed
some corner cases such as creating a CHECK constraint and then an index
constraint of the same name (as per recent report from André Hänsel).
Also, due to the lack of an actual unique index enforcing this, duplicates
could be created through race conditions.
Moreover, the code that searches pg_constraint has been quite inconsistent
about how to handle duplicate names if one did occur: some places checked
and threw errors if there was more than one match, while others just
processed the first match they came to.
To fix, create a unique index on (conrelid, contypid, conname). Since
either conrelid or contypid is zero, this will separately enforce
uniqueness of constraint names among constraints of any one table and any
one domain. (If we ever implement SQL assertions, and put them into this
catalog, more thought might be needed. But it'd be at least as reasonable
to put them into a new catalog; having overloaded this one catalog with
two kinds of constraints was a mistake already IMO.) This index can replace
the existing non-unique index on conrelid, though we need to keep the one
on contypid for query performance reasons.
Having done that, we can simplify the logic in various places that either
coped with duplicates or neglected to, as well as potentially improve
lookup performance when searching for a constraint by name.
Also, as per our usual practice, install a preliminary check so that you
get something more friendly than a unique-index violation report in the
case complained of by André. And teach ChooseIndexName to avoid choosing
autogenerated names that would draw such a failure.
While it's not possible to make such a change in the back branches,
it doesn't seem quite too late to put this into v11, so do so.
Discussion: https://postgr.es/m/0c1001d4428f$0942b430$1bc81c90$@webkr.de
2018-09-04 19:45:35 +02:00
|
|
|
scan = systable_beginscan(conRel, ConstraintRelidTypidNameIndexId, true,
|
|
|
|
NULL, 2, key);
|
2005-08-01 06:03:59 +02:00
|
|
|
|
|
|
|
while (HeapTupleIsValid((tup = systable_getnext(scan))))
|
|
|
|
{
|
|
|
|
Form_pg_constraint conform = (Form_pg_constraint) GETSTRUCT(tup);
|
2013-05-29 22:58:43 +02:00
|
|
|
ObjectAddress thisobj;
|
2012-10-31 14:52:55 +01:00
|
|
|
|
|
|
|
thisobj.classId = ConstraintRelationId;
|
|
|
|
thisobj.objectId = HeapTupleGetOid(tup);
|
|
|
|
thisobj.objectSubId = 0;
|
|
|
|
|
|
|
|
if (object_address_present(&thisobj, objsMoved))
|
|
|
|
continue;
|
2005-08-01 06:03:59 +02:00
|
|
|
|
2015-11-19 16:49:25 +01:00
|
|
|
/* Don't update if the object is already part of the namespace */
|
|
|
|
if (conform->connamespace == oldNspId && oldNspId != newNspId)
|
2005-08-01 06:03:59 +02:00
|
|
|
{
|
|
|
|
tup = heap_copytuple(tup);
|
|
|
|
conform = (Form_pg_constraint) GETSTRUCT(tup);
|
|
|
|
|
|
|
|
conform->connamespace = newNspId;
|
|
|
|
|
2017-01-31 22:42:24 +01:00
|
|
|
CatalogTupleUpdate(conRel, &tup->t_self, tup);
|
2005-08-01 06:03:59 +02:00
|
|
|
|
|
|
|
/*
|
|
|
|
* Note: currently, the constraint will not have its own
|
|
|
|
* dependency on the namespace, so we don't need to do
|
|
|
|
* changeDependencyFor().
|
|
|
|
*/
|
|
|
|
}
|
2012-10-31 14:52:55 +01:00
|
|
|
|
2013-03-18 03:55:14 +01:00
|
|
|
InvokeObjectPostAlterHook(ConstraintRelationId, thisobj.objectId, 0);
|
|
|
|
|
2012-10-31 14:52:55 +01:00
|
|
|
add_exact_object_address(&thisobj, objsMoved);
|
2005-08-01 06:03:59 +02:00
|
|
|
}
|
|
|
|
|
|
|
|
systable_endscan(scan);
|
|
|
|
|
|
|
|
heap_close(conRel, RowExclusiveLock);
|
|
|
|
}
|
2009-10-12 21:49:24 +02:00
|
|
|
|
2018-02-19 20:59:37 +01:00
|
|
|
/*
|
|
|
|
* ConstraintSetParentConstraint
|
|
|
|
* Set a partition's constraint as child of its parent table's
|
|
|
|
*
|
|
|
|
* This updates the constraint's pg_constraint row to show it as inherited, and
|
|
|
|
* add a dependency to the parent so that it cannot be removed on its own.
|
|
|
|
*/
|
|
|
|
void
|
|
|
|
ConstraintSetParentConstraint(Oid childConstrId, Oid parentConstrId)
|
|
|
|
{
|
2018-04-26 20:47:16 +02:00
|
|
|
Relation constrRel;
|
2018-02-19 20:59:37 +01:00
|
|
|
Form_pg_constraint constrForm;
|
2018-04-26 20:47:16 +02:00
|
|
|
HeapTuple tuple,
|
|
|
|
newtup;
|
|
|
|
ObjectAddress depender;
|
|
|
|
ObjectAddress referenced;
|
2018-02-19 20:59:37 +01:00
|
|
|
|
|
|
|
constrRel = heap_open(ConstraintRelationId, RowExclusiveLock);
|
|
|
|
tuple = SearchSysCache1(CONSTROID, ObjectIdGetDatum(childConstrId));
|
|
|
|
if (!HeapTupleIsValid(tuple))
|
|
|
|
elog(ERROR, "cache lookup failed for constraint %u", childConstrId);
|
|
|
|
newtup = heap_copytuple(tuple);
|
|
|
|
constrForm = (Form_pg_constraint) GETSTRUCT(newtup);
|
|
|
|
constrForm->conislocal = false;
|
|
|
|
constrForm->coninhcount++;
|
2018-03-23 14:48:22 +01:00
|
|
|
constrForm->conparentid = parentConstrId;
|
2018-02-19 20:59:37 +01:00
|
|
|
CatalogTupleUpdate(constrRel, &tuple->t_self, newtup);
|
|
|
|
ReleaseSysCache(tuple);
|
|
|
|
|
|
|
|
ObjectAddressSet(referenced, ConstraintRelationId, parentConstrId);
|
|
|
|
ObjectAddressSet(depender, ConstraintRelationId, childConstrId);
|
|
|
|
|
|
|
|
recordDependencyOn(&depender, &referenced, DEPENDENCY_INTERNAL_AUTO);
|
|
|
|
|
|
|
|
heap_close(constrRel, RowExclusiveLock);
|
|
|
|
}
|
|
|
|
|
|
|
|
|
2009-10-12 21:49:24 +02:00
|
|
|
/*
|
2012-04-03 07:11:51 +02:00
|
|
|
* get_relation_constraint_oid
|
2009-10-13 02:53:08 +02:00
|
|
|
* Find a constraint on the specified relation with the specified name.
|
|
|
|
* Returns constraint's OID.
|
2009-10-12 21:49:24 +02:00
|
|
|
*/
|
|
|
|
Oid
|
2012-04-03 07:11:51 +02:00
|
|
|
get_relation_constraint_oid(Oid relid, const char *conname, bool missing_ok)
|
2009-10-12 21:49:24 +02:00
|
|
|
{
|
|
|
|
Relation pg_constraint;
|
|
|
|
HeapTuple tuple;
|
|
|
|
SysScanDesc scan;
|
Fully enforce uniqueness of constraint names.
It's been true for a long time that we expect names of table and domain
constraints to be unique among the constraints of that table or domain.
However, the enforcement of that has been pretty haphazard, and it missed
some corner cases such as creating a CHECK constraint and then an index
constraint of the same name (as per recent report from André Hänsel).
Also, due to the lack of an actual unique index enforcing this, duplicates
could be created through race conditions.
Moreover, the code that searches pg_constraint has been quite inconsistent
about how to handle duplicate names if one did occur: some places checked
and threw errors if there was more than one match, while others just
processed the first match they came to.
To fix, create a unique index on (conrelid, contypid, conname). Since
either conrelid or contypid is zero, this will separately enforce
uniqueness of constraint names among constraints of any one table and any
one domain. (If we ever implement SQL assertions, and put them into this
catalog, more thought might be needed. But it'd be at least as reasonable
to put them into a new catalog; having overloaded this one catalog with
two kinds of constraints was a mistake already IMO.) This index can replace
the existing non-unique index on conrelid, though we need to keep the one
on contypid for query performance reasons.
Having done that, we can simplify the logic in various places that either
coped with duplicates or neglected to, as well as potentially improve
lookup performance when searching for a constraint by name.
Also, as per our usual practice, install a preliminary check so that you
get something more friendly than a unique-index violation report in the
case complained of by André. And teach ChooseIndexName to avoid choosing
autogenerated names that would draw such a failure.
While it's not possible to make such a change in the back branches,
it doesn't seem quite too late to put this into v11, so do so.
Discussion: https://postgr.es/m/0c1001d4428f$0942b430$1bc81c90$@webkr.de
2018-09-04 19:45:35 +02:00
|
|
|
ScanKeyData skey[3];
|
2009-10-12 21:49:24 +02:00
|
|
|
Oid conOid = InvalidOid;
|
|
|
|
|
|
|
|
pg_constraint = heap_open(ConstraintRelationId, AccessShareLock);
|
|
|
|
|
|
|
|
ScanKeyInit(&skey[0],
|
|
|
|
Anum_pg_constraint_conrelid,
|
2009-10-13 02:53:08 +02:00
|
|
|
BTEqualStrategyNumber, F_OIDEQ,
|
|
|
|
ObjectIdGetDatum(relid));
|
Fully enforce uniqueness of constraint names.
It's been true for a long time that we expect names of table and domain
constraints to be unique among the constraints of that table or domain.
However, the enforcement of that has been pretty haphazard, and it missed
some corner cases such as creating a CHECK constraint and then an index
constraint of the same name (as per recent report from André Hänsel).
Also, due to the lack of an actual unique index enforcing this, duplicates
could be created through race conditions.
Moreover, the code that searches pg_constraint has been quite inconsistent
about how to handle duplicate names if one did occur: some places checked
and threw errors if there was more than one match, while others just
processed the first match they came to.
To fix, create a unique index on (conrelid, contypid, conname). Since
either conrelid or contypid is zero, this will separately enforce
uniqueness of constraint names among constraints of any one table and any
one domain. (If we ever implement SQL assertions, and put them into this
catalog, more thought might be needed. But it'd be at least as reasonable
to put them into a new catalog; having overloaded this one catalog with
two kinds of constraints was a mistake already IMO.) This index can replace
the existing non-unique index on conrelid, though we need to keep the one
on contypid for query performance reasons.
Having done that, we can simplify the logic in various places that either
coped with duplicates or neglected to, as well as potentially improve
lookup performance when searching for a constraint by name.
Also, as per our usual practice, install a preliminary check so that you
get something more friendly than a unique-index violation report in the
case complained of by André. And teach ChooseIndexName to avoid choosing
autogenerated names that would draw such a failure.
While it's not possible to make such a change in the back branches,
it doesn't seem quite too late to put this into v11, so do so.
Discussion: https://postgr.es/m/0c1001d4428f$0942b430$1bc81c90$@webkr.de
2018-09-04 19:45:35 +02:00
|
|
|
ScanKeyInit(&skey[1],
|
|
|
|
Anum_pg_constraint_contypid,
|
|
|
|
BTEqualStrategyNumber, F_OIDEQ,
|
|
|
|
ObjectIdGetDatum(InvalidOid));
|
|
|
|
ScanKeyInit(&skey[2],
|
|
|
|
Anum_pg_constraint_conname,
|
|
|
|
BTEqualStrategyNumber, F_NAMEEQ,
|
|
|
|
CStringGetDatum(conname));
|
2009-10-12 21:49:24 +02:00
|
|
|
|
Fully enforce uniqueness of constraint names.
It's been true for a long time that we expect names of table and domain
constraints to be unique among the constraints of that table or domain.
However, the enforcement of that has been pretty haphazard, and it missed
some corner cases such as creating a CHECK constraint and then an index
constraint of the same name (as per recent report from André Hänsel).
Also, due to the lack of an actual unique index enforcing this, duplicates
could be created through race conditions.
Moreover, the code that searches pg_constraint has been quite inconsistent
about how to handle duplicate names if one did occur: some places checked
and threw errors if there was more than one match, while others just
processed the first match they came to.
To fix, create a unique index on (conrelid, contypid, conname). Since
either conrelid or contypid is zero, this will separately enforce
uniqueness of constraint names among constraints of any one table and any
one domain. (If we ever implement SQL assertions, and put them into this
catalog, more thought might be needed. But it'd be at least as reasonable
to put them into a new catalog; having overloaded this one catalog with
two kinds of constraints was a mistake already IMO.) This index can replace
the existing non-unique index on conrelid, though we need to keep the one
on contypid for query performance reasons.
Having done that, we can simplify the logic in various places that either
coped with duplicates or neglected to, as well as potentially improve
lookup performance when searching for a constraint by name.
Also, as per our usual practice, install a preliminary check so that you
get something more friendly than a unique-index violation report in the
case complained of by André. And teach ChooseIndexName to avoid choosing
autogenerated names that would draw such a failure.
While it's not possible to make such a change in the back branches,
it doesn't seem quite too late to put this into v11, so do so.
Discussion: https://postgr.es/m/0c1001d4428f$0942b430$1bc81c90$@webkr.de
2018-09-04 19:45:35 +02:00
|
|
|
scan = systable_beginscan(pg_constraint, ConstraintRelidTypidNameIndexId, true,
|
|
|
|
NULL, 3, skey);
|
2009-10-12 21:49:24 +02:00
|
|
|
|
Fully enforce uniqueness of constraint names.
It's been true for a long time that we expect names of table and domain
constraints to be unique among the constraints of that table or domain.
However, the enforcement of that has been pretty haphazard, and it missed
some corner cases such as creating a CHECK constraint and then an index
constraint of the same name (as per recent report from André Hänsel).
Also, due to the lack of an actual unique index enforcing this, duplicates
could be created through race conditions.
Moreover, the code that searches pg_constraint has been quite inconsistent
about how to handle duplicate names if one did occur: some places checked
and threw errors if there was more than one match, while others just
processed the first match they came to.
To fix, create a unique index on (conrelid, contypid, conname). Since
either conrelid or contypid is zero, this will separately enforce
uniqueness of constraint names among constraints of any one table and any
one domain. (If we ever implement SQL assertions, and put them into this
catalog, more thought might be needed. But it'd be at least as reasonable
to put them into a new catalog; having overloaded this one catalog with
two kinds of constraints was a mistake already IMO.) This index can replace
the existing non-unique index on conrelid, though we need to keep the one
on contypid for query performance reasons.
Having done that, we can simplify the logic in various places that either
coped with duplicates or neglected to, as well as potentially improve
lookup performance when searching for a constraint by name.
Also, as per our usual practice, install a preliminary check so that you
get something more friendly than a unique-index violation report in the
case complained of by André. And teach ChooseIndexName to avoid choosing
autogenerated names that would draw such a failure.
While it's not possible to make such a change in the back branches,
it doesn't seem quite too late to put this into v11, so do so.
Discussion: https://postgr.es/m/0c1001d4428f$0942b430$1bc81c90$@webkr.de
2018-09-04 19:45:35 +02:00
|
|
|
/* There can be at most one matching row */
|
|
|
|
if (HeapTupleIsValid(tuple = systable_getnext(scan)))
|
|
|
|
conOid = HeapTupleGetOid(tuple);
|
2009-10-12 21:49:24 +02:00
|
|
|
|
|
|
|
systable_endscan(scan);
|
|
|
|
|
2009-10-13 02:53:08 +02:00
|
|
|
/* If no such constraint exists, complain */
|
2010-08-05 17:25:36 +02:00
|
|
|
if (!OidIsValid(conOid) && !missing_ok)
|
2009-10-12 21:49:24 +02:00
|
|
|
ereport(ERROR,
|
|
|
|
(errcode(ERRCODE_UNDEFINED_OBJECT),
|
|
|
|
errmsg("constraint \"%s\" for table \"%s\" does not exist",
|
2009-10-13 02:53:08 +02:00
|
|
|
conname, get_rel_name(relid))));
|
2009-10-12 21:49:24 +02:00
|
|
|
|
|
|
|
heap_close(pg_constraint, AccessShareLock);
|
|
|
|
|
|
|
|
return conOid;
|
|
|
|
}
|
2010-08-07 04:44:09 +02:00
|
|
|
|
2017-11-06 10:19:22 +01:00
|
|
|
/*
|
|
|
|
* get_relation_constraint_attnos
|
|
|
|
* Find a constraint on the specified relation with the specified name
|
|
|
|
* and return the constrained columns.
|
|
|
|
*
|
|
|
|
* Returns a Bitmapset of the column attnos of the constrained columns, with
|
|
|
|
* attnos being offset by FirstLowInvalidHeapAttributeNumber so that system
|
|
|
|
* columns can be represented.
|
|
|
|
*
|
|
|
|
* *constraintOid is set to the OID of the constraint, or InvalidOid on
|
|
|
|
* failure.
|
|
|
|
*/
|
|
|
|
Bitmapset *
|
|
|
|
get_relation_constraint_attnos(Oid relid, const char *conname,
|
|
|
|
bool missing_ok, Oid *constraintOid)
|
|
|
|
{
|
|
|
|
Bitmapset *conattnos = NULL;
|
|
|
|
Relation pg_constraint;
|
|
|
|
HeapTuple tuple;
|
|
|
|
SysScanDesc scan;
|
Fully enforce uniqueness of constraint names.
It's been true for a long time that we expect names of table and domain
constraints to be unique among the constraints of that table or domain.
However, the enforcement of that has been pretty haphazard, and it missed
some corner cases such as creating a CHECK constraint and then an index
constraint of the same name (as per recent report from André Hänsel).
Also, due to the lack of an actual unique index enforcing this, duplicates
could be created through race conditions.
Moreover, the code that searches pg_constraint has been quite inconsistent
about how to handle duplicate names if one did occur: some places checked
and threw errors if there was more than one match, while others just
processed the first match they came to.
To fix, create a unique index on (conrelid, contypid, conname). Since
either conrelid or contypid is zero, this will separately enforce
uniqueness of constraint names among constraints of any one table and any
one domain. (If we ever implement SQL assertions, and put them into this
catalog, more thought might be needed. But it'd be at least as reasonable
to put them into a new catalog; having overloaded this one catalog with
two kinds of constraints was a mistake already IMO.) This index can replace
the existing non-unique index on conrelid, though we need to keep the one
on contypid for query performance reasons.
Having done that, we can simplify the logic in various places that either
coped with duplicates or neglected to, as well as potentially improve
lookup performance when searching for a constraint by name.
Also, as per our usual practice, install a preliminary check so that you
get something more friendly than a unique-index violation report in the
case complained of by André. And teach ChooseIndexName to avoid choosing
autogenerated names that would draw such a failure.
While it's not possible to make such a change in the back branches,
it doesn't seem quite too late to put this into v11, so do so.
Discussion: https://postgr.es/m/0c1001d4428f$0942b430$1bc81c90$@webkr.de
2018-09-04 19:45:35 +02:00
|
|
|
ScanKeyData skey[3];
|
2017-11-06 10:19:22 +01:00
|
|
|
|
|
|
|
/* Set *constraintOid, to avoid complaints about uninitialized vars */
|
|
|
|
*constraintOid = InvalidOid;
|
|
|
|
|
|
|
|
pg_constraint = heap_open(ConstraintRelationId, AccessShareLock);
|
|
|
|
|
|
|
|
ScanKeyInit(&skey[0],
|
|
|
|
Anum_pg_constraint_conrelid,
|
|
|
|
BTEqualStrategyNumber, F_OIDEQ,
|
|
|
|
ObjectIdGetDatum(relid));
|
Fully enforce uniqueness of constraint names.
It's been true for a long time that we expect names of table and domain
constraints to be unique among the constraints of that table or domain.
However, the enforcement of that has been pretty haphazard, and it missed
some corner cases such as creating a CHECK constraint and then an index
constraint of the same name (as per recent report from André Hänsel).
Also, due to the lack of an actual unique index enforcing this, duplicates
could be created through race conditions.
Moreover, the code that searches pg_constraint has been quite inconsistent
about how to handle duplicate names if one did occur: some places checked
and threw errors if there was more than one match, while others just
processed the first match they came to.
To fix, create a unique index on (conrelid, contypid, conname). Since
either conrelid or contypid is zero, this will separately enforce
uniqueness of constraint names among constraints of any one table and any
one domain. (If we ever implement SQL assertions, and put them into this
catalog, more thought might be needed. But it'd be at least as reasonable
to put them into a new catalog; having overloaded this one catalog with
two kinds of constraints was a mistake already IMO.) This index can replace
the existing non-unique index on conrelid, though we need to keep the one
on contypid for query performance reasons.
Having done that, we can simplify the logic in various places that either
coped with duplicates or neglected to, as well as potentially improve
lookup performance when searching for a constraint by name.
Also, as per our usual practice, install a preliminary check so that you
get something more friendly than a unique-index violation report in the
case complained of by André. And teach ChooseIndexName to avoid choosing
autogenerated names that would draw such a failure.
While it's not possible to make such a change in the back branches,
it doesn't seem quite too late to put this into v11, so do so.
Discussion: https://postgr.es/m/0c1001d4428f$0942b430$1bc81c90$@webkr.de
2018-09-04 19:45:35 +02:00
|
|
|
ScanKeyInit(&skey[1],
|
|
|
|
Anum_pg_constraint_contypid,
|
|
|
|
BTEqualStrategyNumber, F_OIDEQ,
|
|
|
|
ObjectIdGetDatum(InvalidOid));
|
|
|
|
ScanKeyInit(&skey[2],
|
|
|
|
Anum_pg_constraint_conname,
|
|
|
|
BTEqualStrategyNumber, F_NAMEEQ,
|
|
|
|
CStringGetDatum(conname));
|
2017-11-06 10:19:22 +01:00
|
|
|
|
Fully enforce uniqueness of constraint names.
It's been true for a long time that we expect names of table and domain
constraints to be unique among the constraints of that table or domain.
However, the enforcement of that has been pretty haphazard, and it missed
some corner cases such as creating a CHECK constraint and then an index
constraint of the same name (as per recent report from André Hänsel).
Also, due to the lack of an actual unique index enforcing this, duplicates
could be created through race conditions.
Moreover, the code that searches pg_constraint has been quite inconsistent
about how to handle duplicate names if one did occur: some places checked
and threw errors if there was more than one match, while others just
processed the first match they came to.
To fix, create a unique index on (conrelid, contypid, conname). Since
either conrelid or contypid is zero, this will separately enforce
uniqueness of constraint names among constraints of any one table and any
one domain. (If we ever implement SQL assertions, and put them into this
catalog, more thought might be needed. But it'd be at least as reasonable
to put them into a new catalog; having overloaded this one catalog with
two kinds of constraints was a mistake already IMO.) This index can replace
the existing non-unique index on conrelid, though we need to keep the one
on contypid for query performance reasons.
Having done that, we can simplify the logic in various places that either
coped with duplicates or neglected to, as well as potentially improve
lookup performance when searching for a constraint by name.
Also, as per our usual practice, install a preliminary check so that you
get something more friendly than a unique-index violation report in the
case complained of by André. And teach ChooseIndexName to avoid choosing
autogenerated names that would draw such a failure.
While it's not possible to make such a change in the back branches,
it doesn't seem quite too late to put this into v11, so do so.
Discussion: https://postgr.es/m/0c1001d4428f$0942b430$1bc81c90$@webkr.de
2018-09-04 19:45:35 +02:00
|
|
|
scan = systable_beginscan(pg_constraint, ConstraintRelidTypidNameIndexId, true,
|
|
|
|
NULL, 3, skey);
|
2017-11-06 10:19:22 +01:00
|
|
|
|
Fully enforce uniqueness of constraint names.
It's been true for a long time that we expect names of table and domain
constraints to be unique among the constraints of that table or domain.
However, the enforcement of that has been pretty haphazard, and it missed
some corner cases such as creating a CHECK constraint and then an index
constraint of the same name (as per recent report from André Hänsel).
Also, due to the lack of an actual unique index enforcing this, duplicates
could be created through race conditions.
Moreover, the code that searches pg_constraint has been quite inconsistent
about how to handle duplicate names if one did occur: some places checked
and threw errors if there was more than one match, while others just
processed the first match they came to.
To fix, create a unique index on (conrelid, contypid, conname). Since
either conrelid or contypid is zero, this will separately enforce
uniqueness of constraint names among constraints of any one table and any
one domain. (If we ever implement SQL assertions, and put them into this
catalog, more thought might be needed. But it'd be at least as reasonable
to put them into a new catalog; having overloaded this one catalog with
two kinds of constraints was a mistake already IMO.) This index can replace
the existing non-unique index on conrelid, though we need to keep the one
on contypid for query performance reasons.
Having done that, we can simplify the logic in various places that either
coped with duplicates or neglected to, as well as potentially improve
lookup performance when searching for a constraint by name.
Also, as per our usual practice, install a preliminary check so that you
get something more friendly than a unique-index violation report in the
case complained of by André. And teach ChooseIndexName to avoid choosing
autogenerated names that would draw such a failure.
While it's not possible to make such a change in the back branches,
it doesn't seem quite too late to put this into v11, so do so.
Discussion: https://postgr.es/m/0c1001d4428f$0942b430$1bc81c90$@webkr.de
2018-09-04 19:45:35 +02:00
|
|
|
/* There can be at most one matching row */
|
|
|
|
if (HeapTupleIsValid(tuple = systable_getnext(scan)))
|
2017-11-06 10:19:22 +01:00
|
|
|
{
|
|
|
|
Datum adatum;
|
|
|
|
bool isNull;
|
|
|
|
|
|
|
|
*constraintOid = HeapTupleGetOid(tuple);
|
|
|
|
|
|
|
|
/* Extract the conkey array, ie, attnums of constrained columns */
|
|
|
|
adatum = heap_getattr(tuple, Anum_pg_constraint_conkey,
|
|
|
|
RelationGetDescr(pg_constraint), &isNull);
|
Fully enforce uniqueness of constraint names.
It's been true for a long time that we expect names of table and domain
constraints to be unique among the constraints of that table or domain.
However, the enforcement of that has been pretty haphazard, and it missed
some corner cases such as creating a CHECK constraint and then an index
constraint of the same name (as per recent report from André Hänsel).
Also, due to the lack of an actual unique index enforcing this, duplicates
could be created through race conditions.
Moreover, the code that searches pg_constraint has been quite inconsistent
about how to handle duplicate names if one did occur: some places checked
and threw errors if there was more than one match, while others just
processed the first match they came to.
To fix, create a unique index on (conrelid, contypid, conname). Since
either conrelid or contypid is zero, this will separately enforce
uniqueness of constraint names among constraints of any one table and any
one domain. (If we ever implement SQL assertions, and put them into this
catalog, more thought might be needed. But it'd be at least as reasonable
to put them into a new catalog; having overloaded this one catalog with
two kinds of constraints was a mistake already IMO.) This index can replace
the existing non-unique index on conrelid, though we need to keep the one
on contypid for query performance reasons.
Having done that, we can simplify the logic in various places that either
coped with duplicates or neglected to, as well as potentially improve
lookup performance when searching for a constraint by name.
Also, as per our usual practice, install a preliminary check so that you
get something more friendly than a unique-index violation report in the
case complained of by André. And teach ChooseIndexName to avoid choosing
autogenerated names that would draw such a failure.
While it's not possible to make such a change in the back branches,
it doesn't seem quite too late to put this into v11, so do so.
Discussion: https://postgr.es/m/0c1001d4428f$0942b430$1bc81c90$@webkr.de
2018-09-04 19:45:35 +02:00
|
|
|
if (!isNull)
|
2017-11-06 10:19:22 +01:00
|
|
|
{
|
Fully enforce uniqueness of constraint names.
It's been true for a long time that we expect names of table and domain
constraints to be unique among the constraints of that table or domain.
However, the enforcement of that has been pretty haphazard, and it missed
some corner cases such as creating a CHECK constraint and then an index
constraint of the same name (as per recent report from André Hänsel).
Also, due to the lack of an actual unique index enforcing this, duplicates
could be created through race conditions.
Moreover, the code that searches pg_constraint has been quite inconsistent
about how to handle duplicate names if one did occur: some places checked
and threw errors if there was more than one match, while others just
processed the first match they came to.
To fix, create a unique index on (conrelid, contypid, conname). Since
either conrelid or contypid is zero, this will separately enforce
uniqueness of constraint names among constraints of any one table and any
one domain. (If we ever implement SQL assertions, and put them into this
catalog, more thought might be needed. But it'd be at least as reasonable
to put them into a new catalog; having overloaded this one catalog with
two kinds of constraints was a mistake already IMO.) This index can replace
the existing non-unique index on conrelid, though we need to keep the one
on contypid for query performance reasons.
Having done that, we can simplify the logic in various places that either
coped with duplicates or neglected to, as well as potentially improve
lookup performance when searching for a constraint by name.
Also, as per our usual practice, install a preliminary check so that you
get something more friendly than a unique-index violation report in the
case complained of by André. And teach ChooseIndexName to avoid choosing
autogenerated names that would draw such a failure.
While it's not possible to make such a change in the back branches,
it doesn't seem quite too late to put this into v11, so do so.
Discussion: https://postgr.es/m/0c1001d4428f$0942b430$1bc81c90$@webkr.de
2018-09-04 19:45:35 +02:00
|
|
|
ArrayType *arr;
|
|
|
|
int numcols;
|
|
|
|
int16 *attnums;
|
|
|
|
int i;
|
|
|
|
|
|
|
|
arr = DatumGetArrayTypeP(adatum); /* ensure not toasted */
|
|
|
|
numcols = ARR_DIMS(arr)[0];
|
|
|
|
if (ARR_NDIM(arr) != 1 ||
|
|
|
|
numcols < 0 ||
|
|
|
|
ARR_HASNULL(arr) ||
|
|
|
|
ARR_ELEMTYPE(arr) != INT2OID)
|
|
|
|
elog(ERROR, "conkey is not a 1-D smallint array");
|
|
|
|
attnums = (int16 *) ARR_DATA_PTR(arr);
|
|
|
|
|
|
|
|
/* Construct the result value */
|
|
|
|
for (i = 0; i < numcols; i++)
|
|
|
|
{
|
|
|
|
conattnos = bms_add_member(conattnos,
|
|
|
|
attnums[i] - FirstLowInvalidHeapAttributeNumber);
|
|
|
|
}
|
2017-11-06 10:19:22 +01:00
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
systable_endscan(scan);
|
|
|
|
|
|
|
|
/* If no such constraint exists, complain */
|
|
|
|
if (!OidIsValid(*constraintOid) && !missing_ok)
|
|
|
|
ereport(ERROR,
|
|
|
|
(errcode(ERRCODE_UNDEFINED_OBJECT),
|
|
|
|
errmsg("constraint \"%s\" for table \"%s\" does not exist",
|
|
|
|
conname, get_rel_name(relid))));
|
|
|
|
|
|
|
|
heap_close(pg_constraint, AccessShareLock);
|
|
|
|
|
|
|
|
return conattnos;
|
|
|
|
}
|
|
|
|
|
2018-02-19 20:59:37 +01:00
|
|
|
/*
|
|
|
|
* Return the OID of the constraint associated with the given index in the
|
|
|
|
* given relation; or InvalidOid if no such index is catalogued.
|
|
|
|
*/
|
|
|
|
Oid
|
|
|
|
get_relation_idx_constraint_oid(Oid relationId, Oid indexId)
|
|
|
|
{
|
|
|
|
Relation pg_constraint;
|
2018-04-26 20:47:16 +02:00
|
|
|
SysScanDesc scan;
|
|
|
|
ScanKeyData key;
|
2018-02-19 20:59:37 +01:00
|
|
|
HeapTuple tuple;
|
|
|
|
Oid constraintId = InvalidOid;
|
|
|
|
|
|
|
|
pg_constraint = heap_open(ConstraintRelationId, AccessShareLock);
|
|
|
|
|
|
|
|
ScanKeyInit(&key,
|
|
|
|
Anum_pg_constraint_conrelid,
|
|
|
|
BTEqualStrategyNumber,
|
|
|
|
F_OIDEQ,
|
|
|
|
ObjectIdGetDatum(relationId));
|
Fully enforce uniqueness of constraint names.
It's been true for a long time that we expect names of table and domain
constraints to be unique among the constraints of that table or domain.
However, the enforcement of that has been pretty haphazard, and it missed
some corner cases such as creating a CHECK constraint and then an index
constraint of the same name (as per recent report from André Hänsel).
Also, due to the lack of an actual unique index enforcing this, duplicates
could be created through race conditions.
Moreover, the code that searches pg_constraint has been quite inconsistent
about how to handle duplicate names if one did occur: some places checked
and threw errors if there was more than one match, while others just
processed the first match they came to.
To fix, create a unique index on (conrelid, contypid, conname). Since
either conrelid or contypid is zero, this will separately enforce
uniqueness of constraint names among constraints of any one table and any
one domain. (If we ever implement SQL assertions, and put them into this
catalog, more thought might be needed. But it'd be at least as reasonable
to put them into a new catalog; having overloaded this one catalog with
two kinds of constraints was a mistake already IMO.) This index can replace
the existing non-unique index on conrelid, though we need to keep the one
on contypid for query performance reasons.
Having done that, we can simplify the logic in various places that either
coped with duplicates or neglected to, as well as potentially improve
lookup performance when searching for a constraint by name.
Also, as per our usual practice, install a preliminary check so that you
get something more friendly than a unique-index violation report in the
case complained of by André. And teach ChooseIndexName to avoid choosing
autogenerated names that would draw such a failure.
While it's not possible to make such a change in the back branches,
it doesn't seem quite too late to put this into v11, so do so.
Discussion: https://postgr.es/m/0c1001d4428f$0942b430$1bc81c90$@webkr.de
2018-09-04 19:45:35 +02:00
|
|
|
scan = systable_beginscan(pg_constraint, ConstraintRelidTypidNameIndexId,
|
2018-02-19 20:59:37 +01:00
|
|
|
true, NULL, 1, &key);
|
|
|
|
while ((tuple = systable_getnext(scan)) != NULL)
|
|
|
|
{
|
2018-04-26 20:47:16 +02:00
|
|
|
Form_pg_constraint constrForm;
|
2018-02-19 20:59:37 +01:00
|
|
|
|
|
|
|
constrForm = (Form_pg_constraint) GETSTRUCT(tuple);
|
|
|
|
if (constrForm->conindid == indexId)
|
|
|
|
{
|
|
|
|
constraintId = HeapTupleGetOid(tuple);
|
|
|
|
break;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
systable_endscan(scan);
|
|
|
|
|
|
|
|
heap_close(pg_constraint, AccessShareLock);
|
|
|
|
return constraintId;
|
|
|
|
}
|
|
|
|
|
2012-04-03 07:11:51 +02:00
|
|
|
/*
|
|
|
|
* get_domain_constraint_oid
|
|
|
|
* Find a constraint on the specified domain with the specified name.
|
|
|
|
* Returns constraint's OID.
|
|
|
|
*/
|
|
|
|
Oid
|
|
|
|
get_domain_constraint_oid(Oid typid, const char *conname, bool missing_ok)
|
|
|
|
{
|
|
|
|
Relation pg_constraint;
|
|
|
|
HeapTuple tuple;
|
|
|
|
SysScanDesc scan;
|
Fully enforce uniqueness of constraint names.
It's been true for a long time that we expect names of table and domain
constraints to be unique among the constraints of that table or domain.
However, the enforcement of that has been pretty haphazard, and it missed
some corner cases such as creating a CHECK constraint and then an index
constraint of the same name (as per recent report from André Hänsel).
Also, due to the lack of an actual unique index enforcing this, duplicates
could be created through race conditions.
Moreover, the code that searches pg_constraint has been quite inconsistent
about how to handle duplicate names if one did occur: some places checked
and threw errors if there was more than one match, while others just
processed the first match they came to.
To fix, create a unique index on (conrelid, contypid, conname). Since
either conrelid or contypid is zero, this will separately enforce
uniqueness of constraint names among constraints of any one table and any
one domain. (If we ever implement SQL assertions, and put them into this
catalog, more thought might be needed. But it'd be at least as reasonable
to put them into a new catalog; having overloaded this one catalog with
two kinds of constraints was a mistake already IMO.) This index can replace
the existing non-unique index on conrelid, though we need to keep the one
on contypid for query performance reasons.
Having done that, we can simplify the logic in various places that either
coped with duplicates or neglected to, as well as potentially improve
lookup performance when searching for a constraint by name.
Also, as per our usual practice, install a preliminary check so that you
get something more friendly than a unique-index violation report in the
case complained of by André. And teach ChooseIndexName to avoid choosing
autogenerated names that would draw such a failure.
While it's not possible to make such a change in the back branches,
it doesn't seem quite too late to put this into v11, so do so.
Discussion: https://postgr.es/m/0c1001d4428f$0942b430$1bc81c90$@webkr.de
2018-09-04 19:45:35 +02:00
|
|
|
ScanKeyData skey[3];
|
2012-04-03 07:11:51 +02:00
|
|
|
Oid conOid = InvalidOid;
|
|
|
|
|
|
|
|
pg_constraint = heap_open(ConstraintRelationId, AccessShareLock);
|
|
|
|
|
|
|
|
ScanKeyInit(&skey[0],
|
Fully enforce uniqueness of constraint names.
It's been true for a long time that we expect names of table and domain
constraints to be unique among the constraints of that table or domain.
However, the enforcement of that has been pretty haphazard, and it missed
some corner cases such as creating a CHECK constraint and then an index
constraint of the same name (as per recent report from André Hänsel).
Also, due to the lack of an actual unique index enforcing this, duplicates
could be created through race conditions.
Moreover, the code that searches pg_constraint has been quite inconsistent
about how to handle duplicate names if one did occur: some places checked
and threw errors if there was more than one match, while others just
processed the first match they came to.
To fix, create a unique index on (conrelid, contypid, conname). Since
either conrelid or contypid is zero, this will separately enforce
uniqueness of constraint names among constraints of any one table and any
one domain. (If we ever implement SQL assertions, and put them into this
catalog, more thought might be needed. But it'd be at least as reasonable
to put them into a new catalog; having overloaded this one catalog with
two kinds of constraints was a mistake already IMO.) This index can replace
the existing non-unique index on conrelid, though we need to keep the one
on contypid for query performance reasons.
Having done that, we can simplify the logic in various places that either
coped with duplicates or neglected to, as well as potentially improve
lookup performance when searching for a constraint by name.
Also, as per our usual practice, install a preliminary check so that you
get something more friendly than a unique-index violation report in the
case complained of by André. And teach ChooseIndexName to avoid choosing
autogenerated names that would draw such a failure.
While it's not possible to make such a change in the back branches,
it doesn't seem quite too late to put this into v11, so do so.
Discussion: https://postgr.es/m/0c1001d4428f$0942b430$1bc81c90$@webkr.de
2018-09-04 19:45:35 +02:00
|
|
|
Anum_pg_constraint_conrelid,
|
|
|
|
BTEqualStrategyNumber, F_OIDEQ,
|
|
|
|
ObjectIdGetDatum(InvalidOid));
|
|
|
|
ScanKeyInit(&skey[1],
|
2012-04-03 07:11:51 +02:00
|
|
|
Anum_pg_constraint_contypid,
|
|
|
|
BTEqualStrategyNumber, F_OIDEQ,
|
|
|
|
ObjectIdGetDatum(typid));
|
Fully enforce uniqueness of constraint names.
It's been true for a long time that we expect names of table and domain
constraints to be unique among the constraints of that table or domain.
However, the enforcement of that has been pretty haphazard, and it missed
some corner cases such as creating a CHECK constraint and then an index
constraint of the same name (as per recent report from André Hänsel).
Also, due to the lack of an actual unique index enforcing this, duplicates
could be created through race conditions.
Moreover, the code that searches pg_constraint has been quite inconsistent
about how to handle duplicate names if one did occur: some places checked
and threw errors if there was more than one match, while others just
processed the first match they came to.
To fix, create a unique index on (conrelid, contypid, conname). Since
either conrelid or contypid is zero, this will separately enforce
uniqueness of constraint names among constraints of any one table and any
one domain. (If we ever implement SQL assertions, and put them into this
catalog, more thought might be needed. But it'd be at least as reasonable
to put them into a new catalog; having overloaded this one catalog with
two kinds of constraints was a mistake already IMO.) This index can replace
the existing non-unique index on conrelid, though we need to keep the one
on contypid for query performance reasons.
Having done that, we can simplify the logic in various places that either
coped with duplicates or neglected to, as well as potentially improve
lookup performance when searching for a constraint by name.
Also, as per our usual practice, install a preliminary check so that you
get something more friendly than a unique-index violation report in the
case complained of by André. And teach ChooseIndexName to avoid choosing
autogenerated names that would draw such a failure.
While it's not possible to make such a change in the back branches,
it doesn't seem quite too late to put this into v11, so do so.
Discussion: https://postgr.es/m/0c1001d4428f$0942b430$1bc81c90$@webkr.de
2018-09-04 19:45:35 +02:00
|
|
|
ScanKeyInit(&skey[2],
|
|
|
|
Anum_pg_constraint_conname,
|
|
|
|
BTEqualStrategyNumber, F_NAMEEQ,
|
|
|
|
CStringGetDatum(conname));
|
2012-04-03 07:11:51 +02:00
|
|
|
|
Fully enforce uniqueness of constraint names.
It's been true for a long time that we expect names of table and domain
constraints to be unique among the constraints of that table or domain.
However, the enforcement of that has been pretty haphazard, and it missed
some corner cases such as creating a CHECK constraint and then an index
constraint of the same name (as per recent report from André Hänsel).
Also, due to the lack of an actual unique index enforcing this, duplicates
could be created through race conditions.
Moreover, the code that searches pg_constraint has been quite inconsistent
about how to handle duplicate names if one did occur: some places checked
and threw errors if there was more than one match, while others just
processed the first match they came to.
To fix, create a unique index on (conrelid, contypid, conname). Since
either conrelid or contypid is zero, this will separately enforce
uniqueness of constraint names among constraints of any one table and any
one domain. (If we ever implement SQL assertions, and put them into this
catalog, more thought might be needed. But it'd be at least as reasonable
to put them into a new catalog; having overloaded this one catalog with
two kinds of constraints was a mistake already IMO.) This index can replace
the existing non-unique index on conrelid, though we need to keep the one
on contypid for query performance reasons.
Having done that, we can simplify the logic in various places that either
coped with duplicates or neglected to, as well as potentially improve
lookup performance when searching for a constraint by name.
Also, as per our usual practice, install a preliminary check so that you
get something more friendly than a unique-index violation report in the
case complained of by André. And teach ChooseIndexName to avoid choosing
autogenerated names that would draw such a failure.
While it's not possible to make such a change in the back branches,
it doesn't seem quite too late to put this into v11, so do so.
Discussion: https://postgr.es/m/0c1001d4428f$0942b430$1bc81c90$@webkr.de
2018-09-04 19:45:35 +02:00
|
|
|
scan = systable_beginscan(pg_constraint, ConstraintRelidTypidNameIndexId, true,
|
|
|
|
NULL, 3, skey);
|
2012-04-03 07:11:51 +02:00
|
|
|
|
Fully enforce uniqueness of constraint names.
It's been true for a long time that we expect names of table and domain
constraints to be unique among the constraints of that table or domain.
However, the enforcement of that has been pretty haphazard, and it missed
some corner cases such as creating a CHECK constraint and then an index
constraint of the same name (as per recent report from André Hänsel).
Also, due to the lack of an actual unique index enforcing this, duplicates
could be created through race conditions.
Moreover, the code that searches pg_constraint has been quite inconsistent
about how to handle duplicate names if one did occur: some places checked
and threw errors if there was more than one match, while others just
processed the first match they came to.
To fix, create a unique index on (conrelid, contypid, conname). Since
either conrelid or contypid is zero, this will separately enforce
uniqueness of constraint names among constraints of any one table and any
one domain. (If we ever implement SQL assertions, and put them into this
catalog, more thought might be needed. But it'd be at least as reasonable
to put them into a new catalog; having overloaded this one catalog with
two kinds of constraints was a mistake already IMO.) This index can replace
the existing non-unique index on conrelid, though we need to keep the one
on contypid for query performance reasons.
Having done that, we can simplify the logic in various places that either
coped with duplicates or neglected to, as well as potentially improve
lookup performance when searching for a constraint by name.
Also, as per our usual practice, install a preliminary check so that you
get something more friendly than a unique-index violation report in the
case complained of by André. And teach ChooseIndexName to avoid choosing
autogenerated names that would draw such a failure.
While it's not possible to make such a change in the back branches,
it doesn't seem quite too late to put this into v11, so do so.
Discussion: https://postgr.es/m/0c1001d4428f$0942b430$1bc81c90$@webkr.de
2018-09-04 19:45:35 +02:00
|
|
|
/* There can be at most one matching row */
|
|
|
|
if (HeapTupleIsValid(tuple = systable_getnext(scan)))
|
|
|
|
conOid = HeapTupleGetOid(tuple);
|
2012-04-03 07:11:51 +02:00
|
|
|
|
|
|
|
systable_endscan(scan);
|
|
|
|
|
|
|
|
/* If no such constraint exists, complain */
|
|
|
|
if (!OidIsValid(conOid) && !missing_ok)
|
|
|
|
ereport(ERROR,
|
|
|
|
(errcode(ERRCODE_UNDEFINED_OBJECT),
|
2017-05-30 03:48:26 +02:00
|
|
|
errmsg("constraint \"%s\" for domain %s does not exist",
|
2012-04-03 07:11:51 +02:00
|
|
|
conname, format_type_be(typid))));
|
|
|
|
|
|
|
|
heap_close(pg_constraint, AccessShareLock);
|
|
|
|
|
|
|
|
return conOid;
|
|
|
|
}
|
|
|
|
|
2016-02-11 23:34:59 +01:00
|
|
|
/*
|
|
|
|
* get_primary_key_attnos
|
|
|
|
* Identify the columns in a relation's primary key, if any.
|
|
|
|
*
|
|
|
|
* Returns a Bitmapset of the column attnos of the primary key's columns,
|
|
|
|
* with attnos being offset by FirstLowInvalidHeapAttributeNumber so that
|
|
|
|
* system columns can be represented.
|
|
|
|
*
|
|
|
|
* If there is no primary key, return NULL. We also return NULL if the pkey
|
|
|
|
* constraint is deferrable and deferrableOk is false.
|
|
|
|
*
|
|
|
|
* *constraintOid is set to the OID of the pkey constraint, or InvalidOid
|
|
|
|
* on failure.
|
|
|
|
*/
|
|
|
|
Bitmapset *
|
|
|
|
get_primary_key_attnos(Oid relid, bool deferrableOk, Oid *constraintOid)
|
|
|
|
{
|
|
|
|
Bitmapset *pkattnos = NULL;
|
|
|
|
Relation pg_constraint;
|
|
|
|
HeapTuple tuple;
|
|
|
|
SysScanDesc scan;
|
|
|
|
ScanKeyData skey[1];
|
|
|
|
|
|
|
|
/* Set *constraintOid, to avoid complaints about uninitialized vars */
|
|
|
|
*constraintOid = InvalidOid;
|
|
|
|
|
|
|
|
/* Scan pg_constraint for constraints of the target rel */
|
|
|
|
pg_constraint = heap_open(ConstraintRelationId, AccessShareLock);
|
|
|
|
|
|
|
|
ScanKeyInit(&skey[0],
|
|
|
|
Anum_pg_constraint_conrelid,
|
|
|
|
BTEqualStrategyNumber, F_OIDEQ,
|
|
|
|
ObjectIdGetDatum(relid));
|
|
|
|
|
Fully enforce uniqueness of constraint names.
It's been true for a long time that we expect names of table and domain
constraints to be unique among the constraints of that table or domain.
However, the enforcement of that has been pretty haphazard, and it missed
some corner cases such as creating a CHECK constraint and then an index
constraint of the same name (as per recent report from André Hänsel).
Also, due to the lack of an actual unique index enforcing this, duplicates
could be created through race conditions.
Moreover, the code that searches pg_constraint has been quite inconsistent
about how to handle duplicate names if one did occur: some places checked
and threw errors if there was more than one match, while others just
processed the first match they came to.
To fix, create a unique index on (conrelid, contypid, conname). Since
either conrelid or contypid is zero, this will separately enforce
uniqueness of constraint names among constraints of any one table and any
one domain. (If we ever implement SQL assertions, and put them into this
catalog, more thought might be needed. But it'd be at least as reasonable
to put them into a new catalog; having overloaded this one catalog with
two kinds of constraints was a mistake already IMO.) This index can replace
the existing non-unique index on conrelid, though we need to keep the one
on contypid for query performance reasons.
Having done that, we can simplify the logic in various places that either
coped with duplicates or neglected to, as well as potentially improve
lookup performance when searching for a constraint by name.
Also, as per our usual practice, install a preliminary check so that you
get something more friendly than a unique-index violation report in the
case complained of by André. And teach ChooseIndexName to avoid choosing
autogenerated names that would draw such a failure.
While it's not possible to make such a change in the back branches,
it doesn't seem quite too late to put this into v11, so do so.
Discussion: https://postgr.es/m/0c1001d4428f$0942b430$1bc81c90$@webkr.de
2018-09-04 19:45:35 +02:00
|
|
|
scan = systable_beginscan(pg_constraint, ConstraintRelidTypidNameIndexId, true,
|
2016-02-11 23:34:59 +01:00
|
|
|
NULL, 1, skey);
|
|
|
|
|
|
|
|
while (HeapTupleIsValid(tuple = systable_getnext(scan)))
|
|
|
|
{
|
|
|
|
Form_pg_constraint con = (Form_pg_constraint) GETSTRUCT(tuple);
|
|
|
|
Datum adatum;
|
|
|
|
bool isNull;
|
|
|
|
ArrayType *arr;
|
|
|
|
int16 *attnums;
|
|
|
|
int numkeys;
|
|
|
|
int i;
|
|
|
|
|
|
|
|
/* Skip constraints that are not PRIMARY KEYs */
|
|
|
|
if (con->contype != CONSTRAINT_PRIMARY)
|
|
|
|
continue;
|
|
|
|
|
|
|
|
/*
|
|
|
|
* If the primary key is deferrable, but we've been instructed to
|
|
|
|
* ignore deferrable constraints, then we might as well give up
|
|
|
|
* searching, since there can only be a single primary key on a table.
|
|
|
|
*/
|
|
|
|
if (con->condeferrable && !deferrableOk)
|
|
|
|
break;
|
|
|
|
|
|
|
|
/* Extract the conkey array, ie, attnums of PK's columns */
|
|
|
|
adatum = heap_getattr(tuple, Anum_pg_constraint_conkey,
|
|
|
|
RelationGetDescr(pg_constraint), &isNull);
|
|
|
|
if (isNull)
|
|
|
|
elog(ERROR, "null conkey for constraint %u",
|
|
|
|
HeapTupleGetOid(tuple));
|
Phase 2 of pgindent updates.
Change pg_bsd_indent to follow upstream rules for placement of comments
to the right of code, and remove pgindent hack that caused comments
following #endif to not obey the general rule.
Commit e3860ffa4dd0dad0dd9eea4be9cc1412373a8c89 wasn't actually using
the published version of pg_bsd_indent, but a hacked-up version that
tried to minimize the amount of movement of comments to the right of
code. The situation of interest is where such a comment has to be
moved to the right of its default placement at column 33 because there's
code there. BSD indent has always moved right in units of tab stops
in such cases --- but in the previous incarnation, indent was working
in 8-space tab stops, while now it knows we use 4-space tabs. So the
net result is that in about half the cases, such comments are placed
one tab stop left of before. This is better all around: it leaves
more room on the line for comment text, and it means that in such
cases the comment uniformly starts at the next 4-space tab stop after
the code, rather than sometimes one and sometimes two tabs after.
Also, ensure that comments following #endif are indented the same
as comments following other preprocessor commands such as #else.
That inconsistency turns out to have been self-inflicted damage
from a poorly-thought-through post-indent "fixup" in pgindent.
This patch is much less interesting than the first round of indent
changes, but also bulkier, so I thought it best to separate the effects.
Discussion: https://postgr.es/m/E1dAmxK-0006EE-1r@gemulon.postgresql.org
Discussion: https://postgr.es/m/30527.1495162840@sss.pgh.pa.us
2017-06-21 21:18:54 +02:00
|
|
|
arr = DatumGetArrayTypeP(adatum); /* ensure not toasted */
|
2016-02-11 23:34:59 +01:00
|
|
|
numkeys = ARR_DIMS(arr)[0];
|
|
|
|
if (ARR_NDIM(arr) != 1 ||
|
|
|
|
numkeys < 0 ||
|
|
|
|
ARR_HASNULL(arr) ||
|
|
|
|
ARR_ELEMTYPE(arr) != INT2OID)
|
|
|
|
elog(ERROR, "conkey is not a 1-D smallint array");
|
|
|
|
attnums = (int16 *) ARR_DATA_PTR(arr);
|
|
|
|
|
|
|
|
/* Construct the result value */
|
|
|
|
for (i = 0; i < numkeys; i++)
|
|
|
|
{
|
|
|
|
pkattnos = bms_add_member(pkattnos,
|
Phase 3 of pgindent updates.
Don't move parenthesized lines to the left, even if that means they
flow past the right margin.
By default, BSD indent lines up statement continuation lines that are
within parentheses so that they start just to the right of the preceding
left parenthesis. However, traditionally, if that resulted in the
continuation line extending to the right of the desired right margin,
then indent would push it left just far enough to not overrun the margin,
if it could do so without making the continuation line start to the left of
the current statement indent. That makes for a weird mix of indentations
unless one has been completely rigid about never violating the 80-column
limit.
This behavior has been pretty universally panned by Postgres developers.
Hence, disable it with indent's new -lpl switch, so that parenthesized
lines are always lined up with the preceding left paren.
This patch is much less interesting than the first round of indent
changes, but also bulkier, so I thought it best to separate the effects.
Discussion: https://postgr.es/m/E1dAmxK-0006EE-1r@gemulon.postgresql.org
Discussion: https://postgr.es/m/30527.1495162840@sss.pgh.pa.us
2017-06-21 21:35:54 +02:00
|
|
|
attnums[i] - FirstLowInvalidHeapAttributeNumber);
|
2016-02-11 23:34:59 +01:00
|
|
|
}
|
|
|
|
*constraintOid = HeapTupleGetOid(tuple);
|
|
|
|
|
|
|
|
/* No need to search further */
|
|
|
|
break;
|
|
|
|
}
|
|
|
|
|
|
|
|
systable_endscan(scan);
|
|
|
|
|
|
|
|
heap_close(pg_constraint, AccessShareLock);
|
|
|
|
|
|
|
|
return pkattnos;
|
|
|
|
}
|
|
|
|
|
2010-08-07 04:44:09 +02:00
|
|
|
/*
|
|
|
|
* Determine whether a relation can be proven functionally dependent on
|
2017-08-16 06:22:32 +02:00
|
|
|
* a set of grouping columns. If so, return true and add the pg_constraint
|
2010-08-07 04:44:09 +02:00
|
|
|
* OIDs of the constraints needed for the proof to the *constraintDeps list.
|
|
|
|
*
|
|
|
|
* grouping_columns is a list of grouping expressions, in which columns of
|
|
|
|
* the rel of interest are Vars with the indicated varno/varlevelsup.
|
|
|
|
*
|
|
|
|
* Currently we only check to see if the rel has a primary key that is a
|
2014-05-06 18:12:18 +02:00
|
|
|
* subset of the grouping_columns. We could also use plain unique constraints
|
2010-08-07 04:44:09 +02:00
|
|
|
* if all their columns are known not null, but there's a problem: we need
|
|
|
|
* to be able to represent the not-null-ness as part of the constraints added
|
2014-05-06 18:12:18 +02:00
|
|
|
* to *constraintDeps. FIXME whenever not-null constraints get represented
|
2010-08-07 04:44:09 +02:00
|
|
|
* in pg_constraint.
|
|
|
|
*/
|
|
|
|
bool
|
|
|
|
check_functional_grouping(Oid relid,
|
|
|
|
Index varno, Index varlevelsup,
|
|
|
|
List *grouping_columns,
|
|
|
|
List **constraintDeps)
|
|
|
|
{
|
2016-02-11 23:52:03 +01:00
|
|
|
Bitmapset *pkattnos;
|
|
|
|
Bitmapset *groupbyattnos;
|
|
|
|
Oid constraintOid;
|
|
|
|
ListCell *gl;
|
|
|
|
|
|
|
|
/* If the rel has no PK, then we can't prove functional dependency */
|
|
|
|
pkattnos = get_primary_key_attnos(relid, false, &constraintOid);
|
|
|
|
if (pkattnos == NULL)
|
|
|
|
return false;
|
|
|
|
|
|
|
|
/* Identify all the rel's columns that appear in grouping_columns */
|
|
|
|
groupbyattnos = NULL;
|
|
|
|
foreach(gl, grouping_columns)
|
2010-08-07 04:44:09 +02:00
|
|
|
{
|
2016-02-11 23:52:03 +01:00
|
|
|
Var *gvar = (Var *) lfirst(gl);
|
2010-08-07 04:44:09 +02:00
|
|
|
|
2016-02-11 23:52:03 +01:00
|
|
|
if (IsA(gvar, Var) &&
|
|
|
|
gvar->varno == varno &&
|
|
|
|
gvar->varlevelsup == varlevelsup)
|
|
|
|
groupbyattnos = bms_add_member(groupbyattnos,
|
Phase 3 of pgindent updates.
Don't move parenthesized lines to the left, even if that means they
flow past the right margin.
By default, BSD indent lines up statement continuation lines that are
within parentheses so that they start just to the right of the preceding
left parenthesis. However, traditionally, if that resulted in the
continuation line extending to the right of the desired right margin,
then indent would push it left just far enough to not overrun the margin,
if it could do so without making the continuation line start to the left of
the current statement indent. That makes for a weird mix of indentations
unless one has been completely rigid about never violating the 80-column
limit.
This behavior has been pretty universally panned by Postgres developers.
Hence, disable it with indent's new -lpl switch, so that parenthesized
lines are always lined up with the preceding left paren.
This patch is much less interesting than the first round of indent
changes, but also bulkier, so I thought it best to separate the effects.
Discussion: https://postgr.es/m/E1dAmxK-0006EE-1r@gemulon.postgresql.org
Discussion: https://postgr.es/m/30527.1495162840@sss.pgh.pa.us
2017-06-21 21:35:54 +02:00
|
|
|
gvar->varattno - FirstLowInvalidHeapAttributeNumber);
|
2010-08-07 04:44:09 +02:00
|
|
|
}
|
|
|
|
|
2016-02-11 23:52:03 +01:00
|
|
|
if (bms_is_subset(pkattnos, groupbyattnos))
|
|
|
|
{
|
|
|
|
/* The PK is a subset of grouping_columns, so we win */
|
|
|
|
*constraintDeps = lappend_oid(*constraintDeps, constraintOid);
|
|
|
|
return true;
|
|
|
|
}
|
2010-08-07 04:44:09 +02:00
|
|
|
|
2016-02-11 23:52:03 +01:00
|
|
|
return false;
|
2010-08-07 04:44:09 +02:00
|
|
|
}
|