Don't clean initdb files on template creation failure
Commit 252dcb3239
introduced initdb template caching to speed up
tests by re-using initdb output. The initdb command didn't however
use the --no-clean option to preserve generated data in case initdb
crashes unlike pg_regress which does do this. This adds the option
to initdb to aid debugging.
While changing the commandline, switch to using long options for
initdb to make the code more self-documenting.
Author: Matthias van de Meent <boekewurm+postgres@gmail.com>
Discussion: https://postgr.es/m/CAEze2WhSTjfK_M+Ea4GSQp8odrEOaQS8HyORd1TJUEiyXaB+rw@mail.gmail.com
This commit is contained in:
parent
44913add91
commit
00edb2061f
|
@ -3116,7 +3116,8 @@ sys.exit(sp.returncode)
|
|||
''',
|
||||
test_initdb_template,
|
||||
temp_install_bindir / 'initdb',
|
||||
'-A', 'trust', '-N', '--no-instructions', '--no-locale'
|
||||
'--auth', 'trust', '--no-sync', '--no-instructions', '--no-locale',
|
||||
'--no-clean'
|
||||
],
|
||||
priority: setup_tests_priority - 1,
|
||||
timeout: 300,
|
||||
|
|
|
@ -423,7 +423,7 @@ ifeq ($(MAKELEVEL),0)
|
|||
$(MAKE) -C '$(top_builddir)' DESTDIR='$(abs_top_builddir)'/tmp_install install >'$(abs_top_builddir)'/tmp_install/log/install.log 2>&1
|
||||
$(MAKE) -j1 $(if $(CHECKPREP_TOP),-C $(CHECKPREP_TOP),) checkprep >>'$(abs_top_builddir)'/tmp_install/log/install.log 2>&1
|
||||
|
||||
$(with_temp_install) initdb -A trust -N --no-instructions --no-locale '$(abs_top_builddir)'/tmp_install/initdb-template >>'$(abs_top_builddir)'/tmp_install/log/initdb-template.log 2>&1
|
||||
$(with_temp_install) initdb --auth trust --no-sync --no-instructions --no-locale --no-clean '$(abs_top_builddir)'/tmp_install/initdb-template >>'$(abs_top_builddir)'/tmp_install/log/initdb-template.log 2>&1
|
||||
endif
|
||||
endif
|
||||
endif
|
||||
|
|
Loading…
Reference in New Issue