From 01357f1da94b9926336448d88ac519f20ab27cd7 Mon Sep 17 00:00:00 2001 From: Masahiko Sawada Date: Wed, 2 Aug 2023 15:01:08 +0900 Subject: [PATCH] Fix ReorderBufferCheckMemoryLimit() comment. Commit 7259736a6 updated the comment but it was not correct since ReorderBufferLargestStreamableTopTXN() returns only top-level transactions. Reviewed-by: Amit Kapila Discussion: https://postgr.es/m/CAD21AoA9XB7OR86BqvrCe2dMYX%2BZv3-BvVmjF%3DGY2z6jN-kqjg%40mail.gmail.com Backpatch-through: 14 --- src/backend/replication/logical/reorderbuffer.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/backend/replication/logical/reorderbuffer.c b/src/backend/replication/logical/reorderbuffer.c index b1882ae5ec..3a68a393d2 100644 --- a/src/backend/replication/logical/reorderbuffer.c +++ b/src/backend/replication/logical/reorderbuffer.c @@ -3507,8 +3507,8 @@ ReorderBufferCheckMemoryLimit(ReorderBuffer *rb) while (rb->size >= logical_decoding_work_mem * 1024L) { /* - * Pick the largest transaction (or subtransaction) and evict it from - * memory by streaming, if possible. Otherwise, spill to disk. + * Pick the largest transaction and evict it from memory by streaming, + * if possible. Otherwise, spill to disk. */ if (ReorderBufferCanStartStreaming(rb) && (txn = ReorderBufferLargestTopTXN(rb)) != NULL)