From 01be9d498fa4b836ec3dbf035b6743c8b8f34767 Mon Sep 17 00:00:00 2001 From: Michael Paquier Date: Thu, 22 Dec 2022 12:08:45 +0900 Subject: [PATCH] Fix operator typo in tablecmds.c A bitwise operator was getting used on two bools in ATAddCheckConstraint() to track if constraints should be merged or not with the existing ones of a relation, though obviously this should use a boolean OR operator. This led to the same result, but let's be clean. Oversight in 074c5cf. Author: Ranier Vilela Reviewed-by: Justin Pryzby Discussion: https://postgr.es/m/CAEudQAp2R2fbbi0OHHhv_n4=Ch0t1VtjObR9YMqtGKHJ+faUFQ@mail.gmail.com --- src/backend/commands/tablecmds.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/backend/commands/tablecmds.c b/src/backend/commands/tablecmds.c index 56dc995713..4bea7b3c90 100644 --- a/src/backend/commands/tablecmds.c +++ b/src/backend/commands/tablecmds.c @@ -8863,7 +8863,7 @@ ATAddCheckConstraint(List **wqueue, AlteredTableInfo *tab, Relation rel, */ newcons = AddRelationNewConstraints(rel, NIL, list_make1(copyObject(constr)), - recursing | is_readd, /* allow_merge */ + recursing || is_readd, /* allow_merge */ !recursing, /* is_local */ is_readd, /* is_internal */ NULL); /* queryString not available