From 0516f94d18c57cc5dce72ff8fb84a05d24a67063 Mon Sep 17 00:00:00 2001 From: Andrew Dunstan Date: Tue, 14 Apr 2020 16:55:34 -0400 Subject: [PATCH] Stop requiring an explicit return from perl subroutines The consensus of the project appears to be that this provides little benefit and is simply an annoyance. Discussion: https://postgr.es/m/27481.1586618092@sss.pgh.pa.us --- src/tools/perlcheck/perlcriticrc | 4 ---- 1 file changed, 4 deletions(-) diff --git a/src/tools/perlcheck/perlcriticrc b/src/tools/perlcheck/perlcriticrc index 314c83c6a5..e230111b23 100644 --- a/src/tools/perlcheck/perlcriticrc +++ b/src/tools/perlcheck/perlcriticrc @@ -22,7 +22,3 @@ verbose = %f: %m at line %l, column %c. %e. ([%p] Severity: %s)\n # insist on use of the warnings pragma [TestingAndDebugging::RequireUseWarnings] severity = 5 - -# for now raise severity of this to level 5 -[Subroutines::RequireFinalReturn] -severity = 5