rdelaage
/
postgresql
mirror of https://git.postgresql.org/git/postgresql.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

More trivial dead code removal: in int_to_roman(), checking for "num == -1" 

is redundant after a check has already been made for "num < 0". The "set"
variable can also be removed, as it is now no longer used. Per checking
with Karel, this is the right fix.

Per Coverity static analysis performed by EnterpriseDB.
This commit is contained in:
Neil Conway 2005-06-22 01:43:05 +00:00
parent ebcb4c931d
commit 06ecacded6
1 changed files with 2 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
src/backend/utils/adt/formatting.c
View File

@ -1,7 +1,7 @@
/* -----------------------------------------------------------------------
* formatting.c
*
* $PostgreSQL: pgsql/src/backend/utils/adt/formatting.c,v 1.88 2005/06/15 00:34:08 momjian Exp $
* $PostgreSQL: pgsql/src/backend/utils/adt/formatting.c,v 1.89 2005/06/22 01:43:05 neilc Exp $
*
*
* Portions Copyright (c) 1999-2005, PostgreSQL Global Development Group
@ -3508,8 +3508,7 @@ static char *
int_to_roman(int number)
{
int len = 0,
num = 0,
set = 0;
num = 0;
char *p = NULL,
*result,
numstr[5];
@ -3529,9 +3528,6 @@ int_to_roman(int number)
num = *p - 49; /* 48 ascii + 1 */
if (num < 0)
continue;
if (num == -1 && set == 0)
continue;
set = 1;
if (len > 3)
{