rdelaage
/
postgresql
mirror of https://git.postgresql.org/git/postgresql.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Rework how logirep launchers are stopped during pg_upgrade 

This is a rework of 7021d3b176, where we relied on forcing
max_logical_replication_workers to 0 in the postgres command.  This
commit now prevents logical replication launchers to start using -b and
a backend-side check based on IsBinaryUpgrade, effective when upgrading
from 17 and newer versions.

This commit improves the comments explaining why this restriction is
necessary.

This discussion was on hold until we were sure how to add support for
subscribers in pg_upgrade, something now done thanks to 9a17be1e24.

Reviewed-by: Álvaro Herrera, Amit Kapila, Tom Lane
Discussion: https://postgr.es/m/ZU2TeVkUg5qEi7Oy@paquier.xyz
This commit is contained in:
Michael Paquier 2024-01-12 08:23:07 +09:00
parent 7786af4d74
commit 08c3ad27eb
2 changed files with 13 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
src/backend/replication/logical/launcher.c
View File

@ -925,7 +925,14 @@ ApplyLauncherRegister(void)
{
BackgroundWorker bgw;
if (max_logical_replication_workers == 0)
/*
* The logical replication launcher is disabled during binary upgrades, to
* prevent logical replication workers from running on the source cluster.
* That could cause replication origins to move forward after having been
* copied to the target cluster, potentially creating conflicts with the
* copied data files.
*/
if (max_logical_replication_workers == 0 || IsBinaryUpgrade)
return;
memset(&bgw, 0, sizeof(bgw));

15
src/bin/pg_upgrade/server.c
View File

@ -248,19 +248,14 @@ start_postmaster(ClusterInfo *cluster, bool report_and_exit_on_error)
* invalidation of slots during the upgrade. We set this option when
* cluster is PG17 or later because logical replication slots can only be
* migrated since then. Besides, max_slot_wal_keep_size is added in PG13.
*
* Use max_logical_replication_workers as 0 to prevent a startup of the
* logical replication launcher while upgrading because it may start apply
* workers that could start receiving changes from the publisher before
* the physical files are put in place, causing corruption on the new
* cluster upgrading to. Like the previous parameter, this is set only
* when a cluster is PG17 or later as logical slots can only be migrated
* since this version.
*/
if (GET_MAJOR_VERSION(cluster->major_version) >= 1700)
appendPQExpBufferStr(&pgoptions, " -c max_slot_wal_keep_size=-1 -c max_logical_replication_workers=0");
appendPQExpBufferStr(&pgoptions, " -c max_slot_wal_keep_size=-1");
/* Use -b to disable autovacuum. */
/*
* Use -b to disable autovacuum and logical replication launcher
* (effective in PG17 or later for the latter).
*/
snprintf(cmd, sizeof(cmd),
"\"%s/pg_ctl\" -w -l \"%s/%s\" -D \"%s\" -o \"-p %d -b%s %s%s\" start",
cluster->bindir,