mirror of
https://git.postgresql.org/git/postgresql.git
synced 2024-10-08 10:46:59 +02:00
Fix memory leak in SnapBuildSerialize.
The memory for the snapshot was leaked while serializing it to disk during logical decoding. This memory will be freed only once walsender stops streaming the changes. This can lead to a huge memory increase when master logs Standby Snapshot too frequently say when the user is trying to create many replication slots. Reported-by: funnyxj.fxj@alibaba-inc.com Diagnosed-by: funnyxj.fxj@alibaba-inc.com Author: Amit Kapila Backpatch-through: 9.5 Discussion: https://postgr.es/m/033ab54c-6393-42ee-8ec9-2b399b5d8cde.funnyxj.fxj@alibaba-inc.com
This commit is contained in:
parent
436d9c5cab
commit
0b2ae3c928
@ -1485,7 +1485,7 @@ static void
|
|||||||
SnapBuildSerialize(SnapBuild *builder, XLogRecPtr lsn)
|
SnapBuildSerialize(SnapBuild *builder, XLogRecPtr lsn)
|
||||||
{
|
{
|
||||||
Size needed_length;
|
Size needed_length;
|
||||||
SnapBuildOnDisk *ondisk;
|
SnapBuildOnDisk *ondisk = NULL;
|
||||||
char *ondisk_c;
|
char *ondisk_c;
|
||||||
int fd;
|
int fd;
|
||||||
char tmppath[MAXPGPATH];
|
char tmppath[MAXPGPATH];
|
||||||
@ -1684,6 +1684,9 @@ SnapBuildSerialize(SnapBuild *builder, XLogRecPtr lsn)
|
|||||||
out:
|
out:
|
||||||
ReorderBufferSetRestartPoint(builder->reorder,
|
ReorderBufferSetRestartPoint(builder->reorder,
|
||||||
builder->last_serialized_snapshot);
|
builder->last_serialized_snapshot);
|
||||||
|
/* be tidy */
|
||||||
|
if (ondisk)
|
||||||
|
pfree(ondisk);
|
||||||
}
|
}
|
||||||
|
|
||||||
/*
|
/*
|
||||||
|
Loading…
Reference in New Issue
Block a user