rdelaage/postgresql
1
0
Fork 0
mirror of https://git.postgresql.org/git/postgresql.git synced 2024-07-31 23:53:22 +02:00
Code Issues Packages Projects Releases Wiki Activity

Fix a few typos in JIT comments and README

Browse Source 
Reviewed-by: Abhijit Menon-Sen
Reviewed-by: Andres Freund
Discussion: https://postgr.es/m/CAApHDvobgmCs6CohqhKTUf7D8vffoZXQTCBTERo9gbOeZmvLTw%40mail.gmail.com
Backpatch-through: 11, where JIT was added
This commit is contained in:
David Rowley 2020-08-21 09:34:47 +12:00
parent 2a9f042c47
commit 0d7437de73
2 changed files with 8 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
src/backend/jit/README
View File

@ -10,11 +10,11 @@ SQL expressions to evaluate an SQL predicate like WHERE a.col = 3, it
is possible to generate a function than can be natively executed by is possible to generate a function than can be natively executed by
the CPU that just handles that expression, yielding a speedup. the CPU that just handles that expression, yielding a speedup.
That this is done at query execution time, possibly even only in cases This is JIT, rather than ahead-of-time (AOT) compilation, because it
where the relevant task is done a number of times, makes it JIT, is done at query execution time, and perhaps only in cases where the
rather than ahead-of-time (AOT). Given the way JIT compilation is used relevant task is repeated a number of times. Given the way JIT
in PostgreSQL, the lines between interpretation, AOT and JIT are compilation is used in PostgreSQL, the lines between interpretation,
somewhat blurry. AOT and JIT are somewhat blurry.
Note that the interpreted program turned into a native program does Note that the interpreted program turned into a native program does
not necessarily have to be a program in the classical sense. E.g. it not necessarily have to be a program in the classical sense. E.g. it
@ -99,7 +99,7 @@ Lifetimes of JITed functions are managed via JITContext. Exactly one
such context should be created for work in which all created JITed such context should be created for work in which all created JITed
function should have the same lifetime. E.g. there's exactly one function should have the same lifetime. E.g. there's exactly one
JITContext for each query executed, in the query's EState. Only the JITContext for each query executed, in the query's EState. Only the
release of an JITContext is exposed to the provider independent release of a JITContext is exposed to the provider independent
facility, as the creation of one is done on-demand by the JIT facility, as the creation of one is done on-demand by the JIT
implementations. implementations.
@ -231,7 +231,7 @@ needs to be referenced as an offset to one block of memory stored in
an ExprState, rather than absolute pointers into memory. an ExprState, rather than absolute pointers into memory.
Once that is addressed, adding an LRU cache that's keyed by the Once that is addressed, adding an LRU cache that's keyed by the
generated LLVM IR will allow to use optimized functions even for generated LLVM IR will allow the usage of optimized functions even for
faster queries. faster queries.
A longer term project is to move expression compilation to the planner A longer term project is to move expression compilation to the planner

2
src/include/jit/llvmjit_emit.h
View File

@ -1,6 +1,6 @@
/* /*
* llvmjit_emit.h * llvmjit_emit.h
* Helpers to make emitting LLVM IR a it more concise and pgindent proof. * Helpers to make emitting LLVM IR a bit more concise and pgindent proof.
* *
* Copyright (c) 2018-2020, PostgreSQL Global Development Group * Copyright (c) 2018-2020, PostgreSQL Global Development Group
* *