mirror of
https://git.postgresql.org/git/postgresql.git
synced 2024-08-26 03:37:19 +02:00
Revert "Add valgrind suppressions for wcsrtombs optimizations"
This reverts commit bf070ce09e
.
Per discussion, it's not desirable to add valgrind suppressions for
outside our own code base (e.g. glibc in this case), especially when
the suppressions may be platform-specific. There are better ways to
deal with that, e.g. by providing local suppressions.
Discussion: https://www.postgresql.org/message-id/flat/90ac0452-e907-e7a4-b3c8-15bd33780e62%402ndquadrant.com
This commit is contained in:
parent
5279c8d097
commit
0ec29785c5
@ -212,39 +212,3 @@
|
|||||||
Memcheck:Cond
|
Memcheck:Cond
|
||||||
fun:PyObject_Realloc
|
fun:PyObject_Realloc
|
||||||
}
|
}
|
||||||
|
|
||||||
# wcsrtombs uses some clever optimizations internally, which to valgrind
|
|
||||||
# may look like access to uninitialized data. For example AVX2 instructions
|
|
||||||
# load data in 256-bit chunks, irrespectedly of wchar length. gconv does
|
|
||||||
# somethink similar by loading data in 32bit chunks and then shifting the
|
|
||||||
# data internally. Neither of those actually uses the uninitialized part
|
|
||||||
# of the buffer, as far as we know.
|
|
||||||
#
|
|
||||||
# https://www.postgresql.org/message-id/90ac0452-e907-e7a4-b3c8-15bd33780e62@2ndquadrant.com
|
|
||||||
|
|
||||||
{
|
|
||||||
wcsnlen_optimized
|
|
||||||
Memcheck:Cond
|
|
||||||
...
|
|
||||||
fun:wcsrtombs
|
|
||||||
fun:wcstombs
|
|
||||||
fun:wchar2char
|
|
||||||
}
|
|
||||||
|
|
||||||
{
|
|
||||||
wcsnlen_optimized_addr32
|
|
||||||
Memcheck:Addr32
|
|
||||||
...
|
|
||||||
fun:wcsrtombs
|
|
||||||
fun:wcstombs
|
|
||||||
fun:wchar2char
|
|
||||||
}
|
|
||||||
|
|
||||||
{
|
|
||||||
gconv_transform_internal
|
|
||||||
Memcheck:Cond
|
|
||||||
fun:__gconv_transform_internal_utf8
|
|
||||||
fun:wcsrtombs
|
|
||||||
fun:wcstombs
|
|
||||||
fun:wchar2char
|
|
||||||
}
|
|
||||||
|
Loading…
Reference in New Issue
Block a user