From 10e3991fad8a300ed268878ae30c96074628c1e1 Mon Sep 17 00:00:00 2001 From: Tom Lane Date: Sun, 7 Apr 2019 12:54:26 -0400 Subject: [PATCH] Clean up side-effects of commits ab5fcf2b0 et al. Before those commits, partitioning-related code in the executor could assume that ModifyTableState.resultRelInfo[] contains only leaf partitions. However, now a fully-pruned update results in a dummy ModifyTable that references the root partitioned table, and that breaks some stuff. In v11, this led to an assertion or core dump in the tuple routing code. Fix by disabling tuple routing, since we don't need that anyway. (I chose to do that in HEAD as well for safety, even though the problem doesn't manifest in HEAD as it stands.) In v10, this confused ExecInitModifyTable's decision about whether it needed to close the root table. But we can get rid of that altogether by being smarter about where to find the root table. Note that since the referenced commits haven't shipped yet, this isn't fixing any bug the field has seen. Amit Langote, per a report from me Discussion: https://postgr.es/m/20710.1554582479@sss.pgh.pa.us --- src/backend/optimizer/plan/planner.c | 9 +++++++++ src/test/regress/expected/inherit.out | 9 +++++++++ src/test/regress/sql/inherit.sql | 3 +++ 3 files changed, 21 insertions(+) diff --git a/src/backend/optimizer/plan/planner.c b/src/backend/optimizer/plan/planner.c index 60edaa8b0a..94b962bb6e 100644 --- a/src/backend/optimizer/plan/planner.c +++ b/src/backend/optimizer/plan/planner.c @@ -1599,6 +1599,15 @@ inheritance_planner(PlannerInfo *root) withCheckOptionLists = list_make1(parse->withCheckOptions); if (parse->returningList) returningLists = list_make1(parse->returningList); + + /* + * Since no tuples will be updated, don't require ModifyTable to + * create tuple-routing info that will be left unused. In fact it's + * necessary to do so, because we're cheating here by putting the root + * table into resultRelations list, which the tuple-routing code is + * not expecting to be there. + */ + root->partColsUpdated = false; } else { diff --git a/src/test/regress/expected/inherit.out b/src/test/regress/expected/inherit.out index f6d70e9f7a..b78a84e83e 100644 --- a/src/test/regress/expected/inherit.out +++ b/src/test/regress/expected/inherit.out @@ -665,6 +665,15 @@ select tableoid::regclass::text as relname, parted_tab.* from parted_tab order b parted_tab_part3 | 3 | a (3 rows) +-- modifies partition key, but no rows will actually be updated +explain update parted_tab set a = 2 where false; + QUERY PLAN +-------------------------------------------------------- + Update on parted_tab (cost=0.00..0.00 rows=0 width=0) + -> Result (cost=0.00..0.00 rows=0 width=0) + One-Time Filter: false +(3 rows) + drop table parted_tab; -- Check UPDATE with multi-level partitioned inherited target create table mlparted_tab (a int, b char, c text) partition by list (a); diff --git a/src/test/regress/sql/inherit.sql b/src/test/regress/sql/inherit.sql index 30a45a20ae..f97d7e5e4d 100644 --- a/src/test/regress/sql/inherit.sql +++ b/src/test/regress/sql/inherit.sql @@ -168,6 +168,9 @@ from where parted_tab.a = ss.a; select tableoid::regclass::text as relname, parted_tab.* from parted_tab order by 1,2; +-- modifies partition key, but no rows will actually be updated +explain update parted_tab set a = 2 where false; + drop table parted_tab; -- Check UPDATE with multi-level partitioned inherited target