rdelaage
/
postgresql
mirror of https://git.postgresql.org/git/postgresql.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Fix minor leak in pg_dump 

Move allocation to after we check the remote server version, to avoid
a possible, very minor, memory leak.  This makes us more consistent
throughout as most places in pg_dump are done in the same way (due, in
part, to previous fixes like this).

Spotted by the Coverity scanner.
This commit is contained in:
Stephen Frost 2014-01-26 17:58:48 -05:00
parent a7e5f7bf68
commit 152d24f5dd
1 changed files with 3 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/bin/pg_dump/pg_dump.c
View File

@ -3602,7 +3602,7 @@ getConversions(Archive *fout, int *numConversions)
PGresult *res;
int ntups;
int i;
PQExpBuffer query = createPQExpBuffer();
PQExpBuffer query;
ConvInfo *convinfo;
int i_tableoid;
int i_oid;
@ -3617,6 +3617,8 @@ getConversions(Archive *fout, int *numConversions)
return NULL;
}
query = createPQExpBuffer();
/*
* find all conversions, including builtin conversions; we filter out
* system-defined conversions at dump-out time.