From 1a4fd77db85abac63e178506335aee74625f6499 Mon Sep 17 00:00:00 2001 From: Andres Freund Date: Fri, 25 Aug 2023 06:43:37 -0700 Subject: [PATCH] Avoid non-POSIX cp flags Commit 252dcb32 used cp -a, but apparently Solaris doesn't like that. Use cp -RPp instead. Author: Thomas Munro Reviewed-by: Daniel Gustafsson Discussion: https://postgr.es/m/CA+hUKGL10AoQVMMqgOJ8CTjoz9MLidD8ik2e8PibzLNMz0+aRg@mail.gmail.com --- src/test/perl/PostgreSQL/Test/Cluster.pm | 2 +- src/test/regress/pg_regress.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/test/perl/PostgreSQL/Test/Cluster.pm b/src/test/perl/PostgreSQL/Test/Cluster.pm index 426f94ff09..227c34ab4d 100644 --- a/src/test/perl/PostgreSQL/Test/Cluster.pm +++ b/src/test/perl/PostgreSQL/Test/Cluster.pm @@ -549,7 +549,7 @@ sub init } else { - @copycmd = qw(cp -a); + @copycmd = qw(cp -RPp); $expected_exitcode = 0; } diff --git a/src/test/regress/pg_regress.c b/src/test/regress/pg_regress.c index 06674141a3..ec67588cf5 100644 --- a/src/test/regress/pg_regress.c +++ b/src/test/regress/pg_regress.c @@ -2355,7 +2355,7 @@ regression_main(int argc, char *argv[], else { #ifndef WIN32 - const char *copycmd = "cp -a \"%s\" \"%s/data\""; + const char *copycmd = "cp -RPp \"%s\" \"%s/data\""; int expected_exitcode = 0; #else const char *copycmd = "robocopy /E /NJS /NJH /NFL /NDL /NP \"%s\" \"%s/data\"";