rdelaage
/
postgresql
mirror of https://git.postgresql.org/git/postgresql.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Check for fseeko() failure in pg_dump's _tarAddFile(). 

Coverity pointed out, not unreasonably, that we checked fseeko's
result at every other call site but these.  Failure to seek in the
temp file (note this is NOT pg_dump's output file) seems quite
unlikely, and even if it did happen the file length cross-check
further down would probably detect the problem.  Still, that's a
poor excuse for not checking the result of a system call.
This commit is contained in:
Tom Lane 2020-08-09 12:39:07 -04:00
parent 1c164ef3d2
commit 1b9cde5124
1 changed files with 4 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/bin/pg_dump/pg_backup_tar.c
View File

@ -1082,11 +1082,13 @@ _tarAddFile(ArchiveHandle *AH, TAR_MEMBER *th)
/*
* Find file len & go back to start.
*/
fseeko(tmp, 0, SEEK_END);
if (fseeko(tmp, 0, SEEK_END) != 0)
fatal("error during file seek: %m");
th->fileLen = ftello(tmp);
if (th->fileLen < 0)
fatal("could not determine seek position in archive file: %m");
fseeko(tmp, 0, SEEK_SET);
if (fseeko(tmp, 0, SEEK_SET) != 0)
fatal("error during file seek: %m");
_tarWriteHeader(th);