From 1bc19dfcfea71e7ed03eff9d72072579bd678b4c Mon Sep 17 00:00:00 2001 From: Jeff Davis Date: Thu, 10 Aug 2023 10:16:59 -0700 Subject: [PATCH] Remove test from commit fa2e874946. The fix itself is fine, but the test revealed other problems related to parallel query that are not easily fixable. Remove the test for now to fix the buildfarm. Discussion: https://postgr.es/m/88825.1691665432@sss.pgh.pa.us Backpatch-through: 11 --- .../isolation/expected/search-path-inval.out | 97 ------------------- src/test/isolation/isolation_schedule | 1 - .../isolation/specs/search-path-inval.spec | 59 ----------- 3 files changed, 157 deletions(-) delete mode 100644 src/test/isolation/expected/search-path-inval.out delete mode 100644 src/test/isolation/specs/search-path-inval.spec diff --git a/src/test/isolation/expected/search-path-inval.out b/src/test/isolation/expected/search-path-inval.out deleted file mode 100644 index e0173afdb2..0000000000 --- a/src/test/isolation/expected/search-path-inval.out +++ /dev/null @@ -1,97 +0,0 @@ -Parsed test spec with 3 sessions - -starting permutation: s1a s2a s1a s2b -step s1a: - SELECT CURRENT_USER; - SHOW search_path; - SELECT t FROM x; - -current_user ----------------- -regress_sp_user1 -(1 row) - -search_path --------------------------- -"$user", regress_sp_public -(1 row) - -t --------------------------- -data in regress_sp_user1.x -(1 row) - -step s2a: - ALTER ROLE regress_sp_user1 RENAME TO regress_sp_user2; - -step s1a: - SELECT CURRENT_USER; - SHOW search_path; - SELECT t FROM x; - -current_user ----------------- -regress_sp_user2 -(1 row) - -search_path --------------------------- -"$user", regress_sp_public -(1 row) - -t ---------------------------- -data in regress_sp_public.x -(1 row) - -step s2b: - ALTER ROLE regress_sp_user2 RENAME TO regress_sp_user1; - - -starting permutation: s1a s3a s1a s3b -step s1a: - SELECT CURRENT_USER; - SHOW search_path; - SELECT t FROM x; - -current_user ----------------- -regress_sp_user1 -(1 row) - -search_path --------------------------- -"$user", regress_sp_public -(1 row) - -t --------------------------- -data in regress_sp_user1.x -(1 row) - -step s3a: - ALTER SCHEMA regress_sp_user1 RENAME TO regress_sp_user2; - -step s1a: - SELECT CURRENT_USER; - SHOW search_path; - SELECT t FROM x; - -current_user ----------------- -regress_sp_user1 -(1 row) - -search_path --------------------------- -"$user", regress_sp_public -(1 row) - -t ---------------------------- -data in regress_sp_public.x -(1 row) - -step s3b: - ALTER SCHEMA regress_sp_user2 RENAME TO regress_sp_user1; - diff --git a/src/test/isolation/isolation_schedule b/src/test/isolation/isolation_schedule index 5cfe3daf42..658f0be4b7 100644 --- a/src/test/isolation/isolation_schedule +++ b/src/test/isolation/isolation_schedule @@ -108,4 +108,3 @@ test: truncate-conflict test: serializable-parallel test: serializable-parallel-2 test: serializable-parallel-3 -test: search-path-inval diff --git a/src/test/isolation/specs/search-path-inval.spec b/src/test/isolation/specs/search-path-inval.spec deleted file mode 100644 index 08b1bba2fc..0000000000 --- a/src/test/isolation/specs/search-path-inval.spec +++ /dev/null @@ -1,59 +0,0 @@ -# Test search_path invalidation. - -setup -{ - CREATE USER regress_sp_user1; - CREATE SCHEMA regress_sp_user1 AUTHORIZATION regress_sp_user1; - CREATE SCHEMA regress_sp_public; - GRANT ALL PRIVILEGES ON SCHEMA regress_sp_public TO regress_sp_user1; -} - -teardown -{ - DROP SCHEMA regress_sp_public CASCADE; - DROP SCHEMA regress_sp_user1 CASCADE; - DROP USER regress_sp_user1; -} - -session s1 -setup -{ - SET search_path = "$user", regress_sp_public; - SET SESSION AUTHORIZATION regress_sp_user1; - CREATE TABLE regress_sp_user1.x(t) AS SELECT 'data in regress_sp_user1.x'; - CREATE TABLE regress_sp_public.x(t) AS SELECT 'data in regress_sp_public.x'; -} -step s1a -{ - SELECT CURRENT_USER; - SHOW search_path; - SELECT t FROM x; -} - -session s2 -step s2a -{ - ALTER ROLE regress_sp_user1 RENAME TO regress_sp_user2; -} -step s2b -{ - ALTER ROLE regress_sp_user2 RENAME TO regress_sp_user1; -} - -session s3 -step s3a -{ - ALTER SCHEMA regress_sp_user1 RENAME TO regress_sp_user2; -} -step s3b -{ - ALTER SCHEMA regress_sp_user2 RENAME TO regress_sp_user1; -} - -# s1's search_path is invalidated by role name change in s2a, and -# falls back to regress_sp_public.x -permutation s1a s2a s1a s2b - -# s1's search_path is invalidated by schema name change in s2b, and -# falls back to regress_sp_public.x -permutation s1a s3a s1a s3b