fsync pg_logical/mappings in CheckPointLogicalRewriteHeap().

While individual logical rewrite files were synced to disk, the directory was
not. On some filesystems that could lead to loosing directory entries after a
crash.

Reported-By: Tom Lane <tgl@sss.pgh.pa.us>
Author: Nathan Bossart <bossartn@amazon.com>
Discussion: https://postgr.es/m/867F2E29-2782-4869-970E-B984C6D35A8F@amazon.com
Backpatch: 10-
This commit is contained in:
Andres Freund 2022-01-21 11:22:55 -08:00
parent 1c0452c48c
commit 1c6d055ba7
1 changed files with 3 additions and 0 deletions

View File

@ -1312,4 +1312,7 @@ CheckPointLogicalRewriteHeap(void)
}
}
FreeDir(mappings_dir);
/* persist directory entries to disk */
fsync_fname("pg_logical/mappings", true);
}