From 1cfc9f2ef61df81fa54a697081e372672c23e980 Mon Sep 17 00:00:00 2001 From: Thomas Munro Date: Thu, 22 Jul 2021 14:11:17 +1200 Subject: [PATCH] jit: Don't inline functions that access thread-locals. Code inlined by LLVM can crash or fail with "Relocation type not implemented yet!" if it tries to access thread local variables. Don't inline such code. Back-patch to 11, where LLVM arrived. Bug #16696. Author: Dmitry Marakasov Reviewed-by: Andres Freund Discussion: https://postgr.es/m/16696-29d944a33801fbfe@postgresql.org --- src/backend/jit/llvm/llvmjit_inline.cpp | 11 +++++++++++ 1 file changed, 11 insertions(+) diff --git a/src/backend/jit/llvm/llvmjit_inline.cpp b/src/backend/jit/llvm/llvmjit_inline.cpp index 2617a461ca..40b18d9a0e 100644 --- a/src/backend/jit/llvm/llvmjit_inline.cpp +++ b/src/backend/jit/llvm/llvmjit_inline.cpp @@ -608,6 +608,17 @@ function_inlinable(llvm::Function &F, if (rv->materialize()) elog(FATAL, "failed to materialize metadata"); + /* + * Don't inline functions that access thread local variables. That + * doesn't work on current LLVM releases (but might in future). + */ + if (rv->isThreadLocal()) + { + ilog(DEBUG1, "cannot inline %s due to thread-local variable %s", + F.getName().data(), rv->getName().data()); + return false; + } + /* * Never want to inline externally visible vars, cheap enough to * reference.