From 1eee8d4994fe0b93ac02c613c1e955680e3a5ce3 Mon Sep 17 00:00:00 2001 From: Tom Lane Date: Wed, 8 Aug 2018 14:32:29 -0400 Subject: [PATCH] Remove unwanted "garbage cleanup" logic in Makefiles. GNUmakefile.in defined a macro "garbage" that seems to have been meant as a suitable target for automatic "rm -rf" treatment, but it isn't actually used anywhere (and indeed never was, AFAICT). Moreover, we have concluded that the Makefiles shouldn't take it upon themselves to remove files that aren't expected by-products of building, so that doing anything like that would be against project policy anyway. Hence, just remove the macro. Grepping around finds another violation of that policy in ecpg/preproc, so clean that up too. Daniel Gustafsson (ecpg change by me) Discussion: https://postgr.es/m/AFBEF63E-E19D-4EBB-9F08-4617CDC751ED@yesql.se --- GNUmakefile.in | 1 - src/interfaces/ecpg/preproc/Makefile | 2 -- 2 files changed, 3 deletions(-) diff --git a/GNUmakefile.in b/GNUmakefile.in index 973fef54fb..563c83b5a2 100644 --- a/GNUmakefile.in +++ b/GNUmakefile.in @@ -78,7 +78,6 @@ GNUmakefile: GNUmakefile.in $(top_builddir)/config.status distdir = postgresql-$(VERSION) dummy = =install= -garbage = =* "#"* ."#"* *~* *.orig *.rej core postgresql-* dist: $(distdir).tar.gz $(distdir).tar.bz2 rm -rf $(distdir) diff --git a/src/interfaces/ecpg/preproc/Makefile b/src/interfaces/ecpg/preproc/Makefile index b0c404e41e..07721752c8 100644 --- a/src/interfaces/ecpg/preproc/Makefile +++ b/src/interfaces/ecpg/preproc/Makefile @@ -64,8 +64,6 @@ uninstall: clean distclean: rm -f *.o ecpg$(X) -# garbage from development - @rm -f core a.out # `make distclean' must not remove preproc.y, preproc.c, preproc.h, or pgc.c # since we want to ship those files in the distribution for people with