mirror of
https://git.postgresql.org/git/postgresql.git
synced 2024-08-23 18:57:19 +02:00
Avoid invalid array reference in transformAlterTableStmt().
Don't try to look at the attidentity field of system attributes, because they're not there in the TupleDescAttr array. Sometimes this is harmless because we accidentally pick up a zero, but otherwise we'll report "no owned sequence found" from an attempt to alter a system attribute. (It seems possible that a SIGSEGV could occur, too, though I've not seen it in testing.) It's not in this function's charter to complain that you can't alter a system column, so instead just hard-wire an assumption that system attributes aren't identities. I didn't bother with a regression test because the appearance of the bug is very erratic. Per bug #17465 from Roman Zharkov. Back-patch to all supported branches. (There's not actually a live bug before v12, because before that get_attidentity() did the right thing anyway. But for consistency I changed the test in the older branches too.) Discussion: https://postgr.es/m/17465-f2a554a6cb5740d3@postgresql.org
This commit is contained in:
parent
4751a13b63
commit
20af44693c
@ -3167,7 +3167,7 @@ transformAlterTableStmt(Oid relid, AlterTableStmt *stmt,
|
|||||||
* if attribute not found, something will error about it
|
* if attribute not found, something will error about it
|
||||||
* later
|
* later
|
||||||
*/
|
*/
|
||||||
if (attnum != InvalidAttrNumber && get_attidentity(relid, attnum))
|
if (attnum > 0 && get_attidentity(relid, attnum))
|
||||||
{
|
{
|
||||||
Oid seq_relid = getOwnedSequence(relid, attnum);
|
Oid seq_relid = getOwnedSequence(relid, attnum);
|
||||||
Oid typeOid = typenameTypeId(pstate, def->typeName);
|
Oid typeOid = typenameTypeId(pstate, def->typeName);
|
||||||
|
Loading…
Reference in New Issue
Block a user