From 2401d93718310237b3cb1ff914abc1bcbdd8e1dc Mon Sep 17 00:00:00 2001 From: Amit Kapila Date: Wed, 1 Apr 2020 09:28:13 +0530 Subject: [PATCH] Fix coverity complaint about commit 40d964ec99. The coverity complained that dividing integer expressions and then converting the integer quotient to type "double" would lose fractional part. Typecasting one of the arguments of expression with double should fix the report. Author: Mahendra Singh Thalor Reviewed-by: Amit Kapila Discussion: https://postgr.es/m/20200329224818.6phnhv7o2q2rfovf@alap3.anarazel.de --- src/backend/commands/vacuum.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/backend/commands/vacuum.c b/src/backend/commands/vacuum.c index 59731d687f..3a89f8fe1e 100644 --- a/src/backend/commands/vacuum.c +++ b/src/backend/commands/vacuum.c @@ -2077,7 +2077,7 @@ compute_parallel_delay(void) VacuumCostBalanceLocal += VacuumCostBalance; if ((shared_balance >= VacuumCostLimit) && - (VacuumCostBalanceLocal > 0.5 * (VacuumCostLimit / nworkers))) + (VacuumCostBalanceLocal > 0.5 * ((double) VacuumCostLimit / nworkers))) { /* Compute sleep time based on the local cost balance */ msec = VacuumCostDelay * VacuumCostBalanceLocal / VacuumCostLimit;