From 245e14e28b298e6ed00ea8d8c607b62387c9da92 Mon Sep 17 00:00:00 2001 From: Michael Paquier Date: Thu, 4 Aug 2022 17:36:21 +0900 Subject: [PATCH] Fix inconsistent comments for some function declarations in headers Some of the headers list a couple of function prototypes located in a different file than what is referred to. This fixes a couple of places where this inconsistency exists. Author: Richard Guo Discussion: https://postgr.es/m/CAMbWs4__RdcSNXPa7L62Ozvo_Q4LvT60o3Bnp8yrQ_m9y5CKvg@mail.gmail.com --- src/include/access/nbtxlog.h | 8 ++++++-- src/include/replication/walreceiver.h | 2 +- src/include/storage/bufmgr.h | 11 +++++++---- 3 files changed, 14 insertions(+), 7 deletions(-) diff --git a/src/include/access/nbtxlog.h b/src/include/access/nbtxlog.h index d79489efe4..dd504d1885 100644 --- a/src/include/access/nbtxlog.h +++ b/src/include/access/nbtxlog.h @@ -342,10 +342,14 @@ typedef struct xl_btree_newroot * prototypes for functions in nbtxlog.c */ extern void btree_redo(XLogReaderState *record); -extern void btree_desc(StringInfo buf, XLogReaderState *record); -extern const char *btree_identify(uint8 info); extern void btree_xlog_startup(void); extern void btree_xlog_cleanup(void); extern void btree_mask(char *pagedata, BlockNumber blkno); +/* + * prototypes for functions in nbtdesc.c + */ +extern void btree_desc(StringInfo buf, XLogReaderState *record); +extern const char *btree_identify(uint8 info); + #endif /* NBTXLOG_H */ diff --git a/src/include/replication/walreceiver.h b/src/include/replication/walreceiver.h index 88d7cc6abc..bd8398de0b 100644 --- a/src/include/replication/walreceiver.h +++ b/src/include/replication/walreceiver.h @@ -455,6 +455,7 @@ walrcv_clear_result(WalRcvExecResult *walres) /* prototypes for functions in walreceiver.c */ extern void WalReceiverMain(void) pg_attribute_noreturn(); extern void ProcessWalRcvInterrupts(void); +extern void WalRcvForceReply(void); /* prototypes for functions in walreceiverfuncs.c */ extern Size WalRcvShmemSize(void); @@ -469,6 +470,5 @@ extern XLogRecPtr GetWalRcvFlushRecPtr(XLogRecPtr *latestChunkStart, TimeLineID extern XLogRecPtr GetWalRcvWriteRecPtr(void); extern int GetReplicationApplyDelay(void); extern int GetReplicationTransferLatency(void); -extern void WalRcvForceReply(void); #endif /* _WALRECEIVER_H */ diff --git a/src/include/storage/bufmgr.h b/src/include/storage/bufmgr.h index bf8cce7ccf..6f4dfa0960 100644 --- a/src/include/storage/bufmgr.h +++ b/src/include/storage/bufmgr.h @@ -123,7 +123,6 @@ extern void IncrBufferRefCount(Buffer buffer); extern Buffer ReleaseAndReadBuffer(Buffer buffer, Relation relation, BlockNumber blockNum); -extern void InitBufferPool(void); extern void InitBufferPoolAccess(void); extern void AtEOXact_Buffers(bool isCommit); extern void PrintBufferLeakWarning(Buffer buffer); @@ -154,7 +153,6 @@ extern XLogRecPtr BufferGetLSNAtomic(Buffer buffer); #ifdef NOT_USED extern void PrintPinnedBufs(void); #endif -extern Size BufferShmemSize(void); extern void BufferGetTag(Buffer buffer, RelFileLocator *rlocator, ForkNumber *forknum, BlockNumber *blknum); @@ -173,10 +171,15 @@ extern void AbortBufferIO(void); extern void BufmgrCommit(void); extern bool BgBufferSync(struct WritebackContext *wb_context); -extern void AtProcExit_LocalBuffers(void); - extern void TestForOldSnapshot_impl(Snapshot snapshot, Relation relation); +/* in buf_init.c */ +extern void InitBufferPool(void); +extern Size BufferShmemSize(void); + +/* in localbuf.c */ +extern void AtProcExit_LocalBuffers(void); + /* in freelist.c */ extern BufferAccessStrategy GetAccessStrategy(BufferAccessStrategyType btype); extern void FreeAccessStrategy(BufferAccessStrategy strategy);