From 2836d57e44c67cc30453c83a33fbcf745f5d87ef Mon Sep 17 00:00:00 2001 From: Tom Lane Date: Fri, 3 Sep 2021 10:01:02 -0400 Subject: [PATCH] Fix portability issue in tests from commit ce773f230. Modern POSIX seems to require strtod() to accept "-NaN", but there's nothing about NaN in SUSv2, and some of our oldest buildfarm members don't like it. Let's try writing it as -'NaN' instead; that seems to produce the same result, at least on Intel hardware. Per buildfarm. --- src/test/regress/expected/hash_func.out | 4 ++-- src/test/regress/sql/hash_func.sql | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/src/test/regress/expected/hash_func.out b/src/test/regress/expected/hash_func.out index 46b9788d07..d026fbcb3d 100644 --- a/src/test/regress/expected/hash_func.out +++ b/src/test/regress/expected/hash_func.out @@ -307,7 +307,7 @@ SELECT hashfloat4('0'::float4) = hashfloat4('-0'::float4) AS t; t (1 row) -SELECT hashfloat4('NaN'::float4) = hashfloat4('-NaN'::float4) AS t; +SELECT hashfloat4('NaN'::float4) = hashfloat4(-'NaN'::float4) AS t; t --- t @@ -319,7 +319,7 @@ SELECT hashfloat8('0'::float8) = hashfloat8('-0'::float8) AS t; t (1 row) -SELECT hashfloat8('NaN'::float8) = hashfloat8('-NaN'::float8) AS t; +SELECT hashfloat8('NaN'::float8) = hashfloat8(-'NaN'::float8) AS t; t --- t diff --git a/src/test/regress/sql/hash_func.sql b/src/test/regress/sql/hash_func.sql index 5e4f232386..89c91f72b7 100644 --- a/src/test/regress/sql/hash_func.sql +++ b/src/test/regress/sql/hash_func.sql @@ -225,7 +225,7 @@ WHERE hash_range(v)::bit(32) != hash_range_extended(v, 0)::bit(32) -- Check special cases for specific data types -- SELECT hashfloat4('0'::float4) = hashfloat4('-0'::float4) AS t; -SELECT hashfloat4('NaN'::float4) = hashfloat4('-NaN'::float4) AS t; +SELECT hashfloat4('NaN'::float4) = hashfloat4(-'NaN'::float4) AS t; SELECT hashfloat8('0'::float8) = hashfloat8('-0'::float8) AS t; -SELECT hashfloat8('NaN'::float8) = hashfloat8('-NaN'::float8) AS t; +SELECT hashfloat8('NaN'::float8) = hashfloat8(-'NaN'::float8) AS t; SELECT hashfloat4('NaN'::float4) = hashfloat8('NaN'::float8) AS t;