From 2ac1b2b175ea5456516e59fe2b53a1e0578a5dbd Mon Sep 17 00:00:00 2001 From: Andres Freund Date: Mon, 25 Mar 2019 19:02:36 -0700 Subject: [PATCH] Remove heap_hot_search(). After 71bdc99d0d7, "tableam: Add helper for indexes to check if a corresponding table tuples exist." there's no in-core user left. As there's unlikely to be an external user, and such an external user could easily be adjusted to use table_index_fetch_tuple_check(), remove heap_hot_search(). Per complaint from Peter Geoghegan Author: Andres Freund Discussion: https://postgr.es/m/CAH2-Wzn0Oq4ftJrTqRAsWy2WGjv0QrJcwoZ+yqWsF_Z5vjUBFw@mail.gmail.com --- src/backend/access/heap/heapam.c | 24 ------------------------ src/include/access/heapam.h | 2 -- 2 files changed, 26 deletions(-) diff --git a/src/backend/access/heap/heapam.c b/src/backend/access/heap/heapam.c index fa747be73a..137cc9257d 100644 --- a/src/backend/access/heap/heapam.c +++ b/src/backend/access/heap/heapam.c @@ -1636,30 +1636,6 @@ heap_hot_search_buffer(ItemPointer tid, Relation relation, Buffer buffer, return false; } -/* - * heap_hot_search - search HOT chain for tuple satisfying snapshot - * - * This has the same API as heap_hot_search_buffer, except that the caller - * does not provide the buffer containing the page, rather we access it - * locally. - */ -bool -heap_hot_search(ItemPointer tid, Relation relation, Snapshot snapshot, - bool *all_dead) -{ - bool result; - Buffer buffer; - HeapTupleData heapTuple; - - buffer = ReadBuffer(relation, ItemPointerGetBlockNumber(tid)); - LockBuffer(buffer, BUFFER_LOCK_SHARE); - result = heap_hot_search_buffer(tid, relation, buffer, snapshot, - &heapTuple, all_dead, true); - LockBuffer(buffer, BUFFER_LOCK_UNLOCK); - ReleaseBuffer(buffer); - return result; -} - /* * heap_get_latest_tid - get the latest tid of a specified tuple * diff --git a/src/include/access/heapam.h b/src/include/access/heapam.h index e72f978751..3773a4df85 100644 --- a/src/include/access/heapam.h +++ b/src/include/access/heapam.h @@ -132,8 +132,6 @@ extern bool heap_fetch(Relation relation, Snapshot snapshot, extern bool heap_hot_search_buffer(ItemPointer tid, Relation relation, Buffer buffer, Snapshot snapshot, HeapTuple heapTuple, bool *all_dead, bool first_call); -extern bool heap_hot_search(ItemPointer tid, Relation relation, - Snapshot snapshot, bool *all_dead); extern void heap_get_latest_tid(Relation relation, Snapshot snapshot, ItemPointer tid);