From 2ad98fdf53edf1a90123e3b189cc6f0a31986891 Mon Sep 17 00:00:00 2001 From: Michael Paquier Date: Thu, 29 Jul 2021 10:59:49 +0900 Subject: [PATCH] Add missing exit() in pg_verifybackup when failing to find pg_waldump pg_verifybackup needs by default pg_waldump to check after a range of WAL segments required for a backup, except if --no-parse-wal is specified. The code checked for the presence of the binary pg_waldump in an installation and reported an error, but it forgot to properly exit(). This could lead to confusing errors reported. Reviewed-by: Robert Haas, Fabien Coelho Discussion: https://postgr.es/m/YQDMdB+B68yePFeT@paquier.xyz Backpatch-through: 13 --- src/bin/pg_verifybackup/pg_verifybackup.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/bin/pg_verifybackup/pg_verifybackup.c b/src/bin/pg_verifybackup/pg_verifybackup.c index f5ebd57a47..bb93b43093 100644 --- a/src/bin/pg_verifybackup/pg_verifybackup.c +++ b/src/bin/pg_verifybackup/pg_verifybackup.c @@ -304,6 +304,7 @@ main(int argc, char **argv) "but was not the same version as %s.\n" "Check your installation.", "pg_waldump", full_path, "pg_verifybackup"); + exit(1); } }