rdelaage
/
postgresql
mirror of https://git.postgresql.org/git/postgresql.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Add diagnostic output on error in pump_until 

When pump_until was moved to Utils.pm in commit 6da65a3f9 the diag
calls were removed, this puts them back.

Per request from Andres Freund.

Discussion: https://postgr.es/m/20220329225819.ahk5u2tax3ez6d2t@alap3.anarazel.de
This commit is contained in:
Daniel Gustafsson 2022-03-31 11:16:16 +02:00
parent 8f2e2bbf14
commit 2beb4acff1
1 changed files with 10 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
src/test/perl/PostgreSQL/Test/Utils.pm
View File

@ -426,8 +426,16 @@ sub pump_until
while (1) while (1)
{ {
last if $$stream =~ /$until/; last if $$stream =~ /$until/;
return 0 if ($timeout->is_expired); if ($timeout->is_expired)
return 0 if (not $proc->pumpable()); {
diag("pump_until: timeout expired when searching for \"$until\" with stream: \"$$stream\"");
return 0;
}
if (not $proc->pumpable())
{
diag("pump_until: process terminated unexpectedly when searching for \"$until\" with stream: \"$$stream\"");
return 0;
}
$proc->pump(); $proc->pump();
} }
return 1; return 1;