rdelaage
/
postgresql
mirror of https://git.postgresql.org/git/postgresql.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Check version before allocating PQExpBuffer 

In pg_dump.c:getEventTriggers, check what major version we are on
before calling createPQExpBuffer() to avoid leaking that bit of
memory.

Leak discovered by the Coverity scanner.

Back-patch to 9.3 where support for dumping event triggers was
added.
This commit is contained in:
Stephen Frost 2013-07-14 21:17:59 -04:00
parent 01337d46eb
commit 3355443fb1
1 changed files with 3 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/bin/pg_dump/pg_dump.c
View File

@ -5746,7 +5746,7 @@ EventTriggerInfo *
getEventTriggers(Archive *fout, int *numEventTriggers) getEventTriggers(Archive *fout, int *numEventTriggers)
{ {
int i; int i;
PQExpBuffer query = createPQExpBuffer(); PQExpBuffer query;
PGresult *res; PGresult *res;
EventTriggerInfo *evtinfo; EventTriggerInfo *evtinfo;
int i_tableoid, int i_tableoid,
@ -5766,6 +5766,8 @@ getEventTriggers(Archive *fout, int *numEventTriggers)
return NULL; return NULL;
} }
query = createPQExpBuffer();
/* Make sure we are in proper schema */ /* Make sure we are in proper schema */
selectSourceSchema(fout, "pg_catalog"); selectSourceSchema(fout, "pg_catalog");