From 3659c62350c9f362007b21c5cc1677c401cc3a33 Mon Sep 17 00:00:00 2001 From: Andrew Dunstan Date: Wed, 16 Jun 2010 14:50:34 +0000 Subject: [PATCH] Remove perl symbol table additions for plperl functions, and mention of it in the release notes, as it is not apparently providing anything useful. --- doc/src/sgml/release-9.0.sgml | 14 +------------- src/pl/plperl/plperl.c | 6 +----- 2 files changed, 2 insertions(+), 18 deletions(-) diff --git a/doc/src/sgml/release-9.0.sgml b/doc/src/sgml/release-9.0.sgml index d3fabaf83e..3f3c966894 100644 --- a/doc/src/sgml/release-9.0.sgml +++ b/doc/src/sgml/release-9.0.sgml @@ -1,4 +1,4 @@ - + Release 9.0 @@ -1759,18 +1759,6 @@ - - - PL/Perl subroutines are now given perl-visible names (Tim Bunce) - - - - PL/Perl subroutines are anonymous subrefs; this change adds entries - to the Perl symbol table for them, making profiling and code coverage - tools much more usable. - - - diff --git a/src/pl/plperl/plperl.c b/src/pl/plperl/plperl.c index 7c65454883..b22801b851 100644 --- a/src/pl/plperl/plperl.c +++ b/src/pl/plperl/plperl.c @@ -1,7 +1,7 @@ /********************************************************************** * plperl.c - perl as a procedural language for PostgreSQL * - * $PostgreSQL: pgsql/src/pl/plperl/plperl.c,v 1.176 2010/05/17 19:43:04 adunstan Exp $ + * $PostgreSQL: pgsql/src/pl/plperl/plperl.c,v 1.177 2010/06/16 14:50:34 adunstan Exp $ * **********************************************************************/ @@ -1319,10 +1319,6 @@ plperl_create_sub(plperl_proc_desc *prodesc, char *s, Oid fn_oid) (errmsg("didn't get a CODE ref from compiling %s", prodesc->proname))); - /* give the subroutine a proper name in the main:: symbol table */ - CvGV(SvRV(subref)) = (GV *) newSV(0); - gv_init(CvGV(SvRV(subref)), PL_defstash, subname, strlen(subname), TRUE); - prodesc->reference = subref; return;