From 36758c472ea71dae96f4b495df65490413c79c83 Mon Sep 17 00:00:00 2001 From: Joe Conway Date: Thu, 28 May 2020 13:17:04 -0400 Subject: [PATCH] Add CHECK_FOR_INTERRUPTS() to the repeat() function The repeat() function loops for potentially a long time without ever checking for interrupts. This prevents, for example, a query cancel from interrupting until the work is all done. Fix by inserting a CHECK_FOR_INTERRUPTS() into the loop. Backpatch to all supported versions. Discussion: https://www.postgresql.org/message-id/flat/8692553c-7fe8-17d9-cbc1-7cddb758f4c6%40joeconway.com --- src/backend/utils/adt/oracle_compat.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/backend/utils/adt/oracle_compat.c b/src/backend/utils/adt/oracle_compat.c index c827001ad3..2d94f8b0da 100644 --- a/src/backend/utils/adt/oracle_compat.c +++ b/src/backend/utils/adt/oracle_compat.c @@ -19,7 +19,7 @@ #include "utils/builtins.h" #include "utils/formatting.h" #include "mb/pg_wchar.h" - +#include "miscadmin.h" static text *dotrim(const char *string, int stringlen, const char *set, int setlen, @@ -1062,6 +1062,7 @@ repeat(PG_FUNCTION_ARGS) { memcpy(cp, sp, slen); cp += slen; + CHECK_FOR_INTERRUPTS(); } PG_RETURN_TEXT_P(result);